RE: RE: RE: [PATCH v22 4/4] scsi: ufs: Add HPB 2.0 support

2021-02-24 Thread Avri Altman
> > > > > > @@ -2656,7 +2656,12 @@ static int ufshcd_queuecommand(struct > > > > Scsi_Host > > > > > > *host, struct scsi_cmnd *cmd) > > > > > > > > > > > > lrbp->req_abort_skip = false; > > > > > > > > > > > > - ufshpb_prep(hba, lrbp); > > > > > > + err = ufshpb_prep(hba,

RE: RE: [PATCH v22 4/4] scsi: ufs: Add HPB 2.0 support

2021-02-24 Thread Daejun Park
> > + copied = ufshpb_fill_ppn_from_page(hpb, srgn->mctx, srgn_offset, > > + pre_req->wb.len - offset, > > + [offset]); > > + > > + if (copied < 0) > > + goto mctx_error; > > + > > +

RE: RE: RE: [PATCH v22 4/4] scsi: ufs: Add HPB 2.0 support

2021-02-24 Thread Daejun Park
> > > > @@ -2656,7 +2656,12 @@ static int ufshcd_queuecommand(struct > > > Scsi_Host > > > > > *host, struct scsi_cmnd *cmd) > > > > > > > > > > lrbp->req_abort_skip = false; > > > > > > > > > > - ufshpb_prep(hba, lrbp); > > > > > + err = ufshpb_prep(hba, lrbp); > > > > > +

RE: RE: [PATCH v22 4/4] scsi: ufs: Add HPB 2.0 support

2021-02-24 Thread Avri Altman
> > > > > > @@ -2656,7 +2656,12 @@ static int ufshcd_queuecommand(struct > > Scsi_Host > > > > *host, struct scsi_cmnd *cmd) > > > > > > > > lrbp->req_abort_skip = false; > > > > > > > > - ufshpb_prep(hba, lrbp); > > > > + err = ufshpb_prep(hba, lrbp); > > > > + if (err

RE: RE: [PATCH v22 4/4] scsi: ufs: Add HPB 2.0 support

2021-02-24 Thread Avri Altman
> > > > @@ -2656,7 +2656,12 @@ static int ufshcd_queuecommand(struct > Scsi_Host > > > *host, struct scsi_cmnd *cmd) > > > > > > lrbp->req_abort_skip = false; > > > > > > - ufshpb_prep(hba, lrbp); > > > + err = ufshpb_prep(hba, lrbp); > > > + if (err == -EAGAIN) { > > >

RE: RE: [PATCH v22 4/4] scsi: ufs: Add HPB 2.0 support

2021-02-23 Thread Daejun Park
> > @@ -2656,7 +2656,12 @@ static int ufshcd_queuecommand(struct Scsi_Host > > *host, struct scsi_cmnd *cmd) > > > > lrbp->req_abort_skip = false; > > > > - ufshpb_prep(hba, lrbp); > > + err = ufshpb_prep(hba, lrbp); > > + if (err == -EAGAIN) { > > +

RE: Re: [PATCH v22 4/4] scsi: ufs: Add HPB 2.0 support

2021-02-23 Thread Daejun Park
> > } > > } > > @@ -532,8 +870,8 @@ static int ufshpb_execute_map_req(struct > > ufshpb_lu *hpb, > > if (unlikely(last)) > > mem_size = hpb->last_srgn_entries * HPB_ENTRY_SIZE; > > > > - ufshpb_set_read_buf_cmd(rq->cmd, map_req->rgn_idx, > >

RE: RE: [PATCH v22 4/4] scsi: ufs: Add HPB 2.0 support

2021-02-23 Thread Daejun Park
> > @@ -7447,8 +7452,14 @@ static int ufs_get_device_desc(struct ufs_hba *hba) > > > > if (dev_info->wspecversion >= UFS_DEV_HPB_SUPPORT_VERSION && > > (b_ufs_feature_sup & UFS_DEV_HPB_SUPPORT)) { > > - dev_info->hpb_enabled = true; > > -

RE: Re: [PATCH v22 4/4] scsi: ufs: Add HPB 2.0 support

2021-02-23 Thread Daejun Park
> > +} > > +static DEVICE_ATTR_RW(requeue_timeout_ms); > > + > > +static struct attribute *hpb_dev_param_attrs[] = { > > + _attr_requeue_timeout_ms.attr, > > +}; > > here, you lost a NULL member at the end of attribute struct. > OK, I will. Thanks, Daejun