RE: Re: [V2 PATCH 1/3] x86/panic: Fix re-entrance problem due to panic on NMI

2015-08-04 Thread 河合英宏 / KAWAI,HIDEHIRO
Hi, > From: Michal Hocko [mailto:mho...@kernel.org] > On Fri 31-07-15 11:23:00, 河合英宏 / KAWAI,HIDEHIRO wrote: > > > From: Michal Hocko [mailto:mho...@kernel.org] > > > > There is a timeout of 1000ms in nmi_shootdown_cpus(), so I don't know > > > > why CPU 130 waits so long. I'll try to consider

Re: Re: [V2 PATCH 1/3] x86/panic: Fix re-entrance problem due to panic on NMI

2015-08-04 Thread Michal Hocko
On Fri 31-07-15 11:23:00, 河合英宏 / KAWAI,HIDEHIRO wrote: > > From: Michal Hocko [mailto:mho...@kernel.org] [...] > > I am saying that watchdog_overflow_callback might trigger on more CPUs > > and panic from NMI context as well. So this is not reduced to the NMI > > button sends NMI to more CPUs. >

Re: Re: [V2 PATCH 1/3] x86/panic: Fix re-entrance problem due to panic on NMI

2015-08-04 Thread Michal Hocko
On Fri 31-07-15 11:23:00, 河合英宏 / KAWAI,HIDEHIRO wrote: From: Michal Hocko [mailto:mho...@kernel.org] [...] I am saying that watchdog_overflow_callback might trigger on more CPUs and panic from NMI context as well. So this is not reduced to the NMI button sends NMI to more CPUs. I

RE: Re: [V2 PATCH 1/3] x86/panic: Fix re-entrance problem due to panic on NMI

2015-08-04 Thread 河合英宏 / KAWAI,HIDEHIRO
Hi, From: Michal Hocko [mailto:mho...@kernel.org] On Fri 31-07-15 11:23:00, 河合英宏 / KAWAI,HIDEHIRO wrote: From: Michal Hocko [mailto:mho...@kernel.org] There is a timeout of 1000ms in nmi_shootdown_cpus(), so I don't know why CPU 130 waits so long. I'll try to consider for a while.

RE: Re: [V2 PATCH 1/3] x86/panic: Fix re-entrance problem due to panic on NMI

2015-07-31 Thread 河合英宏 / KAWAI,HIDEHIRO
> From: Michal Hocko [mailto:mho...@kernel.org] > > On Thu 30-07-15 11:55:52, 河合英宏 / KAWAI,HIDEHIRO wrote: > > > From: Michal Hocko [mailto:mho...@kernel.org] > [...] > > > Could you point me to the code which does that, please? Maybe we are > > > missing that in our 3.0 kernel. I was quite

RE: Re: [V2 PATCH 1/3] x86/panic: Fix re-entrance problem due to panic on NMI

2015-07-31 Thread 河合英宏 / KAWAI,HIDEHIRO
From: Michal Hocko [mailto:mho...@kernel.org] On Thu 30-07-15 11:55:52, 河合英宏 / KAWAI,HIDEHIRO wrote: From: Michal Hocko [mailto:mho...@kernel.org] [...] Could you point me to the code which does that, please? Maybe we are missing that in our 3.0 kernel. I was quite surprised to see

Re: Re: [V2 PATCH 1/3] x86/panic: Fix re-entrance problem due to panic on NMI

2015-07-30 Thread Michal Hocko
On Thu 30-07-15 11:55:52, 河合英宏 / KAWAI,HIDEHIRO wrote: > > From: Michal Hocko [mailto:mho...@kernel.org] [...] > > Could you point me to the code which does that, please? Maybe we are > > missing that in our 3.0 kernel. I was quite surprised to see this > > behavior as well. > > Please see the

RE: Re: [V2 PATCH 1/3] x86/panic: Fix re-entrance problem due to panic on NMI

2015-07-30 Thread 河合英宏 / KAWAI,HIDEHIRO
> From: Michal Hocko [mailto:mho...@kernel.org] > > On Thu 30-07-15 01:45:35, 河合英宏 / KAWAI,HIDEHIRO wrote: > > Hi, > > > > > From: Michal Hocko [mailto:mho...@kernel.org] > > > > > > On Wed 29-07-15 09:09:18, 河合英宏 / KAWAI,HIDEHIRO wrote: > [...] > > > > #define nmi_panic(fmt, ...)

RE: Re: [V2 PATCH 1/3] x86/panic: Fix re-entrance problem due to panic on NMI

2015-07-30 Thread 河合英宏 / KAWAI,HIDEHIRO
Hi, > -Original Message- > From: Michal Hocko [mailto:mho...@kernel.org] > > On Thu 30-07-15 07:33:15, 河合英宏 / KAWAI,HIDEHIRO wrote: > [...] > > Are you using SGI UV? On that platform, NMIs may be delivered to > > all cpus because LVT1 of all cpus are not masked as follows: > > This is

Re: Re: [V2 PATCH 1/3] x86/panic: Fix re-entrance problem due to panic on NMI

2015-07-30 Thread Michal Hocko
On Thu 30-07-15 07:33:15, 河合英宏 / KAWAI,HIDEHIRO wrote: [...] > Are you using SGI UV? On that platform, NMIs may be delivered to > all cpus because LVT1 of all cpus are not masked as follows: This is Compute Blade 520XB1 from Hitachi with 240 cpus. -- Michal Hocko SUSE Labs -- To unsubscribe

Re: Re: [V2 PATCH 1/3] x86/panic: Fix re-entrance problem due to panic on NMI

2015-07-30 Thread Michal Hocko
On Thu 30-07-15 01:45:35, 河合英宏 / KAWAI,HIDEHIRO wrote: > Hi, > > > From: Michal Hocko [mailto:mho...@kernel.org] > > > > On Wed 29-07-15 09:09:18, 河合英宏 / KAWAI,HIDEHIRO wrote: [...] > > > #define nmi_panic(fmt, ...)\ > > >do {

RE: Re: [V2 PATCH 1/3] x86/panic: Fix re-entrance problem due to panic on NMI

2015-07-30 Thread 河合英宏 / KAWAI,HIDEHIRO
Hi Michal, > From: 河合英宏 / KAWAI,HIDEHIRO [mailto:hidehiro.kawai...@hitachi.com] > > When I was testing my > > previous approach (on 3.0 based kernel) I had basically the same thing > > (one NMI to process panic) and others to return. This led to a strange > > behavior when the NMI button

Re: Re: [V2 PATCH 1/3] x86/panic: Fix re-entrance problem due to panic on NMI

2015-07-30 Thread Michal Hocko
On Thu 30-07-15 11:55:52, 河合英宏 / KAWAI,HIDEHIRO wrote: From: Michal Hocko [mailto:mho...@kernel.org] [...] Could you point me to the code which does that, please? Maybe we are missing that in our 3.0 kernel. I was quite surprised to see this behavior as well. Please see the snippet

RE: Re: [V2 PATCH 1/3] x86/panic: Fix re-entrance problem due to panic on NMI

2015-07-30 Thread 河合英宏 / KAWAI,HIDEHIRO
From: Michal Hocko [mailto:mho...@kernel.org] On Thu 30-07-15 01:45:35, 河合英宏 / KAWAI,HIDEHIRO wrote: Hi, From: Michal Hocko [mailto:mho...@kernel.org] On Wed 29-07-15 09:09:18, 河合英宏 / KAWAI,HIDEHIRO wrote: [...] #define nmi_panic(fmt, ...)

Re: Re: [V2 PATCH 1/3] x86/panic: Fix re-entrance problem due to panic on NMI

2015-07-30 Thread Michal Hocko
On Thu 30-07-15 01:45:35, 河合英宏 / KAWAI,HIDEHIRO wrote: Hi, From: Michal Hocko [mailto:mho...@kernel.org] On Wed 29-07-15 09:09:18, 河合英宏 / KAWAI,HIDEHIRO wrote: [...] #define nmi_panic(fmt, ...)\ do {

Re: Re: [V2 PATCH 1/3] x86/panic: Fix re-entrance problem due to panic on NMI

2015-07-30 Thread Michal Hocko
On Thu 30-07-15 07:33:15, 河合英宏 / KAWAI,HIDEHIRO wrote: [...] Are you using SGI UV? On that platform, NMIs may be delivered to all cpus because LVT1 of all cpus are not masked as follows: This is Compute Blade 520XB1 from Hitachi with 240 cpus. -- Michal Hocko SUSE Labs -- To unsubscribe from

RE: Re: [V2 PATCH 1/3] x86/panic: Fix re-entrance problem due to panic on NMI

2015-07-30 Thread 河合英宏 / KAWAI,HIDEHIRO
Hi, -Original Message- From: Michal Hocko [mailto:mho...@kernel.org] On Thu 30-07-15 07:33:15, 河合英宏 / KAWAI,HIDEHIRO wrote: [...] Are you using SGI UV? On that platform, NMIs may be delivered to all cpus because LVT1 of all cpus are not masked as follows: This is Compute

RE: Re: [V2 PATCH 1/3] x86/panic: Fix re-entrance problem due to panic on NMI

2015-07-30 Thread 河合英宏 / KAWAI,HIDEHIRO
Hi Michal, From: 河合英宏 / KAWAI,HIDEHIRO [mailto:hidehiro.kawai...@hitachi.com] When I was testing my previous approach (on 3.0 based kernel) I had basically the same thing (one NMI to process panic) and others to return. This led to a strange behavior when the NMI button triggered NMI on

RE: Re: [V2 PATCH 1/3] x86/panic: Fix re-entrance problem due to panic on NMI

2015-07-29 Thread 河合英宏 / KAWAI,HIDEHIRO
Hi, > From: Michal Hocko [mailto:mho...@kernel.org] > > On Wed 29-07-15 09:09:18, 河合英宏 / KAWAI,HIDEHIRO wrote: > > > From: Michal Hocko [mailto:mho...@kernel.org] > > > On Wed 29-07-15 05:48:47, 河合英宏 / KAWAI,HIDEHIRO wrote: > > > > Hi, > > > > > > > > > From: linux-kernel-ow...@vger.kernel.org

Re: Re: [V2 PATCH 1/3] x86/panic: Fix re-entrance problem due to panic on NMI

2015-07-29 Thread Michal Hocko
On Wed 29-07-15 09:09:18, 河合英宏 / KAWAI,HIDEHIRO wrote: > > From: Michal Hocko [mailto:mho...@kernel.org] > > On Wed 29-07-15 05:48:47, 河合英宏 / KAWAI,HIDEHIRO wrote: > > > Hi, > > > > > > > From: linux-kernel-ow...@vger.kernel.org > > > > [mailto:linux-kernel-ow...@vger.kernel.org] On Behalf Of

RE: Re: [V2 PATCH 1/3] x86/panic: Fix re-entrance problem due to panic on NMI

2015-07-29 Thread 河合英宏 / KAWAI,HIDEHIRO
> From: Michal Hocko [mailto:mho...@kernel.org] > On Wed 29-07-15 05:48:47, 河合英宏 / KAWAI,HIDEHIRO wrote: > > Hi, > > > > > From: linux-kernel-ow...@vger.kernel.org > > > [mailto:linux-kernel-ow...@vger.kernel.org] On Behalf Of Hidehiro Kawai > > > (2015/07/27 23:34), Michal Hocko wrote: > > > >

Re: Re: [V2 PATCH 1/3] x86/panic: Fix re-entrance problem due to panic on NMI

2015-07-29 Thread Michal Hocko
On Wed 29-07-15 05:48:47, 河合英宏 / KAWAI,HIDEHIRO wrote: > Hi, > > > From: linux-kernel-ow...@vger.kernel.org > > [mailto:linux-kernel-ow...@vger.kernel.org] On Behalf Of Hidehiro Kawai > > (2015/07/27 23:34), Michal Hocko wrote: > > > On Mon 27-07-15 10:58:50, Hidehiro Kawai wrote: > [...] > > >

RE: Re: [V2 PATCH 1/3] x86/panic: Fix re-entrance problem due to panic on NMI

2015-07-29 Thread 河合英宏 / KAWAI,HIDEHIRO
Hi, From: Michal Hocko [mailto:mho...@kernel.org] On Wed 29-07-15 09:09:18, 河合英宏 / KAWAI,HIDEHIRO wrote: From: Michal Hocko [mailto:mho...@kernel.org] On Wed 29-07-15 05:48:47, 河合英宏 / KAWAI,HIDEHIRO wrote: Hi, From: linux-kernel-ow...@vger.kernel.org

Re: Re: [V2 PATCH 1/3] x86/panic: Fix re-entrance problem due to panic on NMI

2015-07-29 Thread Michal Hocko
On Wed 29-07-15 09:09:18, 河合英宏 / KAWAI,HIDEHIRO wrote: From: Michal Hocko [mailto:mho...@kernel.org] On Wed 29-07-15 05:48:47, 河合英宏 / KAWAI,HIDEHIRO wrote: Hi, From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel-ow...@vger.kernel.org] On Behalf Of Hidehiro Kawai

Re: Re: [V2 PATCH 1/3] x86/panic: Fix re-entrance problem due to panic on NMI

2015-07-29 Thread Michal Hocko
On Wed 29-07-15 05:48:47, 河合英宏 / KAWAI,HIDEHIRO wrote: Hi, From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel-ow...@vger.kernel.org] On Behalf Of Hidehiro Kawai (2015/07/27 23:34), Michal Hocko wrote: On Mon 27-07-15 10:58:50, Hidehiro Kawai wrote: [...] The check could

RE: Re: [V2 PATCH 1/3] x86/panic: Fix re-entrance problem due to panic on NMI

2015-07-29 Thread 河合英宏 / KAWAI,HIDEHIRO
From: Michal Hocko [mailto:mho...@kernel.org] On Wed 29-07-15 05:48:47, 河合英宏 / KAWAI,HIDEHIRO wrote: Hi, From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel-ow...@vger.kernel.org] On Behalf Of Hidehiro Kawai (2015/07/27 23:34), Michal Hocko wrote: On Mon 27-07-15

RE: Re: [V2 PATCH 1/3] x86/panic: Fix re-entrance problem due to panic on NMI

2015-07-28 Thread 河合英宏 / KAWAI,HIDEHIRO
Hi, > From: linux-kernel-ow...@vger.kernel.org > [mailto:linux-kernel-ow...@vger.kernel.org] On Behalf Of Hidehiro Kawai > (2015/07/27 23:34), Michal Hocko wrote: > > On Mon 27-07-15 10:58:50, Hidehiro Kawai wrote: [...] > > The check could be also relaxed a bit and nmi_panic would > > return

RE: Re: [V2 PATCH 1/3] x86/panic: Fix re-entrance problem due to panic on NMI

2015-07-28 Thread 河合英宏 / KAWAI,HIDEHIRO
Hi, From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel-ow...@vger.kernel.org] On Behalf Of Hidehiro Kawai (2015/07/27 23:34), Michal Hocko wrote: On Mon 27-07-15 10:58:50, Hidehiro Kawai wrote: [...] The check could be also relaxed a bit and nmi_panic would return only if the