Hello there Thomas,
>> I can't think of a situation where, if an array index needs checking, then
>> it should be checked *after* use.
>
> It does not check the array index. Read the complete code:
>
> for (k = 0; k < INTC_IRQPIN_REG_NR; k++) {
> io[k] =
On Mon, 8 Jun 2015, David Binderman wrote:
>
> >> [linux-4.1-rc7/drivers/irqchip/irq-renesas-intc-irqpin.c:418]: (style)
> >> Array ind
> >> ex 'k' is used before limits check.
> >>
> >>if (!io[k] && k < INTC_IRQPIN_REG_NR_MANDATORY) {
> >>
> >>
Hello there Thomas,
>> [linux-4.1-rc7/drivers/irqchip/irq-renesas-intc-irqpin.c:418]: (style) Array
>> ind
>> ex 'k' is used before limits check.
>>
>>if (!io[k] && k < INTC_IRQPIN_REG_NR_MANDATORY) {
>>
>> Suggest sanity check array index before use.
On Mon, 8 Jun 2015, David Binderman wrote:
> Hello there,
>
> [linux-4.1-rc7/drivers/irqchip/irq-renesas-intc-irqpin.c:418]: (style) Array
> ind
> ex 'k' is used before limits check.
>
> if (!io[k] && k < INTC_IRQPIN_REG_NR_MANDATORY) {
>
> Suggest sanity check array index before use.
Hello there Thomas,
[linux-4.1-rc7/drivers/irqchip/irq-renesas-intc-irqpin.c:418]: (style) Array
ind
ex 'k' is used before limits check.
if (!io[k] k INTC_IRQPIN_REG_NR_MANDATORY) {
Suggest sanity check array index before use.
Which version
On Mon, 8 Jun 2015, David Binderman wrote:
Hello there,
[linux-4.1-rc7/drivers/irqchip/irq-renesas-intc-irqpin.c:418]: (style) Array
ind
ex 'k' is used before limits check.
if (!io[k] k INTC_IRQPIN_REG_NR_MANDATORY) {
Suggest sanity check array index before use.
Which version
On Mon, 8 Jun 2015, David Binderman wrote:
[linux-4.1-rc7/drivers/irqchip/irq-renesas-intc-irqpin.c:418]: (style)
Array ind
ex 'k' is used before limits check.
if (!io[k] k INTC_IRQPIN_REG_NR_MANDATORY) {
Suggest sanity check array
Hello there Thomas,
I can't think of a situation where, if an array index needs checking, then
it should be checked *after* use.
It does not check the array index. Read the complete code:
for (k = 0; k INTC_IRQPIN_REG_NR; k++) {
io[k] =
8 matches
Mail list logo