Re: [2.6 patch] drivers/serial/8250_acpi.c: fix a warning

2005-04-16 Thread Russell King
On Sat, Apr 16, 2005 at 04:38:52AM +0200, Adrian Bunk wrote: > In the Linux kernel, it's more common to put such header dependencies > for header files into the C files, but if the ACPI people agree a patch > to add the #include to acpi_bus.h is the other possble > correct solution for this

Re: [2.6 patch] drivers/serial/8250_acpi.c: fix a warning

2005-04-16 Thread Russell King
On Sat, Apr 16, 2005 at 04:38:52AM +0200, Adrian Bunk wrote: In the Linux kernel, it's more common to put such header dependencies for header files into the C files, but if the ACPI people agree a patch to add the #include linux/config.h to acpi_bus.h is the other possble correct solution

Re: [2.6 patch] drivers/serial/8250_acpi.c: fix a warning

2005-04-15 Thread Herbert Xu
Adrian Bunk <[EMAIL PROTECTED]> wrote: > >> drivers/serial/8250_acpi.c doesn't use CONFIG_ symbols. > > 8250_acpi.c #include's which requires config.h . > > In the Linux kernel, it's more common to put such header dependencies > for header files into the C files, but if the ACPI people agree a

Re: [2.6 patch] drivers/serial/8250_acpi.c: fix a warning

2005-04-15 Thread Adrian Bunk
On Fri, Apr 15, 2005 at 08:10:54PM +0400, Alexey Dobriyan wrote: > On Fri, 15 Apr 2005 17:10:53 +0200, Adrian Bunk wrote: > > > This patch fixes the following warning: > > > CC drivers/serial/8250_acpi.o > > drivers/serial/8250_acpi.c: In function `acpi_serial_ext_irq': > >

Re: [2.6 patch] drivers/serial/8250_acpi.c: fix a warning

2005-04-15 Thread Alexey Dobriyan
On Fri, 15 Apr 2005 17:10:53 +0200, Adrian Bunk wrote: > This patch fixes the following warning: > CC drivers/serial/8250_acpi.o > drivers/serial/8250_acpi.c: In function `acpi_serial_ext_irq': > drivers/serial/8250_acpi.c:51: warning: implicit declaration of function >

Re: [2.6 patch] drivers/serial/8250_acpi.c: fix a warning

2005-04-15 Thread Alexey Dobriyan
On Fri, 15 Apr 2005 17:10:53 +0200, Adrian Bunk wrote: This patch fixes the following warning: CC drivers/serial/8250_acpi.o drivers/serial/8250_acpi.c: In function `acpi_serial_ext_irq': drivers/serial/8250_acpi.c:51: warning: implicit declaration of function `acpi_register_gsi'

Re: [2.6 patch] drivers/serial/8250_acpi.c: fix a warning

2005-04-15 Thread Adrian Bunk
On Fri, Apr 15, 2005 at 08:10:54PM +0400, Alexey Dobriyan wrote: On Fri, 15 Apr 2005 17:10:53 +0200, Adrian Bunk wrote: This patch fixes the following warning: CC drivers/serial/8250_acpi.o drivers/serial/8250_acpi.c: In function `acpi_serial_ext_irq':

Re: [2.6 patch] drivers/serial/8250_acpi.c: fix a warning

2005-04-15 Thread Herbert Xu
Adrian Bunk [EMAIL PROTECTED] wrote: drivers/serial/8250_acpi.c doesn't use CONFIG_ symbols. 8250_acpi.c #include's acpi/acpi_bus.h which requires config.h . In the Linux kernel, it's more common to put such header dependencies for header files into the C files, but if the ACPI people