Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth via sysctl

On 4/27/16 10:09 AM, Frederic Weisbecker wrote: I first thought that this should be a tunable per event instead of a global sysctl Yeah, I'll work on that too. There is no rush though. The sysfs limit will probably be enough for most users. Unless someone requested it? I have. I spent

Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth via sysctl

On 4/27/16 10:09 AM, Frederic Weisbecker wrote: I first thought that this should be a tunable per event instead of a global sysctl Yeah, I'll work on that too. There is no rush though. The sysfs limit will probably be enough for most users. Unless someone requested it? I have. I spent

Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth via sysctl

On Wed, Apr 27, 2016 at 09:53:58AM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Apr 26, 2016 at 11:58:10PM +0200, Frederic Weisbecker escreveu: > > On Mon, Apr 25, 2016 at 09:29:28PM -0300, Arnaldo Carvalho de Melo wrote: > > > commit cd544af4f7fede01cb512d52bb3efe62aa19271d > > > Author:

Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth via sysctl

On Wed, Apr 27, 2016 at 09:53:58AM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Apr 26, 2016 at 11:58:10PM +0200, Frederic Weisbecker escreveu: > > On Mon, Apr 25, 2016 at 09:29:28PM -0300, Arnaldo Carvalho de Melo wrote: > > > commit cd544af4f7fede01cb512d52bb3efe62aa19271d > > > Author:

Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth via sysctl

Em Tue, Apr 26, 2016 at 10:45:28AM -0600, David Ahern escreveu: > On 4/26/16 10:33 AM, Arnaldo Carvalho de Melo wrote: > >So, for completeness, further testing it to see how far it goes on a 8GB > >machine I got: > > > >[root@emilia ~]# echo 131100 > /proc/sys/kernel/perf_event_max_stack >

Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth via sysctl

Em Tue, Apr 26, 2016 at 10:45:28AM -0600, David Ahern escreveu: > On 4/26/16 10:33 AM, Arnaldo Carvalho de Melo wrote: > >So, for completeness, further testing it to see how far it goes on a 8GB > >machine I got: > > > >[root@emilia ~]# echo 131100 > /proc/sys/kernel/perf_event_max_stack >

Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth via sysctl

Em Tue, Apr 26, 2016 at 02:58:41PM -0700, Brendan Gregg escreveu: > On Tue, Apr 26, 2016 at 2:05 PM, Arnaldo Carvalho de Melo > wrote: > > Em Tue, Apr 26, 2016 at 01:02:34PM -0700, Brendan Gregg escreveu: > >> On Mon, Apr 25, 2016 at 5:49 PM, Brendan Gregg

Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth via sysctl

Em Tue, Apr 26, 2016 at 02:58:41PM -0700, Brendan Gregg escreveu: > On Tue, Apr 26, 2016 at 2:05 PM, Arnaldo Carvalho de Melo > wrote: > > Em Tue, Apr 26, 2016 at 01:02:34PM -0700, Brendan Gregg escreveu: > >> On Mon, Apr 25, 2016 at 5:49 PM, Brendan Gregg > >> wrote: > >> > On Mon, Apr 25,

Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth via sysctl

Em Tue, Apr 26, 2016 at 11:58:10PM +0200, Frederic Weisbecker escreveu: > On Mon, Apr 25, 2016 at 09:29:28PM -0300, Arnaldo Carvalho de Melo wrote: > > commit cd544af4f7fede01cb512d52bb3efe62aa19271d > > Author: Arnaldo Carvalho de Melo > > Date: Thu Apr 21 12:28:50 2016 -0300

Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth via sysctl

Em Tue, Apr 26, 2016 at 11:58:10PM +0200, Frederic Weisbecker escreveu: > On Mon, Apr 25, 2016 at 09:29:28PM -0300, Arnaldo Carvalho de Melo wrote: > > commit cd544af4f7fede01cb512d52bb3efe62aa19271d > > Author: Arnaldo Carvalho de Melo > > Date: Thu Apr 21 12:28:50 2016 -0300 > > > > perf

Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth via sysctl

Em Tue, Apr 26, 2016 at 11:55:36PM +0200, Peter Zijlstra escreveu: > On Tue, Apr 26, 2016 at 06:05:00PM -0300, Arnaldo Carvalho de Melo wrote: > > > I started with max depth = 512, and even that was still truncated, and > > > had to profile again at 1024 to capture the full stacks. Seems to >

Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth via sysctl

Em Tue, Apr 26, 2016 at 11:55:36PM +0200, Peter Zijlstra escreveu: > On Tue, Apr 26, 2016 at 06:05:00PM -0300, Arnaldo Carvalho de Melo wrote: > > > I started with max depth = 512, and even that was still truncated, and > > > had to profile again at 1024 to capture the full stacks. Seems to >

Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth via sysctl

On Tue, Apr 26, 2016 at 02:58:41PM -0700, Brendan Gregg wrote: > BTS seemed more promising (deeper stacks), and there's already Xen > support for it (need to boot the Xen host with vpmu=bts, preferably > vpmu=bts,arch for some PMCs as well :). BTS is a branch tracer; it simply traces _all_

Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth via sysctl

On Tue, Apr 26, 2016 at 02:58:41PM -0700, Brendan Gregg wrote: > BTS seemed more promising (deeper stacks), and there's already Xen > support for it (need to boot the Xen host with vpmu=bts, preferably > vpmu=bts,arch for some PMCs as well :). BTS is a branch tracer; it simply traces _all_

Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth via sysctl

On Tue, Apr 26, 2016 at 2:05 PM, Arnaldo Carvalho de Melo wrote: > Em Tue, Apr 26, 2016 at 01:02:34PM -0700, Brendan Gregg escreveu: >> On Mon, Apr 25, 2016 at 5:49 PM, Brendan Gregg >> wrote: >> > On Mon, Apr 25, 2016 at 5:47 PM, Arnaldo

Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth via sysctl

On Tue, Apr 26, 2016 at 2:05 PM, Arnaldo Carvalho de Melo wrote: > Em Tue, Apr 26, 2016 at 01:02:34PM -0700, Brendan Gregg escreveu: >> On Mon, Apr 25, 2016 at 5:49 PM, Brendan Gregg >> wrote: >> > On Mon, Apr 25, 2016 at 5:47 PM, Arnaldo Carvalho de Melo >> > wrote: >> >> Em Mon, Apr 25,

Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth via sysctl

On Mon, Apr 25, 2016 at 09:29:28PM -0300, Arnaldo Carvalho de Melo wrote: > commit cd544af4f7fede01cb512d52bb3efe62aa19271d > Author: Arnaldo Carvalho de Melo > Date: Thu Apr 21 12:28:50 2016 -0300 > > perf core: Allow setting up max frame stack depth via sysctl > >

Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth via sysctl

On Mon, Apr 25, 2016 at 09:29:28PM -0300, Arnaldo Carvalho de Melo wrote: > commit cd544af4f7fede01cb512d52bb3efe62aa19271d > Author: Arnaldo Carvalho de Melo > Date: Thu Apr 21 12:28:50 2016 -0300 > > perf core: Allow setting up max frame stack depth via sysctl > > The default

Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth via sysctl

On Tue, Apr 26, 2016 at 06:05:00PM -0300, Arnaldo Carvalho de Melo wrote: > > I started with max depth = 512, and even that was still truncated, and > > had to profile again at 1024 to capture the full stacks. Seems to ^^ > > generally match the flame graph I

Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth via sysctl

On Tue, Apr 26, 2016 at 06:05:00PM -0300, Arnaldo Carvalho de Melo wrote: > > I started with max depth = 512, and even that was still truncated, and > > had to profile again at 1024 to capture the full stacks. Seems to ^^ > > generally match the flame graph I

Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth via sysctl

Em Tue, Apr 26, 2016 at 01:02:34PM -0700, Brendan Gregg escreveu: > On Mon, Apr 25, 2016 at 5:49 PM, Brendan Gregg > wrote: > > On Mon, Apr 25, 2016 at 5:47 PM, Arnaldo Carvalho de Melo > > wrote: > >> Em Mon, Apr 25, 2016 at 05:44:00PM -0700,

Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth via sysctl

Em Tue, Apr 26, 2016 at 01:02:34PM -0700, Brendan Gregg escreveu: > On Mon, Apr 25, 2016 at 5:49 PM, Brendan Gregg > wrote: > > On Mon, Apr 25, 2016 at 5:47 PM, Arnaldo Carvalho de Melo > > wrote: > >> Em Mon, Apr 25, 2016 at 05:44:00PM -0700, Alexei Starovoitov escreveu: > >>> yep :) > >>>

Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth via sysctl

On Mon, Apr 25, 2016 at 5:49 PM, Brendan Gregg wrote: > On Mon, Apr 25, 2016 at 5:47 PM, Arnaldo Carvalho de Melo > wrote: >> Em Mon, Apr 25, 2016 at 05:44:00PM -0700, Alexei Starovoitov escreveu: >>> On Mon, Apr 25, 2016 at 09:29:28PM -0300,

Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth via sysctl

On Mon, Apr 25, 2016 at 5:49 PM, Brendan Gregg wrote: > On Mon, Apr 25, 2016 at 5:47 PM, Arnaldo Carvalho de Melo > wrote: >> Em Mon, Apr 25, 2016 at 05:44:00PM -0700, Alexei Starovoitov escreveu: >>> On Mon, Apr 25, 2016 at 09:29:28PM -0300, Arnaldo Carvalho de Melo wrote: >>> > Em Mon, Apr 25,

Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth via sysctl

On 4/26/16 10:33 AM, Arnaldo Carvalho de Melo wrote: So, for completeness, further testing it to see how far it goes on a 8GB machine I got: [root@emilia ~]# echo 131100 > /proc/sys/kernel/perf_event_max_stack [root@emilia ~]# perf record -g ls Error: The sys_perf_event_open() syscall returned

Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth via sysctl

On 4/26/16 10:33 AM, Arnaldo Carvalho de Melo wrote: So, for completeness, further testing it to see how far it goes on a 8GB machine I got: [root@emilia ~]# echo 131100 > /proc/sys/kernel/perf_event_max_stack [root@emilia ~]# perf record -g ls Error: The sys_perf_event_open() syscall returned

Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth via sysctl

Em Mon, Apr 25, 2016 at 05:49:38PM -0700, Brendan Gregg escreveu: > On Mon, Apr 25, 2016 at 5:47 PM, Arnaldo Carvalho de Melo > wrote: > > Em Mon, Apr 25, 2016 at 05:44:00PM -0700, Alexei Starovoitov escreveu: > >> On Mon, Apr 25, 2016 at 09:29:28PM -0300, Arnaldo Carvalho

Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth via sysctl

Em Mon, Apr 25, 2016 at 05:49:38PM -0700, Brendan Gregg escreveu: > On Mon, Apr 25, 2016 at 5:47 PM, Arnaldo Carvalho de Melo > wrote: > > Em Mon, Apr 25, 2016 at 05:44:00PM -0700, Alexei Starovoitov escreveu: > >> On Mon, Apr 25, 2016 at 09:29:28PM -0300, Arnaldo Carvalho de Melo wrote: > >> >

Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth via sysctl

On Mon, Apr 25, 2016 at 5:47 PM, Arnaldo Carvalho de Melo wrote: > Em Mon, Apr 25, 2016 at 05:44:00PM -0700, Alexei Starovoitov escreveu: >> On Mon, Apr 25, 2016 at 09:29:28PM -0300, Arnaldo Carvalho de Melo wrote: >> > Em Mon, Apr 25, 2016 at 05:07:26PM -0700, Alexei

Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth via sysctl

On Mon, Apr 25, 2016 at 5:47 PM, Arnaldo Carvalho de Melo wrote: > Em Mon, Apr 25, 2016 at 05:44:00PM -0700, Alexei Starovoitov escreveu: >> On Mon, Apr 25, 2016 at 09:29:28PM -0300, Arnaldo Carvalho de Melo wrote: >> > Em Mon, Apr 25, 2016 at 05:07:26PM -0700, Alexei Starovoitov escreveu: >> > >

Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth via sysctl

Em Mon, Apr 25, 2016 at 05:44:00PM -0700, Alexei Starovoitov escreveu: > On Mon, Apr 25, 2016 at 09:29:28PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Mon, Apr 25, 2016 at 05:07:26PM -0700, Alexei Starovoitov escreveu: > > > > + { > > > > + .procname =

Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth via sysctl

Em Mon, Apr 25, 2016 at 05:44:00PM -0700, Alexei Starovoitov escreveu: > On Mon, Apr 25, 2016 at 09:29:28PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Mon, Apr 25, 2016 at 05:07:26PM -0700, Alexei Starovoitov escreveu: > > > > + { > > > > + .procname =

Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth via sysctl

On Mon, Apr 25, 2016 at 09:29:28PM -0300, Arnaldo Carvalho de Melo wrote: > Em Mon, Apr 25, 2016 at 05:07:26PM -0700, Alexei Starovoitov escreveu: > > > + { > > > + .procname = "perf_event_max_stack", > > > + .data = NULL, /* filled in by handler */ > > > +

Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth via sysctl

On Mon, Apr 25, 2016 at 09:29:28PM -0300, Arnaldo Carvalho de Melo wrote: > Em Mon, Apr 25, 2016 at 05:07:26PM -0700, Alexei Starovoitov escreveu: > > > + { > > > + .procname = "perf_event_max_stack", > > > + .data = NULL, /* filled in by handler */ > > > +