Re: [PATCH][FAT] FAT dirent scan with hin take #2

2005-08-30 Thread OGAWA Hirofumi
OGAWA Hirofumi <[EMAIL PROTECTED]> writes: > This patch couldn't compile. I assume you post a wrong patch...? ^ version -- OGAWA Hirofumi <[EMAIL PROTECTED]> - To unsubscribe

Re: [PATCH][FAT] FAT dirent scan with hin take #2

2005-08-30 Thread OGAWA Hirofumi
"Machida, Hiroyuki" <[EMAIL PROTECTED]> writes: > Here is a revised version of dirent scan patch, mentioned at > following E-mail. > > This patch addresses performance damages on "ls | xargs xxx" and > reverse order scan which are reported to the previous patch. > > With this patch,

Re: [PATCH][FAT] FAT dirent scan with hin take #2

2005-08-30 Thread Vojtech Pavlik
On Tue, Aug 30, 2005 at 11:55:46AM +0300, Pekka Enberg wrote: > Hi, > > Some more. > > On 8/30/05, Machida, Hiroyuki <[EMAIL PROTECTED]> wrote: > > --- old/fs/fat/inode.c 2005-08-29 09:38:53.308587787 +0900 > > +++ new/fs/fat/inode.c 2005-08-29 09:39:33.889555606 +0900 > > @@ -345,6 +347,15 @@

Re: [PATCH][FAT] FAT dirent scan with hin take #2

2005-08-30 Thread Pekka Enberg
Hi, Some more. On 8/30/05, Machida, Hiroyuki <[EMAIL PROTECTED]> wrote: > --- old/fs/fat/inode.c 2005-08-29 09:38:53.308587787 +0900 > +++ new/fs/fat/inode.c 2005-08-29 09:39:33.889555606 +0900 > @@ -345,6 +347,15 @@ static void fat_delete_inode(struct inod > static void

Re: [PATCH][FAT] FAT dirent scan with hin take #2

2005-08-30 Thread Pekka Enberg
Hi, Some coding style nitpicks. On 8/30/05, Machida, Hiroyuki <[EMAIL PROTECTED]> wrote: > +inline > +static int hint_allocate(struct inode *dir) > +{ > + void *hints; > + int err = 0; > + > + if (!MSDOS_I(dir)->scan_hints) { > + hints =

Re: [PATCH][FAT] FAT dirent scan with hin take #2

2005-08-30 Thread Pekka Enberg
Hi, Some coding style nitpicks. On 8/30/05, Machida, Hiroyuki [EMAIL PROTECTED] wrote: +inline +static int hint_allocate(struct inode *dir) +{ + void *hints; + int err = 0; + + if (!MSDOS_I(dir)-scan_hints) { + hints =

Re: [PATCH][FAT] FAT dirent scan with hin take #2

2005-08-30 Thread Pekka Enberg
Hi, Some more. On 8/30/05, Machida, Hiroyuki [EMAIL PROTECTED] wrote: --- old/fs/fat/inode.c 2005-08-29 09:38:53.308587787 +0900 +++ new/fs/fat/inode.c 2005-08-29 09:39:33.889555606 +0900 @@ -345,6 +347,15 @@ static void fat_delete_inode(struct inod static void fat_clear_inode(struct

Re: [PATCH][FAT] FAT dirent scan with hin take #2

2005-08-30 Thread Vojtech Pavlik
On Tue, Aug 30, 2005 at 11:55:46AM +0300, Pekka Enberg wrote: Hi, Some more. On 8/30/05, Machida, Hiroyuki [EMAIL PROTECTED] wrote: --- old/fs/fat/inode.c 2005-08-29 09:38:53.308587787 +0900 +++ new/fs/fat/inode.c 2005-08-29 09:39:33.889555606 +0900 @@ -345,6 +347,15 @@ static void

Re: [PATCH][FAT] FAT dirent scan with hin take #2

2005-08-30 Thread OGAWA Hirofumi
Machida, Hiroyuki [EMAIL PROTECTED] writes: Here is a revised version of dirent scan patch, mentioned at following E-mail. This patch addresses performance damages on ls | xargs xxx and reverse order scan which are reported to the previous patch. With this patch, fat_search_long() and

Re: [PATCH][FAT] FAT dirent scan with hin take #2

2005-08-30 Thread OGAWA Hirofumi
OGAWA Hirofumi [EMAIL PROTECTED] writes: This patch couldn't compile. I assume you post a wrong patch...? ^ version -- OGAWA Hirofumi [EMAIL PROTECTED] - To unsubscribe from