Re: [PATCH][V2] net: stmmac: ensure jumbo_frm error return is correctly checked for -ve value

2017-06-06 Thread David Miller
From: Colin King Date: Mon, 5 Jun 2017 10:04:52 +0100 > From: Colin Ian King > > The current comparison of entry < 0 will never be true since entry is an > unsigned integer. Make entry an int to ensure -ve error return values > from the call

Re: [PATCH][V2] net: stmmac: ensure jumbo_frm error return is correctly checked for -ve value

2017-06-06 Thread David Miller
From: Colin King Date: Mon, 5 Jun 2017 10:04:52 +0100 > From: Colin Ian King > > The current comparison of entry < 0 will never be true since entry is an > unsigned integer. Make entry an int to ensure -ve error return values > from the call to jumbo_frm are correctly being caught. > >

Re: [PATCH][V2] net: stmmac: ensure jumbo_frm error return is correctly checked for -ve value

2017-06-05 Thread Julia Lawall
On Mon, 5 Jun 2017, Colin King wrote: > From: Colin Ian King > > The current comparison of entry < 0 will never be true since entry is an > unsigned integer. Make entry an int to ensure -ve error return values > from the call to jumbo_frm are correctly being caught.

Re: [PATCH][V2] net: stmmac: ensure jumbo_frm error return is correctly checked for -ve value

2017-06-05 Thread Julia Lawall
On Mon, 5 Jun 2017, Colin King wrote: > From: Colin Ian King > > The current comparison of entry < 0 will never be true since entry is an > unsigned integer. Make entry an int to ensure -ve error return values > from the call to jumbo_frm are correctly being caught. Perhaps it would be good