Re: [PATCH] [RFC] drivers/staging/fbtft: fix sparse warnings

2015-02-23 Thread Andrey Utkin
2015-02-23 21:27 GMT+02:00 Noralf Trønnes : > Yes, it's best to leave this alone for now. > I'm working on a proposal to provide better layering and minimal coupling > to fbdev. This will hopefully lead to screen_base eventually being used > only twice in the fbtft module and nowhere else. Ok,

Re: [PATCH] [RFC] drivers/staging/fbtft: fix sparse warnings

2015-02-23 Thread Noralf Trønnes
diff --git a/drivers/staging/fbtft/fb_agm1264k-fl.c b/drivers/staging/fbtft/fb_agm1264k-fl.c index 9cc7d25..9114239 100644 --- a/drivers/staging/fbtft/fb_agm1264k-fl.c +++ b/drivers/staging/fbtft/fb_agm1264k-fl.c @@ -273,7 +273,7 @@ construct_line_bitmap(struct fbtft_par *par, u8 *dest,

Re: [PATCH] [RFC] drivers/staging/fbtft: fix sparse warnings

2015-02-23 Thread Dan Carpenter
On Mon, Feb 23, 2015 at 07:06:44PM +0200, Andrey Utkin wrote: > 2015-02-21 20:58 GMT+02:00 Dan Carpenter : > > Send two separate patches. You can't "fix" sparse warnings. You can > > only "fix" bugs. The rest is add annotation, doing cleanups or possibly > > silencing warnings. > > My first

Re: [PATCH] [RFC] drivers/staging/fbtft: fix sparse warnings

2015-02-23 Thread Andrey Utkin
2015-02-21 20:58 GMT+02:00 Dan Carpenter : > Send two separate patches. You can't "fix" sparse warnings. You can > only "fix" bugs. The rest is add annotation, doing cleanups or possibly > silencing warnings. My first email wasn't a patch supposed for accepting, but rather a request for

Re: [PATCH] [RFC] drivers/staging/fbtft: fix sparse warnings

2015-02-23 Thread Andrey Utkin
2015-02-21 20:58 GMT+02:00 Dan Carpenter dan.carpen...@oracle.com: Send two separate patches. You can't fix sparse warnings. You can only fix bugs. The rest is add annotation, doing cleanups or possibly silencing warnings. My first email wasn't a patch supposed for accepting, but rather a

Re: [PATCH] [RFC] drivers/staging/fbtft: fix sparse warnings

2015-02-23 Thread Noralf Trønnes
diff --git a/drivers/staging/fbtft/fb_agm1264k-fl.c b/drivers/staging/fbtft/fb_agm1264k-fl.c index 9cc7d25..9114239 100644 --- a/drivers/staging/fbtft/fb_agm1264k-fl.c +++ b/drivers/staging/fbtft/fb_agm1264k-fl.c @@ -273,7 +273,7 @@ construct_line_bitmap(struct fbtft_par *par, u8 *dest,

Re: [PATCH] [RFC] drivers/staging/fbtft: fix sparse warnings

2015-02-23 Thread Dan Carpenter
On Mon, Feb 23, 2015 at 07:06:44PM +0200, Andrey Utkin wrote: 2015-02-21 20:58 GMT+02:00 Dan Carpenter dan.carpen...@oracle.com: Send two separate patches. You can't fix sparse warnings. You can only fix bugs. The rest is add annotation, doing cleanups or possibly silencing warnings.

Re: [PATCH] [RFC] drivers/staging/fbtft: fix sparse warnings

2015-02-23 Thread Andrey Utkin
2015-02-23 21:27 GMT+02:00 Noralf Trønnes nor...@tronnes.org: Yes, it's best to leave this alone for now. I'm working on a proposal to provide better layering and minimal coupling to fbdev. This will hopefully lead to screen_base eventually being used only twice in the fbtft module and nowhere

Re: [PATCH] [RFC] drivers/staging/fbtft: fix sparse warnings

2015-02-21 Thread Dan Carpenter
On Fri, Feb 20, 2015 at 11:34:09PM +0200, Andrey Utkin wrote: > See below how sparse output changed with these changes. > In few words: > - fixed printf specifiers for size_t; > - trying to fix address space specifiers issues, not sure what's correct > approach, ASKING FOR COMMENTS AND HELP;

Re: [PATCH] [RFC] drivers/staging/fbtft: fix sparse warnings

2015-02-21 Thread Dan Carpenter
On Fri, Feb 20, 2015 at 11:34:09PM +0200, Andrey Utkin wrote: See below how sparse output changed with these changes. In few words: - fixed printf specifiers for size_t; - trying to fix address space specifiers issues, not sure what's correct approach, ASKING FOR COMMENTS AND HELP; Send two