Re: [PATCH] [RFC] netfilter: nf_conntrack: don't relase a conntrack with non-zero refcnt

2014-02-03 Thread Eric Dumazet
On Mon, 2014-02-03 at 00:30 +0100, Pablo Neira Ayuso wrote: > */ > smp_wmb(); > - atomic_set(>ct_general.use, 1); > + atomic_set(>ct_general.use, 0); > return ct; Hi Pablo ! I think your patch is the way to go, but might need some extra care with memory

Re: [PATCH] [RFC] netfilter: nf_conntrack: don't relase a conntrack with non-zero refcnt

2014-02-03 Thread Andrew Vagin
On Mon, Feb 03, 2014 at 12:30:46AM +0100, Pablo Neira Ayuso wrote: > On Thu, Jan 16, 2014 at 10:23:01AM +0100, Florian Westphal wrote: > > Andrew Vagin wrote: > > > > I think it would be nice if we could keep it that way. > > > > If everything fails we could proably intoduce a 'larval' dummy list

Re: [PATCH] [RFC] netfilter: nf_conntrack: don't relase a conntrack with non-zero refcnt

2014-02-03 Thread Andrew Vagin
On Mon, Feb 03, 2014 at 12:30:46AM +0100, Pablo Neira Ayuso wrote: On Thu, Jan 16, 2014 at 10:23:01AM +0100, Florian Westphal wrote: Andrew Vagin ava...@parallels.com wrote: I think it would be nice if we could keep it that way. If everything fails we could proably intoduce a 'larval'

Re: [PATCH] [RFC] netfilter: nf_conntrack: don't relase a conntrack with non-zero refcnt

2014-02-03 Thread Eric Dumazet
On Mon, 2014-02-03 at 00:30 +0100, Pablo Neira Ayuso wrote: */ smp_wmb(); - atomic_set(ct-ct_general.use, 1); + atomic_set(ct-ct_general.use, 0); return ct; Hi Pablo ! I think your patch is the way to go, but might need some extra care with memory

Re: [PATCH] [RFC] netfilter: nf_conntrack: don't relase a conntrack with non-zero refcnt

2014-02-02 Thread Pablo Neira Ayuso
On Thu, Jan 16, 2014 at 10:23:01AM +0100, Florian Westphal wrote: > Andrew Vagin wrote: > > > I think it would be nice if we could keep it that way. > > > If everything fails we could proably intoduce a 'larval' dummy list > > > similar to the one used by template conntracks? > > > > I'm not

Re: [PATCH] [RFC] netfilter: nf_conntrack: don't relase a conntrack with non-zero refcnt

2014-02-02 Thread Pablo Neira Ayuso
On Thu, Jan 16, 2014 at 10:23:01AM +0100, Florian Westphal wrote: Andrew Vagin ava...@parallels.com wrote: I think it would be nice if we could keep it that way. If everything fails we could proably intoduce a 'larval' dummy list similar to the one used by template conntracks? I'm

Re: [PATCH] [RFC] netfilter: nf_conntrack: don't relase a conntrack with non-zero refcnt

2014-01-27 Thread Andrew Vagin
On Tue, Jan 14, 2014 at 09:35:48PM +0400, Andrey Vagin wrote: > > Eric and Florian, could you look at this patch. When you say, > that it looks good, I will ask the user to validate it. > I can't reorder these actions, because it's reproduced on a real host > with real users. Thanks. We

Re: [PATCH] [RFC] netfilter: nf_conntrack: don't relase a conntrack with non-zero refcnt

2014-01-27 Thread Andrew Vagin
On Tue, Jan 14, 2014 at 09:35:48PM +0400, Andrey Vagin wrote: Eric and Florian, could you look at this patch. When you say, that it looks good, I will ask the user to validate it. I can't reorder these actions, because it's reproduced on a real host with real users. Thanks. We didn't

Re: [PATCH] [RFC] netfilter: nf_conntrack: don't relase a conntrack with non-zero refcnt

2014-01-16 Thread Florian Westphal
Andrew Vagin wrote: > > I think it would be nice if we could keep it that way. > > If everything fails we could proably intoduce a 'larval' dummy list > > similar to the one used by template conntracks? > > I'm not sure, that this is required. Could you elaborate when this can > be useful? You

Re: [PATCH] [RFC] netfilter: nf_conntrack: don't relase a conntrack with non-zero refcnt

2014-01-16 Thread Florian Westphal
Andrew Vagin ava...@parallels.com wrote: I think it would be nice if we could keep it that way. If everything fails we could proably intoduce a 'larval' dummy list similar to the one used by template conntracks? I'm not sure, that this is required. Could you elaborate when this can be

Re: [PATCH] [RFC] netfilter: nf_conntrack: don't relase a conntrack with non-zero refcnt

2014-01-15 Thread Andrew Vagin
On Tue, Jan 14, 2014 at 07:53:29PM +0100, Florian Westphal wrote: > Andrey Vagin wrote: > > > > Eric and Florian, could you look at this patch. When you say, > > that it looks good, I will ask the user to validate it. > > I can't reorder these actions, because it's reproduced on a real host

Re: [PATCH] [RFC] netfilter: nf_conntrack: don't relase a conntrack with non-zero refcnt

2014-01-15 Thread Andrew Vagin
On Tue, Jan 14, 2014 at 07:53:29PM +0100, Florian Westphal wrote: Andrey Vagin ava...@openvz.org wrote: Eric and Florian, could you look at this patch. When you say, that it looks good, I will ask the user to validate it. I can't reorder these actions, because it's reproduced on a

Re: [PATCH] [RFC] netfilter: nf_conntrack: don't relase a conntrack with non-zero refcnt

2014-01-14 Thread Florian Westphal
Andrey Vagin wrote: > > Eric and Florian, could you look at this patch. When you say, > that it looks good, I will ask the user to validate it. > I can't reorder these actions, because it's reproduced on a real host > with real users. Thanks. > > > nf_conntrack_free can't be called for

Re: [PATCH] [RFC] netfilter: nf_conntrack: don't relase a conntrack with non-zero refcnt

2014-01-14 Thread Cyrill Gorcunov
On Tue, Jan 14, 2014 at 09:35:48PM +0400, Andrey Vagin wrote: > > Eric and Florian, could you look at this patch. When you say, > that it looks good, I will ask the user to validate it. > I can't reorder these actions, because it's reproduced on a real host > with real users. Thanks. > >

Re: [PATCH] [RFC] netfilter: nf_conntrack: don't relase a conntrack with non-zero refcnt

2014-01-14 Thread Cyrill Gorcunov
On Tue, Jan 14, 2014 at 09:35:48PM +0400, Andrey Vagin wrote: Eric and Florian, could you look at this patch. When you say, that it looks good, I will ask the user to validate it. I can't reorder these actions, because it's reproduced on a real host with real users. Thanks.

Re: [PATCH] [RFC] netfilter: nf_conntrack: don't relase a conntrack with non-zero refcnt

2014-01-14 Thread Florian Westphal
Andrey Vagin ava...@openvz.org wrote: Eric and Florian, could you look at this patch. When you say, that it looks good, I will ask the user to validate it. I can't reorder these actions, because it's reproduced on a real host with real users. Thanks. nf_conntrack_free can't be