Re: [PATCH] infiniband-diags/saquery.c: switchinfo support added

2013-02-28 Thread Ira Weiny
Your mailer line wrapped the patch. Could you resend. Also, could you add this to doc/rst/saquery.8.in.rst Thanks, Ira On Thu, 28 Feb 2013 08:11:38 +0200 "Husam Kahalah" wrote: > From d61f2580b829fa2fc56aea15bd98ef3a607d9aba Mon Sep 17 00:00:00 2001 > > From: Husam kahalah > Date: Mon, 25

Re: [PATCH] infiniband-diags/saquery.c: switchinfo support added

2013-02-28 Thread Ira Weiny
Your mailer line wrapped the patch. Could you resend. Also, could you add this to doc/rst/saquery.8.in.rst Thanks, Ira On Thu, 28 Feb 2013 08:11:38 +0200 Husam Kahalah hkaha...@asaltech.com wrote: From d61f2580b829fa2fc56aea15bd98ef3a607d9aba Mon Sep 17 00:00:00 2001 From: Husam kahalah

Re: [PATCH] infiniband-diags/saquery.c: switchinfo support added

2013-02-24 Thread Ira Weiny
Ira > > -Original Message- > From: Ira Weiny > To: Ira Weiny > Cc: "Husam Kahalah" , linux-r...@vger.kernel.org, > linux-kernel@vger.kernel.org > Date: Thu, 21 Feb 2013 10:33:44 -0800 > Subject: Re: [PATCH] infiniband-diags/saquery.c: switchinfo support

Re: [PATCH] infiniband-diags/saquery.c: switchinfo support added

2013-02-24 Thread Ira Weiny
- From: Ira Weiny wei...@llnl.gov To: Ira Weiny wei...@llnl.gov Cc: Husam Kahalah hkaha...@asaltech.com, linux-r...@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 21 Feb 2013 10:33:44 -0800 Subject: Re: [PATCH] infiniband-diags/saquery.c: switchinfo support added On Thu, 21 Feb 2013 10

Re: [PATCH] infiniband-diags/saquery.c: switchinfo support added

2013-02-21 Thread Ira Weiny
On Thu, 21 Feb 2013 10:09:00 -0800 Ira Weiny wrote: [snip] > > + ib_net16_t swir_lid; > > We don't need this field or lid option. Other records simply have an > optional parameter to specify the lid. > > The usage should be: > > SwitchRecord [lid] > Sorry I meant "SwitchInfoRecord" or

Re: [PATCH] infiniband-diags/saquery.c: switchinfo support added

2013-02-21 Thread Ira Weiny
First Thanks! Some comments below. On Thu, 21 Feb 2013 11:49:46 +0200 "Husam Kahalah" wrote: > > From a77cadd4d81ac0e23db836d9382fd642d7e37897 Mon Sep 17 00:00:00 2001 > From: Husam kahalah < hkaha...@asaltech.com> > Date: Sun, 3 Feb 2013 14:27:21 +0200 > Subject: [PATCH]

Re: [PATCH] infiniband-diags/saquery.c: switchinfo support added

2013-02-21 Thread Ira Weiny
First Thanks! Some comments below. On Thu, 21 Feb 2013 11:49:46 +0200 Husam Kahalah hkaha...@asaltech.com wrote: From a77cadd4d81ac0e23db836d9382fd642d7e37897 Mon Sep 17 00:00:00 2001 From: Husam kahalah hkaha...@asaltech.com Date: Sun, 3 Feb 2013 14:27:21 +0200 Subject: [PATCH]

Re: [PATCH] infiniband-diags/saquery.c: switchinfo support added

2013-02-21 Thread Ira Weiny
On Thu, 21 Feb 2013 10:09:00 -0800 Ira Weiny wei...@llnl.gov wrote: [snip] + ib_net16_t swir_lid; We don't need this field or lid option. Other records simply have an optional parameter to specify the lid. The usage should be: SwitchRecord [lid] Sorry I meant SwitchInfoRecord or