Re: [PATCH] ARM: OMAP4: sleep: byteswap data for big-endian

2014-02-13 Thread Tony Lindgren
* Santosh Shilimkar [140114 15:46]: > On Tuesday 14 January 2014 04:13 PM, Nishanth Menon wrote: > > I haven't looked at patch myself but as you pointed out if it adds > dead code and makes the code un-readable then probably that something > we shouldn't merge. Yeah it seems the assembly parts

Re: [PATCH] ARM: OMAP4: sleep: byteswap data for big-endian

2014-02-13 Thread Tony Lindgren
* Santosh Shilimkar santosh.shilim...@ti.com [140114 15:46]: On Tuesday 14 January 2014 04:13 PM, Nishanth Menon wrote: I haven't looked at patch myself but as you pointed out if it adds dead code and makes the code un-readable then probably that something we shouldn't merge. Yeah it seems

Re: [PATCH] ARM: OMAP4: sleep: byteswap data for big-endian

2014-01-14 Thread Santosh Shilimkar
On Tuesday 14 January 2014 04:13 PM, Nishanth Menon wrote: > On Tue, Jan 14, 2014 at 3:03 PM, Santosh Shilimkar > wrote: >> >>> ok.. some sort of Linaro thing about which I have no background about >>> - but dont really care in this context. >>> >> Nothing related Linaro. Its just that platforms

Re: [PATCH] ARM: OMAP4: sleep: byteswap data for big-endian

2014-01-14 Thread Taras Kondratiuk
On 14 January 2014 23:13, Nishanth Menon wrote: > On Tue, Jan 14, 2014 at 3:03 PM, Santosh Shilimkar > wrote: >> >>> ok.. some sort of Linaro thing about which I have no background about >>> - but dont really care in this context. >>> >> Nothing related Linaro. Its just that platforms are

Re: [PATCH] ARM: OMAP4: sleep: byteswap data for big-endian

2014-01-14 Thread Nishanth Menon
On Tue, Jan 14, 2014 at 3:03 PM, Santosh Shilimkar wrote: > >> ok.. some sort of Linaro thing about which I have no background about >> - but dont really care in this context. >> > Nothing related Linaro. Its just that platforms are supporting ARM BE > mode and Linaro folks had working patches

Re: [PATCH] ARM: OMAP4: sleep: byteswap data for big-endian

2014-01-14 Thread Santosh Shilimkar
On Tuesday 14 January 2014 03:56 PM, Nishanth Menon wrote: > On Tue, Jan 14, 2014 at 2:20 PM, Victor Kamensky > wrote: >> On 14 January 2014 09:56, Nishanth Menon wrote: >>> On Tue, Jan 14, 2014 at 11:35 AM, Victor Kamensky >>> wrote: When BE kernel is built Makefile does take of

Re: [PATCH] ARM: OMAP4: sleep: byteswap data for big-endian

2014-01-14 Thread Nishanth Menon
On Tue, Jan 14, 2014 at 2:20 PM, Victor Kamensky wrote: > On 14 January 2014 09:56, Nishanth Menon wrote: >> On Tue, Jan 14, 2014 at 11:35 AM, Victor Kamensky >> wrote: >>> >>> When BE kernel is built Makefile does take of compiling code in BE >>> mode. I.e all proper flags like -mbig-endian

Re: [PATCH] ARM: OMAP4: sleep: byteswap data for big-endian

2014-01-14 Thread Victor Kamensky
On 14 January 2014 09:56, Nishanth Menon wrote: > On Tue, Jan 14, 2014 at 11:35 AM, Victor Kamensky > wrote: >> >> When BE kernel is built Makefile does take of compiling code in BE >> mode. I.e all proper flags like -mbig-endian and -Wl,--be8 will be set. > > Agreed, and I assume you cannot

Re: [PATCH] ARM: OMAP4: sleep: byteswap data for big-endian

2014-01-14 Thread Nishanth Menon
On Tue, Jan 14, 2014 at 11:35 AM, Victor Kamensky wrote: > > When BE kernel is built Makefile does take of compiling code in BE > mode. I.e all proper flags like -mbig-endian and -Wl,--be8 will be set. Agreed, and I assume you cannot instead switch to LE mode when entering assembly assuming LE?

Re: [PATCH] ARM: OMAP4: sleep: byteswap data for big-endian

2014-01-14 Thread Victor Kamensky
Hi Nishanth, On 14 January 2014 07:51, Nishanth Menon wrote: > On 01/14/2014 05:14 AM, Taras Kondratiuk wrote: >> On 13 January 2014 17:23, Nishanth Menon wrote: >>> On 01/13/2014 09:03 AM, Taras Kondratiuk wrote: From: Victor Kamensky Assembler functions defined in sleep44xx.S

Re: [PATCH] ARM: OMAP4: sleep: byteswap data for big-endian

2014-01-14 Thread Nishanth Menon
On 01/14/2014 05:14 AM, Taras Kondratiuk wrote: > On 13 January 2014 17:23, Nishanth Menon wrote: >> On 01/13/2014 09:03 AM, Taras Kondratiuk wrote: >>> From: Victor Kamensky >>> >>> Assembler functions defined in sleep44xx.S need to byteswap values >>> after read / before write from h/w

Re: [PATCH] ARM: OMAP4: sleep: byteswap data for big-endian

2014-01-14 Thread Taras Kondratiuk
On 13 January 2014 17:23, Nishanth Menon wrote: > On 01/13/2014 09:03 AM, Taras Kondratiuk wrote: >> From: Victor Kamensky >> >> Assembler functions defined in sleep44xx.S need to byteswap values >> after read / before write from h/w register if code compiled in big >> endian mode. Simple change

Re: [PATCH] ARM: OMAP4: sleep: byteswap data for big-endian

2014-01-14 Thread Taras Kondratiuk
On 13 January 2014 17:23, Nishanth Menon n...@ti.com wrote: On 01/13/2014 09:03 AM, Taras Kondratiuk wrote: From: Victor Kamensky victor.kamen...@linaro.org Assembler functions defined in sleep44xx.S need to byteswap values after read / before write from h/w register if code compiled in big

Re: [PATCH] ARM: OMAP4: sleep: byteswap data for big-endian

2014-01-14 Thread Nishanth Menon
On 01/14/2014 05:14 AM, Taras Kondratiuk wrote: On 13 January 2014 17:23, Nishanth Menon n...@ti.com wrote: On 01/13/2014 09:03 AM, Taras Kondratiuk wrote: From: Victor Kamensky victor.kamen...@linaro.org Assembler functions defined in sleep44xx.S need to byteswap values after read / before

Re: [PATCH] ARM: OMAP4: sleep: byteswap data for big-endian

2014-01-14 Thread Victor Kamensky
Hi Nishanth, On 14 January 2014 07:51, Nishanth Menon n...@ti.com wrote: On 01/14/2014 05:14 AM, Taras Kondratiuk wrote: On 13 January 2014 17:23, Nishanth Menon n...@ti.com wrote: On 01/13/2014 09:03 AM, Taras Kondratiuk wrote: From: Victor Kamensky victor.kamen...@linaro.org Assembler

Re: [PATCH] ARM: OMAP4: sleep: byteswap data for big-endian

2014-01-14 Thread Nishanth Menon
On Tue, Jan 14, 2014 at 11:35 AM, Victor Kamensky victor.kamen...@linaro.org wrote: When BE kernel is built Makefile does take of compiling code in BE mode. I.e all proper flags like -mbig-endian and -Wl,--be8 will be set. Agreed, and I assume you cannot instead switch to LE mode when entering

Re: [PATCH] ARM: OMAP4: sleep: byteswap data for big-endian

2014-01-14 Thread Victor Kamensky
On 14 January 2014 09:56, Nishanth Menon n...@ti.com wrote: On Tue, Jan 14, 2014 at 11:35 AM, Victor Kamensky victor.kamen...@linaro.org wrote: When BE kernel is built Makefile does take of compiling code in BE mode. I.e all proper flags like -mbig-endian and -Wl,--be8 will be set. Agreed,

Re: [PATCH] ARM: OMAP4: sleep: byteswap data for big-endian

2014-01-14 Thread Nishanth Menon
On Tue, Jan 14, 2014 at 2:20 PM, Victor Kamensky victor.kamen...@linaro.org wrote: On 14 January 2014 09:56, Nishanth Menon n...@ti.com wrote: On Tue, Jan 14, 2014 at 11:35 AM, Victor Kamensky victor.kamen...@linaro.org wrote: When BE kernel is built Makefile does take of compiling code in BE

Re: [PATCH] ARM: OMAP4: sleep: byteswap data for big-endian

2014-01-14 Thread Santosh Shilimkar
On Tuesday 14 January 2014 03:56 PM, Nishanth Menon wrote: On Tue, Jan 14, 2014 at 2:20 PM, Victor Kamensky victor.kamen...@linaro.org wrote: On 14 January 2014 09:56, Nishanth Menon n...@ti.com wrote: On Tue, Jan 14, 2014 at 11:35 AM, Victor Kamensky victor.kamen...@linaro.org wrote: When

Re: [PATCH] ARM: OMAP4: sleep: byteswap data for big-endian

2014-01-14 Thread Nishanth Menon
On Tue, Jan 14, 2014 at 3:03 PM, Santosh Shilimkar santosh.shilim...@ti.com wrote: ok.. some sort of Linaro thing about which I have no background about - but dont really care in this context. Nothing related Linaro. Its just that platforms are supporting ARM BE mode and Linaro folks had

Re: [PATCH] ARM: OMAP4: sleep: byteswap data for big-endian

2014-01-14 Thread Taras Kondratiuk
On 14 January 2014 23:13, Nishanth Menon n...@ti.com wrote: On Tue, Jan 14, 2014 at 3:03 PM, Santosh Shilimkar santosh.shilim...@ti.com wrote: ok.. some sort of Linaro thing about which I have no background about - but dont really care in this context. Nothing related Linaro. Its just that

Re: [PATCH] ARM: OMAP4: sleep: byteswap data for big-endian

2014-01-14 Thread Santosh Shilimkar
On Tuesday 14 January 2014 04:13 PM, Nishanth Menon wrote: On Tue, Jan 14, 2014 at 3:03 PM, Santosh Shilimkar santosh.shilim...@ti.com wrote: ok.. some sort of Linaro thing about which I have no background about - but dont really care in this context. Nothing related Linaro. Its just that

Re: [PATCH] ARM: OMAP4: sleep: byteswap data for big-endian

2014-01-13 Thread Nishanth Menon
On 01/13/2014 09:03 AM, Taras Kondratiuk wrote: > From: Victor Kamensky > > Assembler functions defined in sleep44xx.S need to byteswap values > after read / before write from h/w register if code compiled in big > endian mode. Simple change to do 'rev x, x' before str instruction > and after

Re: [PATCH] ARM: OMAP4: sleep: byteswap data for big-endian

2014-01-13 Thread Nishanth Menon
On 01/13/2014 09:03 AM, Taras Kondratiuk wrote: From: Victor Kamensky victor.kamen...@linaro.org Assembler functions defined in sleep44xx.S need to byteswap values after read / before write from h/w register if code compiled in big endian mode. Simple change to do 'rev x, x' before str