Re: [PATCH] ASoC: tda998x: add a codec to the HDMI transmitter

2014-07-03 Thread Jean-Francois Moine
On Thu, 3 Jul 2014 16:43:25 +0100 Russell King - ARM Linux wrote: > What you're doing in kirkwood-i2s is providing two plain DAI links, > and then insisting that only one can be active any any one time. > > A DPCM solution provides at least one frontend DAI link and at least > one backend DAI li

Re: [PATCH] ASoC: tda998x: add a codec to the HDMI transmitter

2014-07-03 Thread Russell King - ARM Linux
On Thu, Jul 03, 2014 at 05:29:09PM +0200, Jean-Francois Moine wrote: > I think that you did not look at my code. > > Both S/PDIF and I2S work with the TDA998x. It is a choice of the audio > subsystem to do this choice, not Russell King. If you think I'm arguing because I personally want something

Re: [PATCH] ASoC: tda998x: add a codec to the HDMI transmitter

2014-07-03 Thread Jean-Francois Moine
On Thu, 3 Jul 2014 14:43:46 +0100 Russell King - ARM Linux wrote: > > But, this means that there will be a lot of errors when DPCM will be > > used, because, in most cases for the Cubox (kirkwood audio + tda998x), > > both ways I2S and S/PDIF will be activated at the same time for a > > single st

Re: [PATCH] ASoC: tda998x: add a codec to the HDMI transmitter

2014-07-03 Thread Russell King - ARM Linux
On Thu, Jul 03, 2014 at 03:28:26PM +0200, Jean-Francois Moine wrote: > OK. no problem, I can do that: only the first stream is switched and > the second is rejected. > > But, this means that there will be a lot of errors when DPCM will be > used, because, in most cases for the Cubox (kirkwood audi

Re: [PATCH] ASoC: tda998x: add a codec to the HDMI transmitter

2014-07-03 Thread Jean-Francois Moine
On Thu, 3 Jul 2014 12:59:24 +0100 Mark Brown wrote: > > > Your board happens to only be able to present the same input on both I2S > > > and S/PDIF but that might not apply to other boards, they may be able to > > > route different signals to each which would present a practical problem. > > >

Re: [PATCH] ASoC: tda998x: add a codec to the HDMI transmitter

2014-07-03 Thread Mark Brown
On Thu, Jul 03, 2014 at 01:34:06PM +0200, Jean-Francois Moine wrote: > Mark Brown wrote: > > Your board happens to only be able to present the same input on both I2S > > and S/PDIF but that might not apply to other boards, they may be able to > > route different signals to each which would presen

Re: [PATCH] ASoC: tda998x: add a codec to the HDMI transmitter

2014-07-03 Thread Jean-Francois Moine
On Thu, 3 Jul 2014 11:44:32 +0100 Mark Brown wrote: > > > I'd expect this to return an error for the busy DAI rather than just > > > silently ignore it failing to start or (better) implement some control > > > to let the user select which of the DAIs is active. > > > This is not an error. If t

Re: [PATCH] ASoC: tda998x: add a codec to the HDMI transmitter

2014-07-03 Thread Mark Brown
On Thu, Jul 03, 2014 at 07:49:59AM +0200, Jean-Francois Moine wrote: > Mark Brown wrote: > > I'd expect this to return an error for the busy DAI rather than just > > silently ignore it failing to start or (better) implement some control > > to let the user select which of the DAIs is active. > T

Re: [PATCH] ASoC: tda998x: add a codec to the HDMI transmitter

2014-07-02 Thread Jean-Francois Moine
On Wed, 2 Jul 2014 20:42:52 +0100 Mark Brown wrote: > > I tested this CODEC with both DAPM and DPCM. If the audio subsystem > > asks for streaming on both I2S and S/PDIF, only the last call is served > > (this depends on the order of the DAI links in the audio card creation > > table). > > I'd

Re: [PATCH] ASoC: tda998x: add a codec to the HDMI transmitter

2014-07-02 Thread Mark Brown
On Wed, Jul 02, 2014 at 07:51:54PM +0200, Jean-Francois Moine wrote: > I tested this CODEC with both DAPM and DPCM. If the audio subsystem > asks for streaming on both I2S and S/PDIF, only the last call is served > (this depends on the order of the DAI links in the audio card creation > table). I

Re: [PATCH] ASoC: tda998x: add a codec to the HDMI transmitter

2014-07-02 Thread Mark Brown
On Wed, Jul 02, 2014 at 07:02:12PM +0100, Russell King - ARM Linux wrote: > Well, as far as I'm concerned right now, it's for Mark to sort out this > situation, and tell us what he wants to do with the Kirkwood stuff. I > suspect he's keeping quiet because he doesn't care about it. Well, that an

Re: [PATCH] ASoC: tda998x: add a codec to the HDMI transmitter

2014-07-02 Thread Russell King - ARM Linux
On Wed, Jul 02, 2014 at 07:51:54PM +0200, Jean-Francois Moine wrote: > On Wed, 2 Jul 2014 18:56:28 +0200 > Andrew Lunn wrote: > > > How well will this work with Russell concept of a front end and two > > backends? Can you uses your CODEC twice, once with the I2S backend and > > a second time with

Re: [PATCH] ASoC: tda998x: add a codec to the HDMI transmitter

2014-07-02 Thread Jean-Francois Moine
On Wed, 2 Jul 2014 18:56:28 +0200 Andrew Lunn wrote: > How well will this work with Russell concept of a front end and two > backends? Can you uses your CODEC twice, once with the I2S backend and > a second time with the S/PDIF backend? Hi Andrew, The TDA998x CODEC has two functions: - it sets

Re: [PATCH] ASoC: tda998x: add a codec to the HDMI transmitter

2014-07-02 Thread Andrew Lunn
On Wed, Jul 02, 2014 at 06:38:41PM +0200, Jean-Francois Moine wrote: > This patch adds a CODEC function to the NXP TDA998x HDMI transmitter. > > The CODEC handles both I2S and S/PDIF inputs and does dynamic input > switch in the TDA998x I2C driver on start/stop audio streaming. Hi Jean-Francois