Re: [PATCH] Allow kconfig to accept overrides

2007-10-18 Thread Jan Engelhardt
On Oct 18 2007 15:29, Sam Ravnborg wrote: >> Yeah, I've put in >> ("override: %s changes choice state", sym->name); >> this morning. >Care to send me the updated patch. > === Allow config variables in .config to override earlier ones in the same file. In other words, #

Re: [PATCH] Allow kconfig to accept overrides

2007-10-18 Thread Sam Ravnborg
On Sat, Oct 13, 2007 at 06:36:29PM +0200, Jan Engelhardt wrote: > > On Oct 13 2007 09:25, Randy Dunlap wrote: > > Jan Engelhardt wrote: > >> On Oct 13 2007 16:01, Stefan Richter wrote: > >> > > .config:176:warning: override: reassigning to symbol PREEMPT_VOLUNTARY > >> > > .config:176:warning:

Re: [PATCH] Allow kconfig to accept overrides

2007-10-18 Thread Sam Ravnborg
On Sat, Oct 13, 2007 at 06:36:29PM +0200, Jan Engelhardt wrote: On Oct 13 2007 09:25, Randy Dunlap wrote: Jan Engelhardt wrote: On Oct 13 2007 16:01, Stefan Richter wrote: .config:176:warning: override: reassigning to symbol PREEMPT_VOLUNTARY .config:176:warning: override:

Re: [PATCH] Allow kconfig to accept overrides

2007-10-18 Thread Jan Engelhardt
On Oct 18 2007 15:29, Sam Ravnborg wrote: Yeah, I've put in (override: %s changes choice state, sym-name); this morning. Care to send me the updated patch. === Allow config variables in .config to override earlier ones in the same file. In other words, # CONFIG_SECURITY is not

Re: [PATCH] Allow kconfig to accept overrides

2007-10-16 Thread Jan Engelhardt
Hi Sam, On Oct 16 2007 06:29, Sam Ravnborg wrote: >On Fri, Oct 12, 2007 at 11:44:08PM +0200, Jan Engelhardt wrote: >> >> Allow config variables in .config to override earlier ones in the same >> file. In other words, >> >> # CONFIG_SECURITY is not defined >> CONFIG_SECURITY=y >> >>

Re: [PATCH] Allow kconfig to accept overrides

2007-10-16 Thread Jan Engelhardt
Hi Sam, On Oct 16 2007 06:29, Sam Ravnborg wrote: On Fri, Oct 12, 2007 at 11:44:08PM +0200, Jan Engelhardt wrote: Allow config variables in .config to override earlier ones in the same file. In other words, # CONFIG_SECURITY is not defined CONFIG_SECURITY=y will activate it.

Re: [PATCH] Allow kconfig to accept overrides

2007-10-15 Thread Rob Landley
On Monday 15 October 2007 11:29:58 pm Sam Ravnborg wrote: > Hi Rob & Jan. > > On Fri, Oct 12, 2007 at 11:44:08PM +0200, Jan Engelhardt wrote: > > Allow config variables in .config to override earlier ones in the same > > file. In other words, > > > > # CONFIG_SECURITY is not defined > >

Re: [PATCH] Allow kconfig to accept overrides

2007-10-15 Thread Sam Ravnborg
Hi Rob & Jan. On Fri, Oct 12, 2007 at 11:44:08PM +0200, Jan Engelhardt wrote: > > Allow config variables in .config to override earlier ones in the same > file. In other words, > > # CONFIG_SECURITY is not defined > CONFIG_SECURITY=y > > will activate it. This makes it a bit easier

Re: [PATCH] Allow kconfig to accept overrides

2007-10-15 Thread Sam Ravnborg
Hi Rob Jan. On Fri, Oct 12, 2007 at 11:44:08PM +0200, Jan Engelhardt wrote: Allow config variables in .config to override earlier ones in the same file. In other words, # CONFIG_SECURITY is not defined CONFIG_SECURITY=y will activate it. This makes it a bit easier to do

Re: [PATCH] Allow kconfig to accept overrides

2007-10-15 Thread Rob Landley
On Monday 15 October 2007 11:29:58 pm Sam Ravnborg wrote: Hi Rob Jan. On Fri, Oct 12, 2007 at 11:44:08PM +0200, Jan Engelhardt wrote: Allow config variables in .config to override earlier ones in the same file. In other words, # CONFIG_SECURITY is not defined

Re: [PATCH] Allow kconfig to accept overrides

2007-10-13 Thread Jan Engelhardt
On Oct 13 2007 09:25, Randy Dunlap wrote: > Jan Engelhardt wrote: >> On Oct 13 2007 16:01, Stefan Richter wrote: >> > > .config:176:warning: override: reassigning to symbol PREEMPT_VOLUNTARY >> > > .config:176:warning: override: PREEMPT_VOLUNTARY turns state choice > > .config:176:warning:

Re: [PATCH] Allow kconfig to accept overrides

2007-10-13 Thread Randy Dunlap
Jan Engelhardt wrote: On Oct 13 2007 16:01, Stefan Richter wrote: .config:176:warning: override: reassigning to symbol PREEMPT_VOLUNTARY .config:176:warning: override: PREEMPT_VOLUNTARY turns state choice .config:176:warning: override: PREEMPT_VOLUNTARY modifies state choice "turns" is just

Re: [PATCH] Allow kconfig to accept overrides

2007-10-13 Thread Jan Engelhardt
On Oct 13 2007 16:01, Stefan Richter wrote: >> >> .config:176:warning: override: reassigning to symbol PREEMPT_VOLUNTARY >> .config:176:warning: override: PREEMPT_VOLUNTARY turns state choice > >Try to make it a single warning. Patches welcome. Even without the patch, i.e. original kconfig

Re: [PATCH] Allow kconfig to accept overrides

2007-10-13 Thread Stefan Richter
Jan Engelhardt wrote: > On Oct 13 2007 10:16, Stefan Richter wrote: >> Perhaps say >> >> warning("override: switching to choice %s", sym->name); >> >> if sym->name is [CONFIG_]PREEMPT_VOLUNTARY. Or what is it? > > .config:176:warning: override: reassigning to symbol PREEMPT_VOLUNTARY >

Re: [PATCH] Allow kconfig to accept overrides

2007-10-13 Thread Jan Engelhardt
On Oct 13 2007 10:16, Stefan Richter wrote: warning("override: %s turns state choice", sym->name); >>> >>>What does that warning message mean? I can't decipher it. >> >> It is when the value of a "choice" kconfig object is changed, for example >> this .config excerpt: >> >>

Re: [PATCH] Allow kconfig to accept overrides

2007-10-13 Thread Stefan Richter
Jan Engelhardt wrote: > On Oct 12 2007 15:57, Randy Dunlap wrote: >>On Fri, 12 Oct 2007 23:44:08 +0200 (CEST) Jan Engelhardt wrote: >> >>> warning("override: %s turns state choice", sym->name); >> >>What does that warning message mean? I can't decipher it. > > It is when the value of a "choice"

Re: [PATCH] Allow kconfig to accept overrides

2007-10-13 Thread Stefan Richter
Jan Engelhardt wrote: On Oct 12 2007 15:57, Randy Dunlap wrote: On Fri, 12 Oct 2007 23:44:08 +0200 (CEST) Jan Engelhardt wrote: warning(override: %s turns state choice, sym-name); What does that warning message mean? I can't decipher it. It is when the value of a choice kconfig object is

Re: [PATCH] Allow kconfig to accept overrides

2007-10-13 Thread Jan Engelhardt
On Oct 13 2007 10:16, Stefan Richter wrote: warning(override: %s turns state choice, sym-name); What does that warning message mean? I can't decipher it. It is when the value of a choice kconfig object is changed, for example this .config excerpt: CONFIG_PREEMPT_NONE=y #

Re: [PATCH] Allow kconfig to accept overrides

2007-10-13 Thread Stefan Richter
Jan Engelhardt wrote: On Oct 13 2007 10:16, Stefan Richter wrote: Perhaps say warning(override: switching to choice %s, sym-name); if sym-name is [CONFIG_]PREEMPT_VOLUNTARY. Or what is it? .config:176:warning: override: reassigning to symbol PREEMPT_VOLUNTARY .config:176:warning:

Re: [PATCH] Allow kconfig to accept overrides

2007-10-13 Thread Jan Engelhardt
On Oct 13 2007 16:01, Stefan Richter wrote: .config:176:warning: override: reassigning to symbol PREEMPT_VOLUNTARY .config:176:warning: override: PREEMPT_VOLUNTARY turns state choice Try to make it a single warning. Patches welcome. Even without the patch, i.e. original kconfig behavior,

Re: [PATCH] Allow kconfig to accept overrides

2007-10-13 Thread Randy Dunlap
Jan Engelhardt wrote: On Oct 13 2007 16:01, Stefan Richter wrote: .config:176:warning: override: reassigning to symbol PREEMPT_VOLUNTARY .config:176:warning: override: PREEMPT_VOLUNTARY turns state choice .config:176:warning: override: PREEMPT_VOLUNTARY modifies state choice turns is just

Re: [PATCH] Allow kconfig to accept overrides

2007-10-13 Thread Jan Engelhardt
On Oct 13 2007 09:25, Randy Dunlap wrote: Jan Engelhardt wrote: On Oct 13 2007 16:01, Stefan Richter wrote: .config:176:warning: override: reassigning to symbol PREEMPT_VOLUNTARY .config:176:warning: override: PREEMPT_VOLUNTARY turns state choice .config:176:warning: override:

Re: [PATCH] Allow kconfig to accept overrides

2007-10-12 Thread Randy Dunlap
Jan Engelhardt wrote: On Oct 12 2007 15:57, Randy Dunlap wrote: On Fri, 12 Oct 2007 23:44:08 +0200 (CEST) Jan Engelhardt wrote: warning("override: %s turns state choice", sym->name); What does that warning message mean? I can't decipher it. It is when the value of a "choice" kconfig

Re: [PATCH] Allow kconfig to accept overrides

2007-10-12 Thread Jan Engelhardt
On Oct 12 2007 15:57, Randy Dunlap wrote: >On Fri, 12 Oct 2007 23:44:08 +0200 (CEST) Jan Engelhardt wrote: > >> warning("override: %s turns state choice", sym->name); > >What does that warning message mean? I can't decipher it. It is when the value of a "choice" kconfig object is changed, for

Re: [PATCH] Allow kconfig to accept overrides

2007-10-12 Thread Randy Dunlap
On Fri, 12 Oct 2007 23:44:08 +0200 (CEST) Jan Engelhardt wrote: > Allow config variables in .config to override earlier ones in the same > file. In other words, > > # CONFIG_SECURITY is not defined > CONFIG_SECURITY=y > > will activate it. This makes it a bit easier to do > >

Re: [PATCH] Allow kconfig to accept overrides

2007-10-12 Thread Jan Engelhardt
On Oct 12 2007 14:49, Randy Dunlap wrote: > Jan Engelhardt wrote: >> Allow config variables in .config to override earlier ones in the same >> file. In other words, >> >> # CONFIG_SECURITY is not defined >> CONFIG_SECURITY=y >> >> will activate it. This makes it a bit easier to do >> >>

Re: [PATCH] Allow kconfig to accept overrides

2007-10-12 Thread Randy Dunlap
Jan Engelhardt wrote: Allow config variables in .config to override earlier ones in the same file. In other words, # CONFIG_SECURITY is not defined CONFIG_SECURITY=y will activate it. This makes it a bit easier to do (cat original-config myconfig myconfig2 ...

Re: [PATCH] Allow kconfig to accept overrides

2007-10-12 Thread Randy Dunlap
Jan Engelhardt wrote: Allow config variables in .config to override earlier ones in the same file. In other words, # CONFIG_SECURITY is not defined CONFIG_SECURITY=y will activate it. This makes it a bit easier to do (cat original-config myconfig myconfig2 ... .config)

Re: [PATCH] Allow kconfig to accept overrides

2007-10-12 Thread Jan Engelhardt
On Oct 12 2007 14:49, Randy Dunlap wrote: Jan Engelhardt wrote: Allow config variables in .config to override earlier ones in the same file. In other words, # CONFIG_SECURITY is not defined CONFIG_SECURITY=y will activate it. This makes it a bit easier to do (cat original-config

Re: [PATCH] Allow kconfig to accept overrides

2007-10-12 Thread Randy Dunlap
Jan Engelhardt wrote: On Oct 12 2007 15:57, Randy Dunlap wrote: On Fri, 12 Oct 2007 23:44:08 +0200 (CEST) Jan Engelhardt wrote: warning(override: %s turns state choice, sym-name); What does that warning message mean? I can't decipher it. It is when the value of a choice kconfig object is

Re: [PATCH] Allow kconfig to accept overrides

2007-10-12 Thread Jan Engelhardt
On Oct 12 2007 15:57, Randy Dunlap wrote: On Fri, 12 Oct 2007 23:44:08 +0200 (CEST) Jan Engelhardt wrote: warning(override: %s turns state choice, sym-name); What does that warning message mean? I can't decipher it. It is when the value of a choice kconfig object is changed, for example this

Re: [PATCH] Allow kconfig to accept overrides

2007-10-12 Thread Randy Dunlap
On Fri, 12 Oct 2007 23:44:08 +0200 (CEST) Jan Engelhardt wrote: Allow config variables in .config to override earlier ones in the same file. In other words, # CONFIG_SECURITY is not defined CONFIG_SECURITY=y will activate it. This makes it a bit easier to do (cat