Re: [PATCH] CodingStyle: Printing numbers in parentheses is fine

2007-09-30 Thread Jean Delvare
Hi David, On Sat, 29 Sep 2007 15:30:15 -0700, David Brownell wrote: > > > > Let's kill it, please. (i.e., ACK) > > > > > > But ... why? What value could needless parens provide? By definition of "needless", none. But the question is precisely whether the parentheses are always needless. The

Re: [PATCH] CodingStyle: Printing numbers in parentheses is fine

2007-09-30 Thread Jean Delvare
Hi Andrew, On Sat, 29 Sep 2007 03:51:56 -0700, Andrew Morton wrote: > On Sat, 29 Sep 2007 12:25:30 +0200 Jean Delvare <[EMAIL PROTECTED]> wrote: > > > Remove a not particularly relevant rule from CodingStyle. > > Sometimes, printing numbers in parentheses doesn't add value, but in > > some

Re: [PATCH] CodingStyle: Printing numbers in parentheses is fine

2007-09-30 Thread Jean Delvare
Hi Andrew, On Sat, 29 Sep 2007 03:51:56 -0700, Andrew Morton wrote: On Sat, 29 Sep 2007 12:25:30 +0200 Jean Delvare [EMAIL PROTECTED] wrote: Remove a not particularly relevant rule from CodingStyle. Sometimes, printing numbers in parentheses doesn't add value, but in some (most?) cases

Re: [PATCH] CodingStyle: Printing numbers in parentheses is fine

2007-09-30 Thread Jean Delvare
Hi David, On Sat, 29 Sep 2007 15:30:15 -0700, David Brownell wrote: Let's kill it, please. (i.e., ACK) But ... why? What value could needless parens provide? By definition of needless, none. But the question is precisely whether the parentheses are always needless. The way your

Re: [PATCH] CodingStyle: Printing numbers in parentheses is fine

2007-09-29 Thread Valdis . Kletnieks
On Sat, 29 Sep 2007 03:51:56 PDT, Andrew Morton said: > Printing something like > > bytes remaining: 0x12 (18) > > is a quite logical thing to do, although pretty darm pointless. On the other hand, printing this: magic number: 0x2710 probably doesn't ring any bells, but if you

Re: [PATCH] CodingStyle: Printing numbers in parentheses is fine

2007-09-29 Thread Måns Rullgård
David Brownell <[EMAIL PROTECTED]> writes: >> > > Let's kill it, please. (i.e., ACK) >> > >> > But ... why? What value could needless parens provide? >> >> Who says that needless parens could provide value? > > Jean, which is why he submitted the patch. > You, implicitly, by acking a patch

Re: [PATCH] CodingStyle: Printing numbers in parentheses is fine

2007-09-29 Thread Randy Dunlap
On Sat, 29 Sep 2007 15:30:15 -0700 David Brownell wrote: > > > > Let's kill it, please. (i.e., ACK) > > > > > > But ... why? What value could needless parens provide? > > > > Who says that needless parens could provide value? > > Jean, which is why he submitted the patch. > You, implicitly,

Re: [PATCH] CodingStyle: Printing numbers in parentheses is fine

2007-09-29 Thread David Brownell
> > > Let's kill it, please. (i.e., ACK) > > > > But ... why? What value could needless parens provide? > > Who says that needless parens could provide value? Jean, which is why he submitted the patch. You, implicitly, by acking a patch saying those parens are bad. But not me ... I don't think

Re: [PATCH] CodingStyle: Printing numbers in parentheses is fine

2007-09-29 Thread Randy Dunlap
On Sat, 29 Sep 2007 11:53:06 -0700 David Brownell wrote: > > From [EMAIL PROTECTED] Sat Sep 29 11:40:17 2007 > > > > Let's kill it, please. (i.e., ACK) > > But ... why? What value could needless parens provide? Who says that needless parens could provide value? > "Yet Another Subtle And

Re: [PATCH] CodingStyle: Printing numbers in parentheses is fine

2007-09-29 Thread David Brownell
> From [EMAIL PROTECTED] Sat Sep 29 11:40:17 2007 > > Let's kill it, please. (i.e., ACK) But ... why? What value could needless parens provide? "Yet Another Subtle And Hard To Fix Source Of Bloat" is not a plus. I'd kind of think a change like this should have some positive motivation. - To

Re: [PATCH] CodingStyle: Printing numbers in parentheses is fine

2007-09-29 Thread Randy Dunlap
On Sat, 29 Sep 2007 03:51:56 -0700 Andrew Morton wrote: > On Sat, 29 Sep 2007 12:25:30 +0200 Jean Delvare <[EMAIL PROTECTED]> wrote: > > > Remove a not particularly relevant rule from CodingStyle. > > Sometimes, printing numbers in parentheses doesn't add value, but in > > some (most?) cases it

Re: [PATCH] CodingStyle: Printing numbers in parentheses is fine

2007-09-29 Thread David Brownell
> > -Printing numbers in parentheses (%d) adds no value and should be avoided. > > I wonder how that got there. Well, the only place that numbers "naturally" appear wrapped in parenthesis is tables of credits and debits... as a debit, sort of a literal "add no value" situation. ;) Oh, and for

Re: [PATCH] CodingStyle: Printing numbers in parentheses is fine

2007-09-29 Thread Andrew Morton
On Sat, 29 Sep 2007 12:25:30 +0200 Jean Delvare <[EMAIL PROTECTED]> wrote: > Remove a not particularly relevant rule from CodingStyle. > Sometimes, printing numbers in parentheses doesn't add value, but in > some (most?) cases it makes the message easier to read. As a matter of > fact, this

Re: [PATCH] CodingStyle: Printing numbers in parentheses is fine

2007-09-29 Thread Andrew Morton
On Sat, 29 Sep 2007 12:25:30 +0200 Jean Delvare [EMAIL PROTECTED] wrote: Remove a not particularly relevant rule from CodingStyle. Sometimes, printing numbers in parentheses doesn't add value, but in some (most?) cases it makes the message easier to read. As a matter of fact, this practice is

Re: [PATCH] CodingStyle: Printing numbers in parentheses is fine

2007-09-29 Thread David Brownell
-Printing numbers in parentheses (%d) adds no value and should be avoided. I wonder how that got there. Well, the only place that numbers naturally appear wrapped in parenthesis is tables of credits and debits... as a debit, sort of a literal add no value situation. ;) Oh, and for

Re: [PATCH] CodingStyle: Printing numbers in parentheses is fine

2007-09-29 Thread Randy Dunlap
On Sat, 29 Sep 2007 03:51:56 -0700 Andrew Morton wrote: On Sat, 29 Sep 2007 12:25:30 +0200 Jean Delvare [EMAIL PROTECTED] wrote: Remove a not particularly relevant rule from CodingStyle. Sometimes, printing numbers in parentheses doesn't add value, but in some (most?) cases it makes the

Re: [PATCH] CodingStyle: Printing numbers in parentheses is fine

2007-09-29 Thread David Brownell
From [EMAIL PROTECTED] Sat Sep 29 11:40:17 2007 Let's kill it, please. (i.e., ACK) But ... why? What value could needless parens provide? Yet Another Subtle And Hard To Fix Source Of Bloat is not a plus. I'd kind of think a change like this should have some positive motivation. - To

Re: [PATCH] CodingStyle: Printing numbers in parentheses is fine

2007-09-29 Thread Randy Dunlap
On Sat, 29 Sep 2007 11:53:06 -0700 David Brownell wrote: From [EMAIL PROTECTED] Sat Sep 29 11:40:17 2007 Let's kill it, please. (i.e., ACK) But ... why? What value could needless parens provide? Who says that needless parens could provide value? Yet Another Subtle And Hard To Fix

Re: [PATCH] CodingStyle: Printing numbers in parentheses is fine

2007-09-29 Thread David Brownell
Let's kill it, please. (i.e., ACK) But ... why? What value could needless parens provide? Who says that needless parens could provide value? Jean, which is why he submitted the patch. You, implicitly, by acking a patch saying those parens are bad. But not me ... I don't think this

Re: [PATCH] CodingStyle: Printing numbers in parentheses is fine

2007-09-29 Thread Randy Dunlap
On Sat, 29 Sep 2007 15:30:15 -0700 David Brownell wrote: Let's kill it, please. (i.e., ACK) But ... why? What value could needless parens provide? Who says that needless parens could provide value? Jean, which is why he submitted the patch. You, implicitly, by acking a patch

Re: [PATCH] CodingStyle: Printing numbers in parentheses is fine

2007-09-29 Thread Måns Rullgård
David Brownell [EMAIL PROTECTED] writes: Let's kill it, please. (i.e., ACK) But ... why? What value could needless parens provide? Who says that needless parens could provide value? Jean, which is why he submitted the patch. You, implicitly, by acking a patch saying those parens

Re: [PATCH] CodingStyle: Printing numbers in parentheses is fine

2007-09-29 Thread Valdis . Kletnieks
On Sat, 29 Sep 2007 03:51:56 PDT, Andrew Morton said: Printing something like bytes remaining: 0x12 (18) is a quite logical thing to do, although pretty darm pointless. On the other hand, printing this: magic number: 0x2710 probably doesn't ring any bells, but if you