Re: [PATCH] Input: soc_button_array: Remove kfree on data allocated with devm_zalloc

2014-07-25 Thread David Rientjes
On Fri, 25 Jul 2014, Sachin Kamat wrote: > On Fri, Jul 25, 2014 at 12:39 PM, wrote: > > From: Pramod Gurav > > > > This patch does below: > > - Removes kfree done on data allocated with devm_zalloc in probe > > path of the driver. > > - Adds a check on return value from devm_kzalloc which

Re: [PATCH] Input: soc_button_array: Remove kfree on data allocated with devm_zalloc

2014-07-25 Thread pramod gurav
Thanks Sachin for the review. Will resend the patch addressing your review comments. On Fri, Jul 25, 2014 at 1:59 PM, Sachin Kamat wrote: > On Fri, Jul 25, 2014 at 12:39 PM, wrote: >> From: Pramod Gurav >> >> This patch does below: >> - Removes kfree done on data allocated with devm_zalloc in

Re: [PATCH] Input: soc_button_array: Remove kfree on data allocated with devm_zalloc

2014-07-25 Thread Sachin Kamat
On Fri, Jul 25, 2014 at 12:39 PM, wrote: > From: Pramod Gurav > > This patch does below: > - Removes kfree done on data allocated with devm_zalloc in probe > path of the driver. > - Adds a check on return value from devm_kzalloc which was missing > and renames a lable from err_free_mem to

Re: [PATCH] Input: soc_button_array: Remove kfree on data allocated with devm_zalloc

2014-07-25 Thread Sachin Kamat
On Fri, Jul 25, 2014 at 12:39 PM, pramod.gurav@gmail.com wrote: From: Pramod Gurav pramod.gu...@smartplayin.com This patch does below: - Removes kfree done on data allocated with devm_zalloc in probe path of the driver. - Adds a check on return value from devm_kzalloc which was

Re: [PATCH] Input: soc_button_array: Remove kfree on data allocated with devm_zalloc

2014-07-25 Thread pramod gurav
Thanks Sachin for the review. Will resend the patch addressing your review comments. On Fri, Jul 25, 2014 at 1:59 PM, Sachin Kamat spk.li...@gmail.com wrote: On Fri, Jul 25, 2014 at 12:39 PM, pramod.gurav@gmail.com wrote: From: Pramod Gurav pramod.gu...@smartplayin.com This patch does

Re: [PATCH] Input: soc_button_array: Remove kfree on data allocated with devm_zalloc

2014-07-25 Thread David Rientjes
On Fri, 25 Jul 2014, Sachin Kamat wrote: On Fri, Jul 25, 2014 at 12:39 PM, pramod.gurav@gmail.com wrote: From: Pramod Gurav pramod.gu...@smartplayin.com This patch does below: - Removes kfree done on data allocated with devm_zalloc in probe path of the driver. - Adds a check