Re: [PATCH] PCI: keystone: fix incorrect annotations on probe and remove

2015-01-23 Thread Bjorn Helgaas
On Thu, Jan 08, 2015 at 02:17:36PM -0800, Dmitry Torokhov wrote: > Even though platform bus is not hot-pluggable, devices on it can be unbound > from the driver and bound back to it via sysfs, so we should not be using > __init annotations on probe() and __exit annotations on remove() methods. >

Re: [PATCH] PCI: keystone: fix incorrect annotations on probe and remove

2015-01-23 Thread Dmitry Torokhov
On Fri, Jan 23, 2015 at 01:47:26PM -0800, Dmitry Torokhov wrote: > Hi Bjorn, > > On Fri, Jan 23, 2015 at 03:34:12PM -0600, Bjorn Helgaas wrote: > > [+cc Fabio] > > > > On Thu, Jan 08, 2015 at 02:17:36PM -0800, Dmitry Torokhov wrote: > > > Even though platform bus is not hot-pluggable, devices on

Re: [PATCH] PCI: keystone: fix incorrect annotations on probe and remove

2015-01-23 Thread Dmitry Torokhov
Hi Bjorn, On Fri, Jan 23, 2015 at 03:34:12PM -0600, Bjorn Helgaas wrote: > [+cc Fabio] > > On Thu, Jan 08, 2015 at 02:17:36PM -0800, Dmitry Torokhov wrote: > > Even though platform bus is not hot-pluggable, devices on it can be unbound > > from the driver and bound back to it via sysfs, so we

Re: [PATCH] PCI: keystone: fix incorrect annotations on probe and remove

2015-01-23 Thread Bjorn Helgaas
[+cc Fabio] On Thu, Jan 08, 2015 at 02:17:36PM -0800, Dmitry Torokhov wrote: > Even though platform bus is not hot-pluggable, devices on it can be unbound > from the driver and bound back to it via sysfs, so we should not be using > __init annotations on probe() and __exit annotations on remove()

Re: [PATCH] PCI: keystone: fix incorrect annotations on probe and remove

2015-01-23 Thread Dmitry Torokhov
Hi Bjorn, On Fri, Jan 23, 2015 at 03:34:12PM -0600, Bjorn Helgaas wrote: [+cc Fabio] On Thu, Jan 08, 2015 at 02:17:36PM -0800, Dmitry Torokhov wrote: Even though platform bus is not hot-pluggable, devices on it can be unbound from the driver and bound back to it via sysfs, so we should

Re: [PATCH] PCI: keystone: fix incorrect annotations on probe and remove

2015-01-23 Thread Dmitry Torokhov
On Fri, Jan 23, 2015 at 01:47:26PM -0800, Dmitry Torokhov wrote: Hi Bjorn, On Fri, Jan 23, 2015 at 03:34:12PM -0600, Bjorn Helgaas wrote: [+cc Fabio] On Thu, Jan 08, 2015 at 02:17:36PM -0800, Dmitry Torokhov wrote: Even though platform bus is not hot-pluggable, devices on it can be

Re: [PATCH] PCI: keystone: fix incorrect annotations on probe and remove

2015-01-23 Thread Bjorn Helgaas
On Thu, Jan 08, 2015 at 02:17:36PM -0800, Dmitry Torokhov wrote: Even though platform bus is not hot-pluggable, devices on it can be unbound from the driver and bound back to it via sysfs, so we should not be using __init annotations on probe() and __exit annotations on remove() methods.

Re: [PATCH] PCI: keystone: fix incorrect annotations on probe and remove

2015-01-23 Thread Bjorn Helgaas
[+cc Fabio] On Thu, Jan 08, 2015 at 02:17:36PM -0800, Dmitry Torokhov wrote: Even though platform bus is not hot-pluggable, devices on it can be unbound from the driver and bound back to it via sysfs, so we should not be using __init annotations on probe() and __exit annotations on remove()