Re: [PATCH] Staging: speakup: kobjects: Return the error type to caller

2015-12-07 Thread Dan Carpenter
On Mon, Dec 07, 2015 at 12:46:37PM +0530, Saurabh Sengar wrote: > >> @@ -688,6 +689,8 @@ ssize_t spk_var_store(struct kobject *kobj, struct > >> kobj_attribute *attr, > >> > >> if (ret == -ERESTART) > >> pr_info("%s reset to default value\n", param->name); > > > > Is this

Re: [PATCH] Staging: speakup: kobjects: Return the error type to caller

2015-12-07 Thread Dan Carpenter
On Mon, Dec 07, 2015 at 12:46:37PM +0530, Saurabh Sengar wrote: > >> @@ -688,6 +689,8 @@ ssize_t spk_var_store(struct kobject *kobj, struct > >> kobj_attribute *attr, > >> > >> if (ret == -ERESTART) > >> pr_info("%s reset to default value\n", param->name); > > > > Is this

Re: [PATCH] Staging: speakup: kobjects: Return the error type to caller

2015-12-06 Thread Saurabh Sengar
On 7 December 2015 at 12:18, Dan Carpenter wrote: > On Fri, Dec 04, 2015 at 08:12:33PM +0530, Saurabh Sengar wrote: >> Inorder to notify the user that value is not successfuly set in sys >> entry, error should be returned from store function instead of count >> >> Signed-off-by: Saurabh Sengar

Re: [PATCH] Staging: speakup: kobjects: Return the error type to caller

2015-12-06 Thread Dan Carpenter
On Fri, Dec 04, 2015 at 08:12:33PM +0530, Saurabh Sengar wrote: > Inorder to notify the user that value is not successfuly set in sys > entry, error should be returned from store function instead of count > > Signed-off-by: Saurabh Sengar > --- > drivers/staging/speakup/kobjects.c | 5 - >

Re: [PATCH] Staging: speakup: kobjects: Return the error type to caller

2015-12-06 Thread Dan Carpenter
On Fri, Dec 04, 2015 at 08:12:33PM +0530, Saurabh Sengar wrote: > Inorder to notify the user that value is not successfuly set in sys > entry, error should be returned from store function instead of count > > Signed-off-by: Saurabh Sengar > --- >

Re: [PATCH] Staging: speakup: kobjects: Return the error type to caller

2015-12-06 Thread Saurabh Sengar
On 7 December 2015 at 12:18, Dan Carpenter wrote: > On Fri, Dec 04, 2015 at 08:12:33PM +0530, Saurabh Sengar wrote: >> Inorder to notify the user that value is not successfuly set in sys >> entry, error should be returned from store function instead of count >> >>