On Thu, Jun 06, 2013 at 01:47:46PM +0200, Pavel Machek wrote:
> On Thu 2013-06-06 09:23:13, Wang YanQing wrote:
> > On Tue, Jun 04, 2013 at 10:13:18PM +0200, Pavel Machek wrote:
> > > On Tue 2013-05-21 13:15:12, Wang YanQing wrote:
> > > > Impact:
> > > > 1:convert all remain take_over_console to
On Thu 2013-06-06 09:23:13, Wang YanQing wrote:
> On Tue, Jun 04, 2013 at 10:13:18PM +0200, Pavel Machek wrote:
> > On Tue 2013-05-21 13:15:12, Wang YanQing wrote:
> > > Impact:
> > > 1:convert all remain take_over_console to do_take_over_console
> >
> > This is step backwards.
>
> What is step
On Thu 2013-06-06 09:23:13, Wang YanQing wrote:
On Tue, Jun 04, 2013 at 10:13:18PM +0200, Pavel Machek wrote:
On Tue 2013-05-21 13:15:12, Wang YanQing wrote:
Impact:
1:convert all remain take_over_console to do_take_over_console
This is step backwards.
What is step backwards?
On Thu, Jun 06, 2013 at 01:47:46PM +0200, Pavel Machek wrote:
On Thu 2013-06-06 09:23:13, Wang YanQing wrote:
On Tue, Jun 04, 2013 at 10:13:18PM +0200, Pavel Machek wrote:
On Tue 2013-05-21 13:15:12, Wang YanQing wrote:
Impact:
1:convert all remain take_over_console to
On Tue, Jun 04, 2013 at 10:13:18PM +0200, Pavel Machek wrote:
> On Tue 2013-05-21 13:15:12, Wang YanQing wrote:
> > Impact:
> > 1:convert all remain take_over_console to do_take_over_console
>
> This is step backwards.
What is step backwards? do_take_over_console appear MUCH MUCH later in kernel
On Tue, Jun 04, 2013 at 10:13:18PM +0200, Pavel Machek wrote:
On Tue 2013-05-21 13:15:12, Wang YanQing wrote:
Impact:
1:convert all remain take_over_console to do_take_over_console
This is step backwards.
What is step backwards? do_take_over_console appear MUCH MUCH later in kernel
than
On Tue 2013-05-21 13:15:12, Wang YanQing wrote:
> Impact:
> 1:convert all remain take_over_console to do_take_over_console
This is step backwards.
> --- a/arch/alpha/kernel/console.c
> +++ b/arch/alpha/kernel/console.c
> @@ -61,7 +61,9 @@ locate_and_init_vga(void *(*sel_func)(void *, void *))
>
On Tue 2013-05-21 13:15:12, Wang YanQing wrote:
Impact:
1:convert all remain take_over_console to do_take_over_console
This is step backwards.
--- a/arch/alpha/kernel/console.c
+++ b/arch/alpha/kernel/console.c
@@ -61,7 +61,9 @@ locate_and_init_vga(void *(*sel_func)(void *, void *))
On 05/21/2013 12:29 PM, Wang YanQing wrote:
On Wed, May 22, 2013 at 12:18:49AM +0800, Wang YanQing wrote:
Except now you're spreading the brokenness that is console_lock()
over many more source files than the single-use case of
do_take_over_console().
The actual interface is
On Wed, May 22, 2013 at 12:18:49AM +0800, Wang YanQing wrote:
> > Except now you're spreading the brokenness that is console_lock()
> > over many more source files than the single-use case of
> > do_take_over_console().
>
> > The actual interface is take_over_console(); the _workaround_ is
> >
On Tue, May 21, 2013 at 11:48:58AM -0400, Peter Hurley wrote:
> On 05/21/2013 10:42 AM, Wang YanQing wrote:
> > On Tue, May 21, 2013 at 09:10:33AM -0400, Peter Hurley wrote:
> >> I would rather revert dc9641895abb which purported to delete
> >> _unneeded_ functions than have this. Obviously the
On 05/21/2013 10:42 AM, Wang YanQing wrote:
On Tue, May 21, 2013 at 09:10:33AM -0400, Peter Hurley wrote:
I would rather revert dc9641895abb which purported to delete
_unneeded_ functions than have this. Obviously the functions
were needed.
Hi Peter, this series patches' goal is to reduce
On Tue, May 21, 2013 at 09:10:33AM -0400, Peter Hurley wrote:
> I would rather revert dc9641895abb which purported to delete
> _unneeded_ functions than have this. Obviously the functions
> were needed.
>
Hi Peter, this series patches' goal is to reduce codes'
redundance and function
On 05/21/2013 01:15 AM, Wang YanQing wrote:
Impact:
1:convert all remain take_over_console to do_take_over_console
2:update take_over_console to do_take_over_console in comment
Commit dc9641895abb ("vt: delete unneeded functions
register_con_driver|take_over_console") delete take_over_console,
On 05/21/2013 01:15 AM, Wang YanQing wrote:
Impact:
1:convert all remain take_over_console to do_take_over_console
2:update take_over_console to do_take_over_console in comment
Commit dc9641895abb (vt: delete unneeded functions
register_con_driver|take_over_console) delete take_over_console,
On Tue, May 21, 2013 at 09:10:33AM -0400, Peter Hurley wrote:
I would rather revert dc9641895abb which purported to delete
_unneeded_ functions than have this. Obviously the functions
were needed.
Hi Peter, this series patches' goal is to reduce codes'
redundance and function duplication.
On 05/21/2013 10:42 AM, Wang YanQing wrote:
On Tue, May 21, 2013 at 09:10:33AM -0400, Peter Hurley wrote:
I would rather revert dc9641895abb which purported to delete
_unneeded_ functions than have this. Obviously the functions
were needed.
Hi Peter, this series patches' goal is to reduce
On Tue, May 21, 2013 at 11:48:58AM -0400, Peter Hurley wrote:
On 05/21/2013 10:42 AM, Wang YanQing wrote:
On Tue, May 21, 2013 at 09:10:33AM -0400, Peter Hurley wrote:
I would rather revert dc9641895abb which purported to delete
_unneeded_ functions than have this. Obviously the functions
On Wed, May 22, 2013 at 12:18:49AM +0800, Wang YanQing wrote:
Except now you're spreading the brokenness that is console_lock()
over many more source files than the single-use case of
do_take_over_console().
The actual interface is take_over_console(); the _workaround_ is
exposing
On 05/21/2013 12:29 PM, Wang YanQing wrote:
On Wed, May 22, 2013 at 12:18:49AM +0800, Wang YanQing wrote:
Except now you're spreading the brokenness that is console_lock()
over many more source files than the single-use case of
do_take_over_console().
The actual interface is
20 matches
Mail list logo
