Re: [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization

2016-09-22 Thread Mark Brown
On Thu, Sep 22, 2016 at 08:13:01PM +0200, Boris Brezillon wrote: > So, there are 2 different problems here: > 1/ the board no longer boots because of commit 87248991a1de and a >missing entry in the voltage table > 2/ claiming the PWM pins at probe time can cause glitches > I'm currently

Re: [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization

2016-09-22 Thread Mark Brown
On Thu, Sep 22, 2016 at 08:13:01PM +0200, Boris Brezillon wrote: > So, there are 2 different problems here: > 1/ the board no longer boots because of commit 87248991a1de and a >missing entry in the voltage table > 2/ claiming the PWM pins at probe time can cause glitches > I'm currently

Re: [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization

2016-09-22 Thread Boris Brezillon
On Thu, 22 Sep 2016 17:47:52 +0100 Mark Brown wrote: > On Thu, Sep 22, 2016 at 05:12:17PM +0200, Boris Brezillon wrote: > > +Mark > > > I realize Mark has been out of the discussion, and what started as a DT > > problem actually turned into a PWM regulator discussion. > >

Re: [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization

2016-09-22 Thread Boris Brezillon
On Thu, 22 Sep 2016 17:47:52 +0100 Mark Brown wrote: > On Thu, Sep 22, 2016 at 05:12:17PM +0200, Boris Brezillon wrote: > > +Mark > > > I realize Mark has been out of the discussion, and what started as a DT > > problem actually turned into a PWM regulator discussion. > > Maybe we should

Re: [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization

2016-09-22 Thread Mark Brown
On Thu, Sep 22, 2016 at 05:12:17PM +0200, Boris Brezillon wrote: > +Mark > I realize Mark has been out of the discussion, and what started as a DT > problem actually turned into a PWM regulator discussion. > Maybe we should start a new thread. Probably, you're lucky I even looked at this - the

Re: [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization

2016-09-22 Thread Mark Brown
On Thu, Sep 22, 2016 at 05:12:17PM +0200, Boris Brezillon wrote: > +Mark > I realize Mark has been out of the discussion, and what started as a DT > problem actually turned into a PWM regulator discussion. > Maybe we should start a new thread. Probably, you're lucky I even looked at this - the

Re: [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization

2016-09-22 Thread Boris Brezillon
+Mark I realize Mark has been out of the discussion, and what started as a DT problem actually turned into a PWM regulator discussion. Maybe we should start a new thread. On Mon, 19 Sep 2016 14:15:06 -0700 Doug Anderson wrote: > Hi, > > On Mon, Sep 19, 2016 at 1:43 PM,

Re: [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization

2016-09-22 Thread Boris Brezillon
+Mark I realize Mark has been out of the discussion, and what started as a DT problem actually turned into a PWM regulator discussion. Maybe we should start a new thread. On Mon, 19 Sep 2016 14:15:06 -0700 Doug Anderson wrote: > Hi, > > On Mon, Sep 19, 2016 at 1:43 PM, Boris Brezillon >

Re: [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization

2016-09-19 Thread Doug Anderson
Hi, On Mon, Sep 19, 2016 at 1:43 PM, Boris Brezillon wrote: > On Mon, 19 Sep 2016 11:12:12 -0700 > Doug Anderson wrote: > >> Hi, >> >> On Mon, Sep 19, 2016 at 11:06 AM, Boris Brezillon >> wrote: >> >

Re: [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization

2016-09-19 Thread Doug Anderson
Hi, On Mon, Sep 19, 2016 at 1:43 PM, Boris Brezillon wrote: > On Mon, 19 Sep 2016 11:12:12 -0700 > Doug Anderson wrote: > >> Hi, >> >> On Mon, Sep 19, 2016 at 11:06 AM, Boris Brezillon >> wrote: >> > On Mon, 19 Sep 2016 10:52:51 -0700 >> > Doug Anderson wrote: >> > >> >> Hi, >> >> >> >> On

Re: [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization

2016-09-19 Thread Boris Brezillon
On Mon, 19 Sep 2016 11:12:12 -0700 Doug Anderson wrote: > Hi, > > On Mon, Sep 19, 2016 at 11:06 AM, Boris Brezillon > wrote: > > On Mon, 19 Sep 2016 10:52:51 -0700 > > Doug Anderson wrote: > > > >> Hi, > >> >

Re: [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization

2016-09-19 Thread Boris Brezillon
On Mon, 19 Sep 2016 11:12:12 -0700 Doug Anderson wrote: > Hi, > > On Mon, Sep 19, 2016 at 11:06 AM, Boris Brezillon > wrote: > > On Mon, 19 Sep 2016 10:52:51 -0700 > > Doug Anderson wrote: > > > >> Hi, > >> > >> On Mon, Sep 19, 2016 at 10:48 AM, Boris Brezillon > >> wrote: > >> > The PWM

Re: [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization

2016-09-19 Thread Boris Brezillon
On Mon, 19 Sep 2016 11:12:12 -0700 Doug Anderson wrote: > Hi, > > On Mon, Sep 19, 2016 at 11:06 AM, Boris Brezillon > wrote: > > On Mon, 19 Sep 2016 10:52:51 -0700 > > Doug Anderson wrote: > > > >> Hi, > >> >

Re: [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization

2016-09-19 Thread Boris Brezillon
On Mon, 19 Sep 2016 11:12:12 -0700 Doug Anderson wrote: > Hi, > > On Mon, Sep 19, 2016 at 11:06 AM, Boris Brezillon > wrote: > > On Mon, 19 Sep 2016 10:52:51 -0700 > > Doug Anderson wrote: > > > >> Hi, > >> > >> On Mon, Sep 19, 2016 at 10:48 AM, Boris Brezillon > >> wrote: > >> > The PWM

Re: [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization

2016-09-19 Thread Doug Anderson
Hi, On Mon, Sep 19, 2016 at 11:06 AM, Boris Brezillon wrote: > On Mon, 19 Sep 2016 10:52:51 -0700 > Doug Anderson wrote: > >> Hi, >> >> On Mon, Sep 19, 2016 at 10:48 AM, Boris Brezillon >> wrote: >>

Re: [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization

2016-09-19 Thread Doug Anderson
Hi, On Mon, Sep 19, 2016 at 11:06 AM, Boris Brezillon wrote: > On Mon, 19 Sep 2016 10:52:51 -0700 > Doug Anderson wrote: > >> Hi, >> >> On Mon, Sep 19, 2016 at 10:48 AM, Boris Brezillon >> wrote: >> > The PWM chip has always claimed the pins and muxed them to the PWM IP. >> > So, this means

Re: [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization

2016-09-19 Thread Boris Brezillon
On Mon, 19 Sep 2016 10:52:51 -0700 Doug Anderson wrote: > Hi, > > On Mon, Sep 19, 2016 at 10:48 AM, Boris Brezillon > wrote: > > The PWM chip has always claimed the pins and muxed them to the PWM IP. > > So, this means it's broken from

Re: [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization

2016-09-19 Thread Boris Brezillon
On Mon, 19 Sep 2016 10:52:51 -0700 Doug Anderson wrote: > Hi, > > On Mon, Sep 19, 2016 at 10:48 AM, Boris Brezillon > wrote: > > The PWM chip has always claimed the pins and muxed them to the PWM IP. > > So, this means it's broken from the beginning, and my patch is only > > uncovering the

Re: [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization

2016-09-19 Thread Doug Anderson
Hi, On Mon, Sep 19, 2016 at 10:48 AM, Boris Brezillon wrote: > The PWM chip has always claimed the pins and muxed them to the PWM IP. > So, this means it's broken from the beginning, and my patch is only > uncovering the problem (unless the pins stay

Re: [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization

2016-09-19 Thread Doug Anderson
Hi, On Mon, Sep 19, 2016 at 10:48 AM, Boris Brezillon wrote: > The PWM chip has always claimed the pins and muxed them to the PWM IP. > So, this means it's broken from the beginning, and my patch is only > uncovering the problem (unless the pins stay configured as input until > the PWM is

Re: [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization

2016-09-19 Thread Boris Brezillon
On Mon, 19 Sep 2016 10:22:43 -0700 Doug Anderson wrote: > Hi, > > On Mon, Sep 19, 2016 at 10:13 AM, Boris Brezillon > wrote: > > Correct me if I'm wrong, but the main problem here is that, when we try > > to detect the initial

Re: [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization

2016-09-19 Thread Boris Brezillon
On Mon, 19 Sep 2016 10:22:43 -0700 Doug Anderson wrote: > Hi, > > On Mon, Sep 19, 2016 at 10:13 AM, Boris Brezillon > wrote: > > Correct me if I'm wrong, but the main problem here is that, when we try > > to detect the initial regulator state, we ran into a "missing entry in > > the duty-cycle

Re: [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization

2016-09-19 Thread Heiko Stuebner
Am Montag, 19. September 2016, 19:13:27 CEST schrieb Boris Brezillon: > On Mon, 19 Sep 2016 09:38:34 -0700 > > Doug Anderson wrote: > > Hi, > > > > On Mon, Sep 19, 2016 at 9:15 AM, Heiko Stuebner wrote: > > > Am Montag, 19. September 2016, 08:15:30 CEST

Re: [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization

2016-09-19 Thread Heiko Stuebner
Am Montag, 19. September 2016, 19:13:27 CEST schrieb Boris Brezillon: > On Mon, 19 Sep 2016 09:38:34 -0700 > > Doug Anderson wrote: > > Hi, > > > > On Mon, Sep 19, 2016 at 9:15 AM, Heiko Stuebner wrote: > > > Am Montag, 19. September 2016, 08:15:30 CEST schrieb Doug Anderson: > > >> Hi, > > >>

Re: [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization

2016-09-19 Thread Boris Brezillon
On Mon, 19 Sep 2016 09:38:34 -0700 Doug Anderson wrote: > Hi, > > On Mon, Sep 19, 2016 at 9:15 AM, Heiko Stuebner wrote: > > Am Montag, 19. September 2016, 08:15:30 CEST schrieb Doug Anderson: > >> Hi, > >> > >> On Mon, Sep 19, 2016 at 1:44 AM, Andy

Re: [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization

2016-09-19 Thread Boris Brezillon
On Mon, 19 Sep 2016 09:38:34 -0700 Doug Anderson wrote: > Hi, > > On Mon, Sep 19, 2016 at 9:15 AM, Heiko Stuebner wrote: > > Am Montag, 19. September 2016, 08:15:30 CEST schrieb Doug Anderson: > >> Hi, > >> > >> On Mon, Sep 19, 2016 at 1:44 AM, Andy Yan wrote: > >> > >> > The current

Re: [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization

2016-09-19 Thread Doug Anderson
Hi, On Mon, Sep 19, 2016 at 10:13 AM, Boris Brezillon wrote: > Correct me if I'm wrong, but the main problem here is that, when we try > to detect the initial regulator state, we ran into a "missing entry in > the duty-cycle <-> voltage table" error, which

Re: [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization

2016-09-19 Thread Doug Anderson
Hi, On Mon, Sep 19, 2016 at 10:13 AM, Boris Brezillon wrote: > Correct me if I'm wrong, but the main problem here is that, when we try > to detect the initial regulator state, we ran into a "missing entry in > the duty-cycle <-> voltage table" error, which then triggers an -EINVAL > error

Re: [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization

2016-09-19 Thread Doug Anderson
Hi, On Mon, Sep 19, 2016 at 9:15 AM, Heiko Stuebner wrote: > Am Montag, 19. September 2016, 08:15:30 CEST schrieb Doug Anderson: >> Hi, >> >> On Mon, Sep 19, 2016 at 1:44 AM, Andy Yan wrote: >> > The current rk3066a based boards(Rayeager, Bqcurie2,

Re: [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization

2016-09-19 Thread Doug Anderson
Hi, On Mon, Sep 19, 2016 at 9:15 AM, Heiko Stuebner wrote: > Am Montag, 19. September 2016, 08:15:30 CEST schrieb Doug Anderson: >> Hi, >> >> On Mon, Sep 19, 2016 at 1:44 AM, Andy Yan wrote: >> > The current rk3066a based boards(Rayeager, Bqcurie2, Marsboard) use >> > pwm modulate vdd_logic

Re: [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization

2016-09-19 Thread Heiko Stuebner
Am Montag, 19. September 2016, 08:15:30 CEST schrieb Doug Anderson: > Hi, > > On Mon, Sep 19, 2016 at 1:44 AM, Andy Yan wrote: > > The current rk3066a based boards(Rayeager, Bqcurie2, Marsboard) use > > pwm modulate vdd_logic voltage, but the pwm is default disabled and

Re: [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization

2016-09-19 Thread Heiko Stuebner
Am Montag, 19. September 2016, 08:15:30 CEST schrieb Doug Anderson: > Hi, > > On Mon, Sep 19, 2016 at 1:44 AM, Andy Yan wrote: > > The current rk3066a based boards(Rayeager, Bqcurie2, Marsboard) use > > pwm modulate vdd_logic voltage, but the pwm is default disabled and > > the pwm pin acts as a

Re: [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization

2016-09-19 Thread Doug Anderson
Hi, On Mon, Sep 19, 2016 at 1:44 AM, Andy Yan wrote: > The current rk3066a based boards(Rayeager, Bqcurie2, Marsboard) use > pwm modulate vdd_logic voltage, but the pwm is default disabled and > the pwm pin acts as a gpio before pwm regulator probed, so the pwm >

Re: [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization

2016-09-19 Thread Doug Anderson
Hi, On Mon, Sep 19, 2016 at 1:44 AM, Andy Yan wrote: > The current rk3066a based boards(Rayeager, Bqcurie2, Marsboard) use > pwm modulate vdd_logic voltage, but the pwm is default disabled and > the pwm pin acts as a gpio before pwm regulator probed, so the pwm > regulator driver will get a zero

Re: [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization

2016-09-19 Thread Boris Brezillon
On Mon, 19 Sep 2016 17:38:10 +0800 Andy Yan wrote: > On 2016年09月19日 17:25, Boris Brezillon wrote: > > On Mon, 19 Sep 2016 16:44:56 +0800 > > Andy Yan wrote: > > > >> The current rk3066a based boards(Rayeager, Bqcurie2, Marsboard) use > >> pwm

Re: [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization

2016-09-19 Thread Boris Brezillon
On Mon, 19 Sep 2016 17:38:10 +0800 Andy Yan wrote: > On 2016年09月19日 17:25, Boris Brezillon wrote: > > On Mon, 19 Sep 2016 16:44:56 +0800 > > Andy Yan wrote: > > > >> The current rk3066a based boards(Rayeager, Bqcurie2, Marsboard) use > >> pwm modulate vdd_logic voltage, but the pwm is default

Re: [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization

2016-09-19 Thread Andy Yan
On 2016年09月19日 17:25, Boris Brezillon wrote: On Mon, 19 Sep 2016 16:44:56 +0800 Andy Yan wrote: The current rk3066a based boards(Rayeager, Bqcurie2, Marsboard) use pwm modulate vdd_logic voltage, but the pwm is default disabled and the pwm pin acts as a gpio before

Re: [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization

2016-09-19 Thread Andy Yan
On 2016年09月19日 17:25, Boris Brezillon wrote: On Mon, 19 Sep 2016 16:44:56 +0800 Andy Yan wrote: The current rk3066a based boards(Rayeager, Bqcurie2, Marsboard) use pwm modulate vdd_logic voltage, but the pwm is default disabled and the pwm pin acts as a gpio before pwm regulator probed, so

Re: [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization

2016-09-19 Thread Boris Brezillon
On Mon, 19 Sep 2016 16:44:56 +0800 Andy Yan wrote: > The current rk3066a based boards(Rayeager, Bqcurie2, Marsboard) use > pwm modulate vdd_logic voltage, but the pwm is default disabled and > the pwm pin acts as a gpio before pwm regulator probed, so the pwm > regulator

Re: [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization

2016-09-19 Thread Boris Brezillon
On Mon, 19 Sep 2016 16:44:56 +0800 Andy Yan wrote: > The current rk3066a based boards(Rayeager, Bqcurie2, Marsboard) use > pwm modulate vdd_logic voltage, but the pwm is default disabled and > the pwm pin acts as a gpio before pwm regulator probed, so the pwm > regulator driver will get a zero