Re: [PATCH] cpufreq, Fix overflow in busy_scaled due to long delay [v2]

2015-06-16 Thread Rafael J. Wysocki
On Monday, June 15, 2015 07:33:03 PM Prarit Bhargava wrote: > > On 06/15/2015 06:12 PM, Kristen Carlson Accardi wrote: > > On Mon, 15 Jun 2015 13:43:29 -0400 > > Prarit Bhargava wrote: > > > >> The kernel may delay interrupts for a long time which can result in timers > >> being delayed. If this

Re: [PATCH] cpufreq, Fix overflow in busy_scaled due to long delay [v2]

2015-06-16 Thread Rafael J. Wysocki
On Tuesday, June 16, 2015 11:35:10 PM Rafael J. Wysocki wrote: > On Monday, June 15, 2015 07:33:03 PM Prarit Bhargava wrote: > > > > On 06/15/2015 06:12 PM, Kristen Carlson Accardi wrote: > > > On Mon, 15 Jun 2015 13:43:29 -0400 > > > Prarit Bhargava wrote: > > > > > >> The kernel may delay inte

Re: [PATCH] cpufreq, Fix overflow in busy_scaled due to long delay [v2]

2015-06-15 Thread Prarit Bhargava
On 06/15/2015 06:12 PM, Kristen Carlson Accardi wrote: > On Mon, 15 Jun 2015 13:43:29 -0400 > Prarit Bhargava wrote: > >> The kernel may delay interrupts for a long time which can result in timers >> being delayed. If this occurs the intel_pstate driver will crash with a >> divide by zero error

Re: [PATCH] cpufreq, Fix overflow in busy_scaled due to long delay [v2]

2015-06-15 Thread Kristen Carlson Accardi
On Mon, 15 Jun 2015 13:43:29 -0400 Prarit Bhargava wrote: > The kernel may delay interrupts for a long time which can result in timers > being delayed. If this occurs the intel_pstate driver will crash with a > divide by zero error: > > divide error: [#1] SMP > Modules linked in: btrfs zlib

Re: [PATCH] cpufreq, Fix overflow in busy_scaled due to long delay

2015-06-11 Thread Prarit Bhargava
On 06/11/2015 12:17 PM, Doug Smythies wrote: > > On 2015.06.11 08:01 Prarit Bhargava wrote: >> On 06/11/2015 10:51 AM, Doug Smythies wrote: >>> >>> On 2015.06.10 16:46 Rafael J. Wysocki wrote: On Wednesday, June 10, 2015 09:18:45 AM Prarit Bhargava wrote: > I looked into switching to di

RE: [PATCH] cpufreq, Fix overflow in busy_scaled due to long delay

2015-06-11 Thread Doug Smythies
On 2015.06.11 08:01 Prarit Bhargava wrote: > On 06/11/2015 10:51 AM, Doug Smythies wrote: >> >> On 2015.06.10 16:46 Rafael J. Wysocki wrote: >>> On Wednesday, June 10, 2015 09:18:45 AM Prarit Bhargava wrote: I looked into switching to div64_s64() instead of the 32-bit version in div_fp(

Re: [PATCH] cpufreq, Fix overflow in busy_scaled due to long delay

2015-06-11 Thread Prarit Bhargava
On 06/11/2015 10:51 AM, Doug Smythies wrote: > > On 2015.06.10 16:46 Rafael J. Wysocki wrote: >> On Wednesday, June 10, 2015 09:18:45 AM Prarit Bhargava wrote: >>> I looked into switching to div64_s64() instead of the 32-bit version in >>> div_fp(), however, this would result in sample_ratio and

Re: [PATCH] cpufreq, Fix overflow in busy_scaled due to long delay

2015-06-11 Thread Prarit Bhargava
On 06/11/2015 10:51 AM, Doug Smythies wrote: > > On 2015.06.10 16:46 Rafael J. Wysocki wrote: >> On Wednesday, June 10, 2015 09:18:45 AM Prarit Bhargava wrote: >>> I looked into switching to div64_s64() instead of the 32-bit version in >>> div_fp(), however, this would result in sample_ratio and

RE: [PATCH] cpufreq, Fix overflow in busy_scaled due to long delay

2015-06-11 Thread Doug Smythies
On 2015.06.10 16:46 Rafael J. Wysocki wrote: > On Wednesday, June 10, 2015 09:18:45 AM Prarit Bhargava wrote: >> I looked into switching to div64_s64() instead of the 32-bit version in >> div_fp(), however, this would result in sample_ratio and core_busy returning >> 0 which is something we don't

Re: [PATCH] cpufreq, Fix overflow in busy_scaled due to long delay

2015-06-10 Thread Rafael J. Wysocki
On Wednesday, June 10, 2015 09:18:45 AM Prarit Bhargava wrote: > I looked into switching to div64_s64() instead of the 32-bit version in > div_fp(), however, this would result in sample_ratio and core_busy returning > 0 which is something we don't want. > > P. > > ---8<--- > > The kernel may del