Re: [PATCH] drivers:net:hamradio: Removing Depricated IRQF_DISABLED

2013-08-10 Thread Kumar Gaurav
On Sunday 11 August 2013 12:19 AM, walter harms wrote: Hello Kumar, i will try to resolve the riddle ... doing something like fn(a,b,c,0) is a bad habit. 0 is called a "magic number" because noone reading the code has an idea why it is there. Using the name IRQF_TRIGGER_NONE good. Having a

Re: [PATCH] drivers:net:hamradio: Removing Depricated IRQF_DISABLED

2013-08-10 Thread walter harms
Hello Kumar, i will try to resolve the riddle ... doing something like fn(a,b,c,0) is a bad habit. 0 is called a "magic number" because noone reading the code has an idea why it is there. Using the name IRQF_TRIGGER_NONE good. Having a named bit like IRQ_TRIGGER|IRQ_NMI is most times also a good

Re: [PATCH] drivers:net:hamradio: Removing Depricated IRQF_DISABLED

2013-08-10 Thread Julia Lawall
On Sat, 10 Aug 2013, Kumar Gaurav wrote: > On Saturday 10 August 2013 10:54 PM, Julia Lawall wrote: > > On Sat, 10 Aug 2013, Kumar Gaurav wrote: > > > > > On Saturday 10 August 2013 10:17 PM, Julia Lawall wrote: > > > > If it is in a | with something else, I think you can just remove it. > > > >

Re: [PATCH] drivers:net:hamradio: Removing Depricated IRQF_DISABLED

2013-08-10 Thread Kumar Gaurav
On Saturday 10 August 2013 10:54 PM, Julia Lawall wrote: On Sat, 10 Aug 2013, Kumar Gaurav wrote: On Saturday 10 August 2013 10:17 PM, Julia Lawall wrote: If it is in a | with something else, I think you can just remove it. julia On Sat, 10 Aug 2013, Kumar Gaurav wrote: Removed

Re: [PATCH] drivers:net:hamradio: Removing Depricated IRQF_DISABLED

2013-08-10 Thread Julia Lawall
On Sat, 10 Aug 2013, Kumar Gaurav wrote: > On Saturday 10 August 2013 10:17 PM, Julia Lawall wrote: > > If it is in a | with something else, I think you can just remove it. > > > > julia > > > > On Sat, 10 Aug 2013, Kumar Gaurav wrote: > > > > > Removed IRQF_DISABLED as it's deprecated and

Re: [PATCH] drivers:net:hamradio: Removing Depricated IRQF_DISABLED

2013-08-10 Thread Kumar Gaurav
On Saturday 10 August 2013 10:17 PM, Julia Lawall wrote: If it is in a | with something else, I think you can just remove it. julia On Sat, 10 Aug 2013, Kumar Gaurav wrote: Removed IRQF_DISABLED as it's deprecated and should be removed Signed-off-by: Kumar Gaurav ---

Re: [PATCH] drivers:net:hamradio: Removing Depricated IRQF_DISABLED

2013-08-10 Thread Julia Lawall
If it is in a | with something else, I think you can just remove it. julia On Sat, 10 Aug 2013, Kumar Gaurav wrote: > Removed IRQF_DISABLED as it's deprecated and should be removed > > Signed-off-by: Kumar Gaurav > --- > drivers/net/hamradio/baycom_ser_fdx.c |2 +- >

Re: [PATCH] drivers:net:hamradio: Removing Depricated IRQF_DISABLED

2013-08-10 Thread Julia Lawall
If it is in a | with something else, I think you can just remove it. julia On Sat, 10 Aug 2013, Kumar Gaurav wrote: Removed IRQF_DISABLED as it's deprecated and should be removed Signed-off-by: Kumar Gaurav kumargauravgup...@gmail.com --- drivers/net/hamradio/baycom_ser_fdx.c |2 +-

Re: [PATCH] drivers:net:hamradio: Removing Depricated IRQF_DISABLED

2013-08-10 Thread Kumar Gaurav
On Saturday 10 August 2013 10:17 PM, Julia Lawall wrote: If it is in a | with something else, I think you can just remove it. julia On Sat, 10 Aug 2013, Kumar Gaurav wrote: Removed IRQF_DISABLED as it's deprecated and should be removed Signed-off-by: Kumar Gaurav kumargauravgup...@gmail.com

Re: [PATCH] drivers:net:hamradio: Removing Depricated IRQF_DISABLED

2013-08-10 Thread Julia Lawall
On Sat, 10 Aug 2013, Kumar Gaurav wrote: On Saturday 10 August 2013 10:17 PM, Julia Lawall wrote: If it is in a | with something else, I think you can just remove it. julia On Sat, 10 Aug 2013, Kumar Gaurav wrote: Removed IRQF_DISABLED as it's deprecated and should be removed

Re: [PATCH] drivers:net:hamradio: Removing Depricated IRQF_DISABLED

2013-08-10 Thread Kumar Gaurav
On Saturday 10 August 2013 10:54 PM, Julia Lawall wrote: On Sat, 10 Aug 2013, Kumar Gaurav wrote: On Saturday 10 August 2013 10:17 PM, Julia Lawall wrote: If it is in a | with something else, I think you can just remove it. julia On Sat, 10 Aug 2013, Kumar Gaurav wrote: Removed

Re: [PATCH] drivers:net:hamradio: Removing Depricated IRQF_DISABLED

2013-08-10 Thread Julia Lawall
On Sat, 10 Aug 2013, Kumar Gaurav wrote: On Saturday 10 August 2013 10:54 PM, Julia Lawall wrote: On Sat, 10 Aug 2013, Kumar Gaurav wrote: On Saturday 10 August 2013 10:17 PM, Julia Lawall wrote: If it is in a | with something else, I think you can just remove it. julia

Re: [PATCH] drivers:net:hamradio: Removing Depricated IRQF_DISABLED

2013-08-10 Thread walter harms
Hello Kumar, i will try to resolve the riddle ... doing something like fn(a,b,c,0) is a bad habit. 0 is called a magic number because noone reading the code has an idea why it is there. Using the name IRQF_TRIGGER_NONE good. Having a named bit like IRQ_TRIGGER|IRQ_NMI is most times also a good

Re: [PATCH] drivers:net:hamradio: Removing Depricated IRQF_DISABLED

2013-08-10 Thread Kumar Gaurav
On Sunday 11 August 2013 12:19 AM, walter harms wrote: Hello Kumar, i will try to resolve the riddle ... doing something like fn(a,b,c,0) is a bad habit. 0 is called a magic number because noone reading the code has an idea why it is there. Using the name IRQF_TRIGGER_NONE good. Having a named