Re: [PATCH] fb: Rework locking to fix lock ordering on takeover

2013-01-15 Thread Alan Cox
> Just tested this patch on a macbook pro with i915 and radeon. First I get a > nasty lockdep splat, then it locks up completely: > > [ 13.507373] fb: conflicting fb hw usage radeondrmfb vs EFI VGA - removing > generic driver The EFI driver is known to need other work of its own. Alan -- To

Re: [PATCH] fb: Rework locking to fix lock ordering on takeover

2013-01-15 Thread Maarten Lankhorst
Hey, Op 13-01-13 01:02, Borislav Petkov schreef: > On Sat, Jan 12, 2013 at 01:13:23PM -0800, Andrew Morton wrote: >> Florian has been taking a month or two's downtime (now expired, I >> think) so I've been waiting for him to reappear to process this one for >> 3.8. >> >> Meanwhile, I guess we

Re: [PATCH] fb: Rework locking to fix lock ordering on takeover

2013-01-15 Thread Maarten Lankhorst
Hey, Op 13-01-13 01:02, Borislav Petkov schreef: On Sat, Jan 12, 2013 at 01:13:23PM -0800, Andrew Morton wrote: Florian has been taking a month or two's downtime (now expired, I think) so I've been waiting for him to reappear to process this one for 3.8. Meanwhile, I guess we could put it

Re: [PATCH] fb: Rework locking to fix lock ordering on takeover

2013-01-15 Thread Alan Cox
Just tested this patch on a macbook pro with i915 and radeon. First I get a nasty lockdep splat, then it locks up completely: [ 13.507373] fb: conflicting fb hw usage radeondrmfb vs EFI VGA - removing generic driver The EFI driver is known to need other work of its own. Alan -- To

Re: [PATCH] fb: Rework locking to fix lock ordering on takeover

2013-01-12 Thread Borislav Petkov
On Sat, Jan 12, 2013 at 01:13:23PM -0800, Andrew Morton wrote: > Florian has been taking a month or two's downtime (now expired, I > think) so I've been waiting for him to reappear to process this one for > 3.8. > > Meanwhile, I guess we could put it into mainline ;) It has been in > -next for a

Re: [PATCH] fb: Rework locking to fix lock ordering on takeover

2013-01-12 Thread Andrew Morton
On Sat, 12 Jan 2013 12:51:49 -0800 Linus Torvalds wrote: > On Sat, Jan 12, 2013 at 10:36 AM, Borislav Petkov wrote: > > On Mon, Jan 07, 2013 at 10:37:15AM +0100, Jiri Kosina wrote: > >> Still seeing it with current Linus' tree. > >> > >> Tested-by: Jiri Kosina > >> > >> Anyone

Re: [PATCH] fb: Rework locking to fix lock ordering on takeover

2013-01-12 Thread Alan Cox
Alan is dealing with family stuff that is far more important. Someone who has the time needs to own this and the fb layer. Not a don't care - a don't have time. Alan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org

Re: [PATCH] fb: Rework locking to fix lock ordering on takeover

2013-01-12 Thread Linus Torvalds
On Sat, Jan 12, 2013 at 10:36 AM, Borislav Petkov wrote: > On Mon, Jan 07, 2013 at 10:37:15AM +0100, Jiri Kosina wrote: >> Still seeing it with current Linus' tree. >> >> Tested-by: Jiri Kosina >> >> Anyone applying this, please? > > Yeah, I'm still seeing it in -rc3. Linus, can you pick

Re: [PATCH] fb: Rework locking to fix lock ordering on takeover

2013-01-12 Thread Borislav Petkov
On Mon, Jan 07, 2013 at 10:37:15AM +0100, Jiri Kosina wrote: > Still seeing it with current Linus' tree. > > Tested-by: Jiri Kosina > > Anyone applying this, please? Yeah, I'm still seeing it in -rc3. Linus, can you pick up Alan's patch from

Re: [PATCH] fb: Rework locking to fix lock ordering on takeover

2013-01-12 Thread Borislav Petkov
On Mon, Jan 07, 2013 at 10:37:15AM +0100, Jiri Kosina wrote: Still seeing it with current Linus' tree. Tested-by: Jiri Kosina jkos...@suse.cz Anyone applying this, please? Yeah, I'm still seeing it in -rc3. Linus, can you pick up Alan's patch from

Re: [PATCH] fb: Rework locking to fix lock ordering on takeover

2013-01-12 Thread Linus Torvalds
On Sat, Jan 12, 2013 at 10:36 AM, Borislav Petkov b...@alien8.de wrote: On Mon, Jan 07, 2013 at 10:37:15AM +0100, Jiri Kosina wrote: Still seeing it with current Linus' tree. Tested-by: Jiri Kosina jkos...@suse.cz Anyone applying this, please? Yeah, I'm still seeing it in -rc3.

Re: [PATCH] fb: Rework locking to fix lock ordering on takeover

2013-01-12 Thread Alan Cox
Alan is dealing with family stuff that is far more important. Someone who has the time needs to own this and the fb layer. Not a don't care - a don't have time. Alan -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org

Re: [PATCH] fb: Rework locking to fix lock ordering on takeover

2013-01-12 Thread Andrew Morton
On Sat, 12 Jan 2013 12:51:49 -0800 Linus Torvalds torva...@linux-foundation.org wrote: On Sat, Jan 12, 2013 at 10:36 AM, Borislav Petkov b...@alien8.de wrote: On Mon, Jan 07, 2013 at 10:37:15AM +0100, Jiri Kosina wrote: Still seeing it with current Linus' tree. Tested-by: Jiri

Re: [PATCH] fb: Rework locking to fix lock ordering on takeover

2013-01-12 Thread Borislav Petkov
On Sat, Jan 12, 2013 at 01:13:23PM -0800, Andrew Morton wrote: Florian has been taking a month or two's downtime (now expired, I think) so I've been waiting for him to reappear to process this one for 3.8. Meanwhile, I guess we could put it into mainline ;) It has been in -next for a month.

Re: [PATCH] fb: Rework locking to fix lock ordering on takeover

2013-01-07 Thread Jiri Kosina
On Fri, 28 Dec 2012, Borislav Petkov wrote: > > http://thread.gmane.org/gmane.linux.kernel/1413953/focus=1415070 > > Cool, works fine here too. Is Linus on CC? (/me checks.. ) Yes he is, > good. > > Linus, Alan's patch works at least in 2 cases, you might consider > picking it up directly since

Re: [PATCH] fb: Rework locking to fix lock ordering on takeover

2013-01-07 Thread Jiri Kosina
On Fri, 28 Dec 2012, Borislav Petkov wrote: http://thread.gmane.org/gmane.linux.kernel/1413953/focus=1415070 Cool, works fine here too. Is Linus on CC? (/me checks.. ) Yes he is, good. Linus, Alan's patch works at least in 2 cases, you might consider picking it up directly since the fb

Re: [PATCH] fb: Rework locking to fix lock ordering on takeover

2013-01-05 Thread Alexander Holler
Am 05.01.2013 13:07, schrieb Alan Cox: So to add such an "I am crap" flag my idea would be to add an .fb_handle_damage to struct fb_ops and then call that (if exists) whenever something was changed. I was thinking much higher level - ie at the printk kind of level My patch (for udlfb)

Re: [PATCH] fb: Rework locking to fix lock ordering on takeover

2013-01-05 Thread Alan Cox
> So to add such an "I am crap" flag my idea would be to add an > .fb_handle_damage to struct fb_ops and then call that (if exists) > whenever something was changed. I was thinking much higher level - ie at the printk kind of level > My patch (for udlfb) follows as an reply to this message. If

Re: [PATCH] fb: Rework locking to fix lock ordering on takeover

2013-01-05 Thread Alexander Holler
Am 04.01.2013 14:36, schrieb Alexander Holler: Am 04.01.2013 14:25, schrieb Alan Cox: On Fri, 04 Jan 2013 13:50:37 +0100 Alexander Holler wrote: ... Btw. I think all the usb-fb's (udlfb, smscufx and udl) are broken, at least on ARM(v5). When I have linked in udlfb the following happens on

Re: [PATCH] fb: Rework locking to fix lock ordering on takeover

2013-01-05 Thread Alexander Holler
Am 04.01.2013 14:36, schrieb Alexander Holler: Am 04.01.2013 14:25, schrieb Alan Cox: On Fri, 04 Jan 2013 13:50:37 +0100 Alexander Holler hol...@ahsoftware.de wrote: ... Btw. I think all the usb-fb's (udlfb, smscufx and udl) are broken, at least on ARM(v5). When I have linked in udlfb the

Re: [PATCH] fb: Rework locking to fix lock ordering on takeover

2013-01-05 Thread Alan Cox
So to add such an I am crap flag my idea would be to add an .fb_handle_damage to struct fb_ops and then call that (if exists) whenever something was changed. I was thinking much higher level - ie at the printk kind of level My patch (for udlfb) follows as an reply to this message. If that

Re: [PATCH] fb: Rework locking to fix lock ordering on takeover

2013-01-05 Thread Alexander Holler
Am 05.01.2013 13:07, schrieb Alan Cox: So to add such an I am crap flag my idea would be to add an .fb_handle_damage to struct fb_ops and then call that (if exists) whenever something was changed. I was thinking much higher level - ie at the printk kind of level My patch (for udlfb) follows

Re: [PATCH] fb: Rework locking to fix lock ordering on takeover

2013-01-04 Thread Alexander Holler
Am 04.01.2013 14:25, schrieb Alan Cox: On Fri, 04 Jan 2013 13:50:37 +0100 Alexander Holler wrote: Am 28.12.2012 13:40, schrieb Borislav Petkov: On Fri, Dec 28, 2012 at 07:50:27PM +0800, Shawn Guo wrote: +1 http://thread.gmane.org/gmane.linux.kernel/1413953/focus=1415070 Cool, works fine

Re: [PATCH] fb: Rework locking to fix lock ordering on takeover

2013-01-04 Thread Alan Cox
On Fri, 04 Jan 2013 13:50:37 +0100 Alexander Holler wrote: > Am 28.12.2012 13:40, schrieb Borislav Petkov: > > On Fri, Dec 28, 2012 at 07:50:27PM +0800, Shawn Guo wrote: > >> +1 > >> > >> http://thread.gmane.org/gmane.linux.kernel/1413953/focus=1415070 > > > > Cool, works fine here too. Is Linus

Re: [PATCH] fb: Rework locking to fix lock ordering on takeover

2013-01-04 Thread Alexander Holler
Am 28.12.2012 13:40, schrieb Borislav Petkov: On Fri, Dec 28, 2012 at 07:50:27PM +0800, Shawn Guo wrote: +1 http://thread.gmane.org/gmane.linux.kernel/1413953/focus=1415070 Cool, works fine here too. Is Linus on CC? (/me checks.. ) Yes he is, good. Linus, Alan's patch works at least in 2

Re: [PATCH] fb: Rework locking to fix lock ordering on takeover

2013-01-04 Thread Alexander Holler
Am 28.12.2012 13:40, schrieb Borislav Petkov: On Fri, Dec 28, 2012 at 07:50:27PM +0800, Shawn Guo wrote: +1 http://thread.gmane.org/gmane.linux.kernel/1413953/focus=1415070 Cool, works fine here too. Is Linus on CC? (/me checks.. ) Yes he is, good. Linus, Alan's patch works at least in 2

Re: [PATCH] fb: Rework locking to fix lock ordering on takeover

2013-01-04 Thread Alan Cox
On Fri, 04 Jan 2013 13:50:37 +0100 Alexander Holler hol...@ahsoftware.de wrote: Am 28.12.2012 13:40, schrieb Borislav Petkov: On Fri, Dec 28, 2012 at 07:50:27PM +0800, Shawn Guo wrote: +1 http://thread.gmane.org/gmane.linux.kernel/1413953/focus=1415070 Cool, works fine here too. Is

Re: [PATCH] fb: Rework locking to fix lock ordering on takeover

2013-01-04 Thread Alexander Holler
Am 04.01.2013 14:25, schrieb Alan Cox: On Fri, 04 Jan 2013 13:50:37 +0100 Alexander Holler hol...@ahsoftware.de wrote: Am 28.12.2012 13:40, schrieb Borislav Petkov: On Fri, Dec 28, 2012 at 07:50:27PM +0800, Shawn Guo wrote: +1 http://thread.gmane.org/gmane.linux.kernel/1413953/focus=1415070

Re: [PATCH] fb: Rework locking to fix lock ordering on takeover

2012-12-28 Thread Borislav Petkov
On Fri, Dec 28, 2012 at 07:50:27PM +0800, Shawn Guo wrote: > +1 > > http://thread.gmane.org/gmane.linux.kernel/1413953/focus=1415070 Cool, works fine here too. Is Linus on CC? (/me checks.. ) Yes he is, good. Linus, Alan's patch works at least in 2 cases, you might consider picking it up

Re: [PATCH] fb: Rework locking to fix lock ordering on takeover

2012-12-28 Thread Shawn Guo
On Thu, Dec 27, 2012 at 05:53:01AM +0100, Borislav Petkov wrote: > On Wed, Dec 26, 2012 at 01:09:51PM -0500, Sasha Levin wrote: > > > This patch can fix the following warning we saw? > > > http://lkml.org/lkml/2012/12/22/53 > > > > > > I will give it a try. > > > > Yup, that's the same error I've

Re: [PATCH] fb: Rework locking to fix lock ordering on takeover

2012-12-28 Thread Shawn Guo
On Thu, Dec 27, 2012 at 05:53:01AM +0100, Borislav Petkov wrote: On Wed, Dec 26, 2012 at 01:09:51PM -0500, Sasha Levin wrote: This patch can fix the following warning we saw? http://lkml.org/lkml/2012/12/22/53 I will give it a try. Yup, that's the same error I've reported couple

Re: [PATCH] fb: Rework locking to fix lock ordering on takeover

2012-12-28 Thread Borislav Petkov
On Fri, Dec 28, 2012 at 07:50:27PM +0800, Shawn Guo wrote: +1 http://thread.gmane.org/gmane.linux.kernel/1413953/focus=1415070 Cool, works fine here too. Is Linus on CC? (/me checks.. ) Yes he is, good. Linus, Alan's patch works at least in 2 cases, you might consider picking it up directly

Re: [PATCH] fb: Rework locking to fix lock ordering on takeover

2012-12-26 Thread Borislav Petkov
On Wed, Dec 26, 2012 at 01:09:51PM -0500, Sasha Levin wrote: > > This patch can fix the following warning we saw? > > http://lkml.org/lkml/2012/12/22/53 > > > > I will give it a try. > > Yup, that's the same error I've reported couple of months ago. > > It looks like the fb maintains are still

Re: [PATCH] fb: Rework locking to fix lock ordering on takeover

2012-12-26 Thread Sasha Levin
On Tue, Dec 25, 2012 at 9:41 PM, Cong Wang wrote: > On Wed, Dec 26, 2012 at 12:08 AM, Sasha Levin wrote: >> On Tue, Dec 18, 2012 at 10:20 AM, Josh Boyer wrote: >>> On Wed, Nov 21, 2012 at 7:53 AM, Alan Cox wrote: On Wed, 21 Nov 2012 07:45:45 -0500 Josh Boyer wrote: > On

Re: [PATCH] fb: Rework locking to fix lock ordering on takeover

2012-12-26 Thread Sasha Levin
On Tue, Dec 25, 2012 at 9:41 PM, Cong Wang xiyou.wangc...@gmail.com wrote: On Wed, Dec 26, 2012 at 12:08 AM, Sasha Levin levinsasha...@gmail.com wrote: On Tue, Dec 18, 2012 at 10:20 AM, Josh Boyer jwbo...@gmail.com wrote: On Wed, Nov 21, 2012 at 7:53 AM, Alan Cox a...@lxorguk.ukuu.org.uk wrote:

Re: [PATCH] fb: Rework locking to fix lock ordering on takeover

2012-12-26 Thread Borislav Petkov
On Wed, Dec 26, 2012 at 01:09:51PM -0500, Sasha Levin wrote: This patch can fix the following warning we saw? http://lkml.org/lkml/2012/12/22/53 I will give it a try. Yup, that's the same error I've reported couple of months ago. It looks like the fb maintains are still absent, so

Re: [PATCH] fb: Rework locking to fix lock ordering on takeover

2012-12-25 Thread Cong Wang
On Wed, Dec 26, 2012 at 12:08 AM, Sasha Levin wrote: > On Tue, Dec 18, 2012 at 10:20 AM, Josh Boyer wrote: >> On Wed, Nov 21, 2012 at 7:53 AM, Alan Cox wrote: >>> On Wed, 21 Nov 2012 07:45:45 -0500 >>> Josh Boyer wrote: >>> On Fri, Nov 16, 2012 at 2:27 PM, Alan Cox wrote: > >

Re: [PATCH] fb: Rework locking to fix lock ordering on takeover

2012-12-25 Thread Sasha Levin
On Tue, Dec 18, 2012 at 10:20 AM, Josh Boyer wrote: > On Wed, Nov 21, 2012 at 7:53 AM, Alan Cox wrote: >> On Wed, 21 Nov 2012 07:45:45 -0500 >> Josh Boyer wrote: >> >>> On Fri, Nov 16, 2012 at 2:27 PM, Alan Cox wrote: >>> > >>> > [The fb maintainer appears to be absent at the moment]. >>> >

Re: [PATCH] fb: Rework locking to fix lock ordering on takeover

2012-12-25 Thread Sasha Levin
On Tue, Dec 18, 2012 at 10:20 AM, Josh Boyer jwbo...@gmail.com wrote: On Wed, Nov 21, 2012 at 7:53 AM, Alan Cox a...@lxorguk.ukuu.org.uk wrote: On Wed, 21 Nov 2012 07:45:45 -0500 Josh Boyer jwbo...@gmail.com wrote: On Fri, Nov 16, 2012 at 2:27 PM, Alan Cox a...@lxorguk.ukuu.org.uk wrote:

Re: [PATCH] fb: Rework locking to fix lock ordering on takeover

2012-12-25 Thread Cong Wang
On Wed, Dec 26, 2012 at 12:08 AM, Sasha Levin levinsasha...@gmail.com wrote: On Tue, Dec 18, 2012 at 10:20 AM, Josh Boyer jwbo...@gmail.com wrote: On Wed, Nov 21, 2012 at 7:53 AM, Alan Cox a...@lxorguk.ukuu.org.uk wrote: On Wed, 21 Nov 2012 07:45:45 -0500 Josh Boyer jwbo...@gmail.com wrote:

Re: [PATCH] fb: Rework locking to fix lock ordering on takeover

2012-12-18 Thread Josh Boyer
On Wed, Nov 21, 2012 at 7:53 AM, Alan Cox wrote: > On Wed, 21 Nov 2012 07:45:45 -0500 > Josh Boyer wrote: > >> On Fri, Nov 16, 2012 at 2:27 PM, Alan Cox wrote: >> > >> > [The fb maintainer appears to be absent at the moment]. >> > >> > This is needed to fix a pile of lockdep splats that now

Re: [PATCH] fb: Rework locking to fix lock ordering on takeover

2012-12-18 Thread Josh Boyer
On Wed, Nov 21, 2012 at 7:53 AM, Alan Cox a...@lxorguk.ukuu.org.uk wrote: On Wed, 21 Nov 2012 07:45:45 -0500 Josh Boyer jwbo...@gmail.com wrote: On Fri, Nov 16, 2012 at 2:27 PM, Alan Cox a...@lxorguk.ukuu.org.uk wrote: [The fb maintainer appears to be absent at the moment]. This is

Re: [PATCH] fb: Rework locking to fix lock ordering on takeover

2012-11-21 Thread Alan Cox
On Wed, 21 Nov 2012 07:45:45 -0500 Josh Boyer wrote: > On Fri, Nov 16, 2012 at 2:27 PM, Alan Cox wrote: > > > > [The fb maintainer appears to be absent at the moment]. > > > > This is needed to fix a pile of lockdep splats that now show up because > > console_lock() > > is being properly

Re: [PATCH] fb: Rework locking to fix lock ordering on takeover

2012-11-21 Thread Josh Boyer
On Fri, Nov 16, 2012 at 2:27 PM, Alan Cox wrote: > > [The fb maintainer appears to be absent at the moment]. > > This is needed to fix a pile of lockdep splats that now show up because > console_lock() > is being properly audited. Hugh Dickins and Sasha Levin have tested it and > both reports >

Re: [PATCH] fb: Rework locking to fix lock ordering on takeover

2012-11-21 Thread Josh Boyer
On Fri, Nov 16, 2012 at 2:27 PM, Alan Cox a...@lxorguk.ukuu.org.uk wrote: [The fb maintainer appears to be absent at the moment]. This is needed to fix a pile of lockdep splats that now show up because console_lock() is being properly audited. Hugh Dickins and Sasha Levin have tested it and

Re: [PATCH] fb: Rework locking to fix lock ordering on takeover

2012-11-21 Thread Alan Cox
On Wed, 21 Nov 2012 07:45:45 -0500 Josh Boyer jwbo...@gmail.com wrote: On Fri, Nov 16, 2012 at 2:27 PM, Alan Cox a...@lxorguk.ukuu.org.uk wrote: [The fb maintainer appears to be absent at the moment]. This is needed to fix a pile of lockdep splats that now show up because