Re: [PATCH] genirq / PM: Add flag for shared NO_SUSPEND interrupt lines

2015-03-04 Thread Rafael J. Wysocki
On Wednesday, March 04, 2015 07:42:46 PM Mark Rutland wrote: > Hi Rafael, > > I'm a little late to the party here, but I have just a couple of minor > comments... > > [...] > > > Link: http://marc.info/?l=linux-kernel=142252777602084=2 > > Link: http://marc.info/?t=142252775300011=1=2 > > Linx:

Re: [PATCH] genirq / PM: Add flag for shared NO_SUSPEND interrupt lines

2015-03-04 Thread Mark Rutland
Hi Rafael, I'm a little late to the party here, but I have just a couple of minor comments... [...] > Link: http://marc.info/?l=linux-kernel=142252777602084=2 > Link: http://marc.info/?t=142252775300011=1=2 > Linx: https://lkml.org/lkml/2014/12/15/552 s/x/k/ ? > Reported-by: Boris Brezillon

Re: [PATCH] genirq / PM: Add flag for shared NO_SUSPEND interrupt lines

2015-03-04 Thread Mark Rutland
Hi Rafael, I'm a little late to the party here, but I have just a couple of minor comments... [...] Link: http://marc.info/?l=linux-kernelm=142252777602084w=2 Link: http://marc.info/?t=142252775300011r=1w=2 Linx: https://lkml.org/lkml/2014/12/15/552 s/x/k/ ? Reported-by: Boris Brezillon

Re: [PATCH] genirq / PM: Add flag for shared NO_SUSPEND interrupt lines

2015-03-04 Thread Rafael J. Wysocki
On Wednesday, March 04, 2015 07:42:46 PM Mark Rutland wrote: Hi Rafael, I'm a little late to the party here, but I have just a couple of minor comments... [...] Link: http://marc.info/?l=linux-kernelm=142252777602084w=2 Link: http://marc.info/?t=142252775300011r=1w=2 Linx:

Re: [PATCH] genirq / PM: Add flag for shared NO_SUSPEND interrupt lines

2015-02-27 Thread Peter Zijlstra
On Fri, Feb 27, 2015 at 11:13:57PM +0100, Rafael J. Wysocki wrote: > On Friday, February 27, 2015 09:38:59 AM Peter Zijlstra wrote: > > Seems good to me. Should I take this through tip/irq ? > > I can apply it along with the previous IRQF_NO_SUSPEND documentation patch > from Mark Rutland if you

Re: [PATCH] genirq / PM: Add flag for shared NO_SUSPEND interrupt lines

2015-02-27 Thread Rafael J. Wysocki
On Friday, February 27, 2015 09:38:59 AM Peter Zijlstra wrote: > On Fri, Feb 27, 2015 at 12:07:55AM +0100, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > It currently is required that all users of NO_SUSPEND interrupt > > lines pass the IRQF_NO_SUSPEND flag when requesting the IRQ

Re: [PATCH] genirq / PM: Add flag for shared NO_SUSPEND interrupt lines

2015-02-27 Thread Peter Zijlstra
On Fri, Feb 27, 2015 at 12:07:55AM +0100, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > It currently is required that all users of NO_SUSPEND interrupt > lines pass the IRQF_NO_SUSPEND flag when requesting the IRQ or the > WARN_ON_ONCE() in irq_pm_install_action() will trigger. That is

Re: [PATCH] genirq / PM: Add flag for shared NO_SUSPEND interrupt lines

2015-02-27 Thread Peter Zijlstra
On Fri, Feb 27, 2015 at 11:13:57PM +0100, Rafael J. Wysocki wrote: On Friday, February 27, 2015 09:38:59 AM Peter Zijlstra wrote: Seems good to me. Should I take this through tip/irq ? I can apply it along with the previous IRQF_NO_SUSPEND documentation patch from Mark Rutland if you ACK

Re: [PATCH] genirq / PM: Add flag for shared NO_SUSPEND interrupt lines

2015-02-27 Thread Rafael J. Wysocki
On Friday, February 27, 2015 09:38:59 AM Peter Zijlstra wrote: On Fri, Feb 27, 2015 at 12:07:55AM +0100, Rafael J. Wysocki wrote: From: Rafael J. Wysocki rafael.j.wyso...@intel.com It currently is required that all users of NO_SUSPEND interrupt lines pass the IRQF_NO_SUSPEND flag when

Re: [PATCH] genirq / PM: Add flag for shared NO_SUSPEND interrupt lines

2015-02-27 Thread Peter Zijlstra
On Fri, Feb 27, 2015 at 12:07:55AM +0100, Rafael J. Wysocki wrote: From: Rafael J. Wysocki rafael.j.wyso...@intel.com It currently is required that all users of NO_SUSPEND interrupt lines pass the IRQF_NO_SUSPEND flag when requesting the IRQ or the WARN_ON_ONCE() in irq_pm_install_action()