Re: [PATCH] i386 !NUMA node_to_cpumask broken in early boot

2005-08-18 Thread Zwane Mwaikambo
On Fri, 19 Aug 2005, Andi Kleen wrote: > > Thanks for the feedback, ugly indeed, i was really trying to avoid adding > > a new API function or extra cpu_* variables. Ok, here is an > > early_node_to_cpumask instead. > > Thinking about it again it's most likely broken with CPU hotplug anyways >

Re: [PATCH] i386 !NUMA node_to_cpumask broken in early boot

2005-08-18 Thread Andi Kleen
> Thanks for the feedback, ugly indeed, i was really trying to avoid adding > a new API function or extra cpu_* variables. Ok, here is an > early_node_to_cpumask instead. Thinking about it again it's most likely broken with CPU hotplug anyways whatever you're doing. So how does your code handle

Re: [PATCH] i386 !NUMA node_to_cpumask broken in early boot

2005-08-18 Thread Zwane Mwaikambo
On Fri, 19 Aug 2005, Andi Kleen wrote: > On Thu, Aug 18, 2005 at 08:07:53PM -0600, Zwane Mwaikambo wrote: > > node_to_cpumask on non NUMA systems is broken if used before all the > > processors have been brought up as it returns cpu_online_map, as opposed > > to NUMA i386 systems which does it

Re: [PATCH] i386 !NUMA node_to_cpumask broken in early boot

2005-08-18 Thread Andi Kleen
On Thu, Aug 18, 2005 at 08:07:53PM -0600, Zwane Mwaikambo wrote: > node_to_cpumask on non NUMA systems is broken if used before all the > processors have been brought up as it returns cpu_online_map, as opposed > to NUMA i386 systems which does it earlier than AP bringup. So return > which

Re: [PATCH] i386 !NUMA node_to_cpumask broken in early boot

2005-08-18 Thread Andi Kleen
On Thu, Aug 18, 2005 at 08:07:53PM -0600, Zwane Mwaikambo wrote: node_to_cpumask on non NUMA systems is broken if used before all the processors have been brought up as it returns cpu_online_map, as opposed to NUMA i386 systems which does it earlier than AP bringup. So return which

Re: [PATCH] i386 !NUMA node_to_cpumask broken in early boot

2005-08-18 Thread Zwane Mwaikambo
On Fri, 19 Aug 2005, Andi Kleen wrote: On Thu, Aug 18, 2005 at 08:07:53PM -0600, Zwane Mwaikambo wrote: node_to_cpumask on non NUMA systems is broken if used before all the processors have been brought up as it returns cpu_online_map, as opposed to NUMA i386 systems which does it earlier

Re: [PATCH] i386 !NUMA node_to_cpumask broken in early boot

2005-08-18 Thread Andi Kleen
Thanks for the feedback, ugly indeed, i was really trying to avoid adding a new API function or extra cpu_* variables. Ok, here is an early_node_to_cpumask instead. Thinking about it again it's most likely broken with CPU hotplug anyways whatever you're doing. So how does your code handle

Re: [PATCH] i386 !NUMA node_to_cpumask broken in early boot

2005-08-18 Thread Zwane Mwaikambo
On Fri, 19 Aug 2005, Andi Kleen wrote: Thanks for the feedback, ugly indeed, i was really trying to avoid adding a new API function or extra cpu_* variables. Ok, here is an early_node_to_cpumask instead. Thinking about it again it's most likely broken with CPU hotplug anyways whatever