Re: [PATCH] iio: magnetometer: Add support for PNI RM3100 9-axis magnetometer

2018-09-29 Thread Jonathan Cameron
On Mon, 24 Sep 2018 22:37:14 +0800 Song Qiang wrote: > On Sat, Sep 22, 2018 at 11:14:09AM +0100, Jonathan Cameron wrote: > > On Thu, 20 Sep 2018 21:13:40 +0800 > > Song Qiang wrote: > > > > > PNI RM3100 magnetometer is a high resolution, large signal immunity > > > magnetometer, composed of

Re: [PATCH] iio: magnetometer: Add support for PNI RM3100 9-axis magnetometer

2018-09-29 Thread Jonathan Cameron
On Mon, 24 Sep 2018 22:37:14 +0800 Song Qiang wrote: > On Sat, Sep 22, 2018 at 11:14:09AM +0100, Jonathan Cameron wrote: > > On Thu, 20 Sep 2018 21:13:40 +0800 > > Song Qiang wrote: > > > > > PNI RM3100 magnetometer is a high resolution, large signal immunity > > > magnetometer, composed of

Re: [PATCH] iio: magnetometer: Add support for PNI RM3100 9-axis magnetometer

2018-09-29 Thread Jonathan Cameron
On Wed, 26 Sep 2018 08:34:02 +0800 Song Qiang wrote: > On Mon, Sep 24, 2018 at 03:23:52PM -0700, Rob Herring wrote: > > On Thu, Sep 20, 2018 at 09:13:40PM +0800, Song Qiang wrote: > > > PNI RM3100 magnetometer is a high resolution, large signal immunity > > > magnetometer, composed of 3 single

Re: [PATCH] iio: magnetometer: Add support for PNI RM3100 9-axis magnetometer

2018-09-29 Thread Jonathan Cameron
On Wed, 26 Sep 2018 08:34:02 +0800 Song Qiang wrote: > On Mon, Sep 24, 2018 at 03:23:52PM -0700, Rob Herring wrote: > > On Thu, Sep 20, 2018 at 09:13:40PM +0800, Song Qiang wrote: > > > PNI RM3100 magnetometer is a high resolution, large signal immunity > > > magnetometer, composed of 3 single

Re: [PATCH] iio: magnetometer: Add support for PNI RM3100 9-axis magnetometer

2018-09-25 Thread Song Qiang
On Mon, Sep 24, 2018 at 03:23:52PM -0700, Rob Herring wrote: > On Thu, Sep 20, 2018 at 09:13:40PM +0800, Song Qiang wrote: > > PNI RM3100 magnetometer is a high resolution, large signal immunity > > magnetometer, composed of 3 single sensors and a processing chip. > > PNI is currently not in the

Re: [PATCH] iio: magnetometer: Add support for PNI RM3100 9-axis magnetometer

2018-09-25 Thread Song Qiang
On Mon, Sep 24, 2018 at 03:23:52PM -0700, Rob Herring wrote: > On Thu, Sep 20, 2018 at 09:13:40PM +0800, Song Qiang wrote: > > PNI RM3100 magnetometer is a high resolution, large signal immunity > > magnetometer, composed of 3 single sensors and a processing chip. > > PNI is currently not in the

Re: [PATCH] iio: magnetometer: Add support for PNI RM3100 9-axis magnetometer

2018-09-24 Thread Jonathan Cameron
On Sun, 23 Sep 2018 23:17:22 +0800 Song Qiang wrote: > On Sat, Sep 22, 2018 at 11:14:09AM +0100, Jonathan Cameron wrote: > > On Thu, 20 Sep 2018 21:13:40 +0800 > > Song Qiang wrote: > > > > ... > > > > +const struct regmap_access_table rm3100_volatile_table = { > > > + .yes_ranges

Re: [PATCH] iio: magnetometer: Add support for PNI RM3100 9-axis magnetometer

2018-09-24 Thread Jonathan Cameron
On Sun, 23 Sep 2018 23:17:22 +0800 Song Qiang wrote: > On Sat, Sep 22, 2018 at 11:14:09AM +0100, Jonathan Cameron wrote: > > On Thu, 20 Sep 2018 21:13:40 +0800 > > Song Qiang wrote: > > > > ... > > > > +const struct regmap_access_table rm3100_volatile_table = { > > > + .yes_ranges

Re: [PATCH] iio: magnetometer: Add support for PNI RM3100 9-axis magnetometer

2018-09-24 Thread Song Qiang
On Sat, Sep 22, 2018 at 11:14:09AM +0100, Jonathan Cameron wrote: > On Thu, 20 Sep 2018 21:13:40 +0800 > Song Qiang wrote: > > > PNI RM3100 magnetometer is a high resolution, large signal immunity > > magnetometer, composed of 3 single sensors and a processing chip. > > PNI is currently not in

Re: [PATCH] iio: magnetometer: Add support for PNI RM3100 9-axis magnetometer

2018-09-24 Thread Song Qiang
On Sat, Sep 22, 2018 at 11:14:09AM +0100, Jonathan Cameron wrote: > On Thu, 20 Sep 2018 21:13:40 +0800 > Song Qiang wrote: > > > PNI RM3100 magnetometer is a high resolution, large signal immunity > > magnetometer, composed of 3 single sensors and a processing chip. > > PNI is currently not in

Re: [PATCH] iio: magnetometer: Add support for PNI RM3100 9-axis magnetometer

2018-09-23 Thread Song Qiang
On Sat, Sep 22, 2018 at 11:14:09AM +0100, Jonathan Cameron wrote: > On Thu, 20 Sep 2018 21:13:40 +0800 > Song Qiang wrote: > ... > > +const struct regmap_access_table rm3100_volatile_table = { > > + .yes_ranges = rm3100_volatile_ranges, > > + .n_yes_ranges =

Re: [PATCH] iio: magnetometer: Add support for PNI RM3100 9-axis magnetometer

2018-09-23 Thread Song Qiang
On Sat, Sep 22, 2018 at 11:14:09AM +0100, Jonathan Cameron wrote: > On Thu, 20 Sep 2018 21:13:40 +0800 > Song Qiang wrote: > ... > > +const struct regmap_access_table rm3100_volatile_table = { > > + .yes_ranges = rm3100_volatile_ranges, > > + .n_yes_ranges =

Re: [PATCH] iio: magnetometer: Add support for PNI RM3100 9-axis magnetometer

2018-09-23 Thread Dan Carpenter
Hi Song, I love your patch! Perhaps something to improve: url: https://github.com/0day-ci/linux/commits/Song-Qiang/iio-magnetometer-Add-support-for-PNI-RM3100-9-axis-magnetometer/20180920-215124 base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg smatch warnings:

Re: [PATCH] iio: magnetometer: Add support for PNI RM3100 9-axis magnetometer

2018-09-23 Thread Dan Carpenter
Hi Song, I love your patch! Perhaps something to improve: url: https://github.com/0day-ci/linux/commits/Song-Qiang/iio-magnetometer-Add-support-for-PNI-RM3100-9-axis-magnetometer/20180920-215124 base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg smatch warnings:

Re: [PATCH] iio: magnetometer: Add support for PNI RM3100 9-axis magnetometer

2018-09-22 Thread Jonathan Cameron
On Thu, 20 Sep 2018 21:13:40 +0800 Song Qiang wrote: > PNI RM3100 magnetometer is a high resolution, large signal immunity > magnetometer, composed of 3 single sensors and a processing chip. > PNI is currently not in the vendors list, so this is also adding it. > > Following functions are

Re: [PATCH] iio: magnetometer: Add support for PNI RM3100 9-axis magnetometer

2018-09-22 Thread Jonathan Cameron
On Thu, 20 Sep 2018 21:13:40 +0800 Song Qiang wrote: > PNI RM3100 magnetometer is a high resolution, large signal immunity > magnetometer, composed of 3 single sensors and a processing chip. > PNI is currently not in the vendors list, so this is also adding it. > > Following functions are

Re: [PATCH] iio: magnetometer: Add support for PNI RM3100 9-axis magnetometer

2018-09-22 Thread Jonathan Cameron
On Sat, 22 Sep 2018 10:42:44 +0100 Jonathan Cameron wrote: > A few follow ups to the discussion here from me.. > > Note it's helpful to crop and email and no one really minds if you > just act on their review without acknowledging it (so cut the > bits you fully agree with out too - saves on

Re: [PATCH] iio: magnetometer: Add support for PNI RM3100 9-axis magnetometer

2018-09-22 Thread Jonathan Cameron
On Sat, 22 Sep 2018 10:42:44 +0100 Jonathan Cameron wrote: > A few follow ups to the discussion here from me.. > > Note it's helpful to crop and email and no one really minds if you > just act on their review without acknowledging it (so cut the > bits you fully agree with out too - saves on

Re: [PATCH] iio: magnetometer: Add support for PNI RM3100 9-axis magnetometer

2018-09-22 Thread Jonathan Cameron
A few follow ups to the discussion here from me.. Note it's helpful to crop and email and no one really minds if you just act on their review without acknowledging it (so cut the bits you fully agree with out too - saves on scrolling / reading time ;) A catch all, "Agree with everything else and

Re: [PATCH] iio: magnetometer: Add support for PNI RM3100 9-axis magnetometer

2018-09-22 Thread Jonathan Cameron
A few follow ups to the discussion here from me.. Note it's helpful to crop and email and no one really minds if you just act on their review without acknowledging it (so cut the bits you fully agree with out too - saves on scrolling / reading time ;) A catch all, "Agree with everything else and

Re: [PATCH] iio: magnetometer: Add support for PNI RM3100 9-axis magnetometer

2018-09-22 Thread Song Qiang
On Fri, Sep 21, 2018 at 01:20:12PM +0100, Jonathan Cameron wrote: > Hi Song, > > ... > > Please crop emails down to the relevant section when replying. Lots of > scrolling > for everyone otherwise and sometimes things get missed when doing that. > Hi Jonathan, Sorryi for this, won't happen

Re: [PATCH] iio: magnetometer: Add support for PNI RM3100 9-axis magnetometer

2018-09-22 Thread Song Qiang
On Fri, Sep 21, 2018 at 01:20:12PM +0100, Jonathan Cameron wrote: > Hi Song, > > ... > > Please crop emails down to the relevant section when replying. Lots of > scrolling > for everyone otherwise and sometimes things get missed when doing that. > Hi Jonathan, Sorryi for this, won't happen

Re: [PATCH] iio: magnetometer: Add support for PNI RM3100 9-axis magnetometer

2018-09-21 Thread Jonathan Cameron
Hi Song, ... Please crop emails down to the relevant section when replying. Lots of scrolling for everyone otherwise and sometimes things get missed when doing that. > > > > + if (!buffer) > > > > + goto done; > > > > + > > > > + mutex_lock(>lock); > > > > +

Re: [PATCH] iio: magnetometer: Add support for PNI RM3100 9-axis magnetometer

2018-09-21 Thread Jonathan Cameron
Hi Song, ... Please crop emails down to the relevant section when replying. Lots of scrolling for everyone otherwise and sometimes things get missed when doing that. > > > > + if (!buffer) > > > > + goto done; > > > > + > > > > + mutex_lock(>lock); > > > > +

Re: [PATCH] iio: magnetometer: Add support for PNI RM3100 9-axis magnetometer

2018-09-21 Thread Song Qiang
On Fri, Sep 21, 2018 at 01:07:17PM +0800, Phil Reid wrote: > G'day Song, > > One more comment below. > On 20/09/2018 9:46 PM, Peter Meerwald-Stadler wrote: > > On Thu, 20 Sep 2018, Song Qiang wrote: > > > > > PNI RM3100 magnetometer is a high resolution, large signal immunity > > > magnetometer,

Re: [PATCH] iio: magnetometer: Add support for PNI RM3100 9-axis magnetometer

2018-09-21 Thread Song Qiang
On Fri, Sep 21, 2018 at 01:07:17PM +0800, Phil Reid wrote: > G'day Song, > > One more comment below. > On 20/09/2018 9:46 PM, Peter Meerwald-Stadler wrote: > > On Thu, 20 Sep 2018, Song Qiang wrote: > > > > > PNI RM3100 magnetometer is a high resolution, large signal immunity > > > magnetometer,

Re: [PATCH] iio: magnetometer: Add support for PNI RM3100 9-axis magnetometer

2018-09-21 Thread Song Qiang
On Fri, Sep 21, 2018 at 10:05:38AM +0800, Phil Reid wrote: > On 20/09/2018 9:13 PM, Song Qiang wrote: > > PNI RM3100 magnetometer is a high resolution, large signal immunity > > magnetometer, composed of 3 single sensors and a processing chip. > > PNI is currently not in the vendors list, so this

Re: [PATCH] iio: magnetometer: Add support for PNI RM3100 9-axis magnetometer

2018-09-21 Thread Song Qiang
On Fri, Sep 21, 2018 at 10:05:38AM +0800, Phil Reid wrote: > On 20/09/2018 9:13 PM, Song Qiang wrote: > > PNI RM3100 magnetometer is a high resolution, large signal immunity > > magnetometer, composed of 3 single sensors and a processing chip. > > PNI is currently not in the vendors list, so this

Re: [PATCH] iio: magnetometer: Add support for PNI RM3100 9-axis magnetometer

2018-09-20 Thread Phil Reid
G'day Song, One more comment below. On 20/09/2018 9:46 PM, Peter Meerwald-Stadler wrote: On Thu, 20 Sep 2018, Song Qiang wrote: PNI RM3100 magnetometer is a high resolution, large signal immunity magnetometer, composed of 3 single sensors and a processing chip. PNI is currently not in the

Re: [PATCH] iio: magnetometer: Add support for PNI RM3100 9-axis magnetometer

2018-09-20 Thread Phil Reid
G'day Song, One more comment below. On 20/09/2018 9:46 PM, Peter Meerwald-Stadler wrote: On Thu, 20 Sep 2018, Song Qiang wrote: PNI RM3100 magnetometer is a high resolution, large signal immunity magnetometer, composed of 3 single sensors and a processing chip. PNI is currently not in the

Re: [PATCH] iio: magnetometer: Add support for PNI RM3100 9-axis magnetometer

2018-09-20 Thread Phil Reid
On 20/09/2018 9:13 PM, Song Qiang wrote: PNI RM3100 magnetometer is a high resolution, large signal immunity magnetometer, composed of 3 single sensors and a processing chip. PNI is currently not in the vendors list, so this is also adding it. In the subject: Isn't the RM3100 a 3axis mag. The

Re: [PATCH] iio: magnetometer: Add support for PNI RM3100 9-axis magnetometer

2018-09-20 Thread Phil Reid
On 20/09/2018 9:13 PM, Song Qiang wrote: PNI RM3100 magnetometer is a high resolution, large signal immunity magnetometer, composed of 3 single sensors and a processing chip. PNI is currently not in the vendors list, so this is also adding it. In the subject: Isn't the RM3100 a 3axis mag. The

Re: [PATCH] iio: magnetometer: Add support for PNI RM3100 9-axis magnetometer

2018-09-20 Thread Song Qiang
On Thu, Sep 20, 2018 at 03:46:03PM +0200, Peter Meerwald-Stadler wrote: > On Thu, 20 Sep 2018, Song Qiang wrote: > > > PNI RM3100 magnetometer is a high resolution, large signal immunity > > magnetometer, composed of 3 single sensors and a processing chip. > > PNI is currently not in the vendors

Re: [PATCH] iio: magnetometer: Add support for PNI RM3100 9-axis magnetometer

2018-09-20 Thread Song Qiang
On Thu, Sep 20, 2018 at 03:46:03PM +0200, Peter Meerwald-Stadler wrote: > On Thu, 20 Sep 2018, Song Qiang wrote: > > > PNI RM3100 magnetometer is a high resolution, large signal immunity > > magnetometer, composed of 3 single sensors and a processing chip. > > PNI is currently not in the vendors

Re: [PATCH] iio: magnetometer: Add support for PNI RM3100 9-axis magnetometer

2018-09-20 Thread Peter Meerwald-Stadler
On Thu, 20 Sep 2018, Song Qiang wrote: > PNI RM3100 magnetometer is a high resolution, large signal immunity > magnetometer, composed of 3 single sensors and a processing chip. > PNI is currently not in the vendors list, so this is also adding it. comments below > > Following functions are

Re: [PATCH] iio: magnetometer: Add support for PNI RM3100 9-axis magnetometer

2018-09-20 Thread Peter Meerwald-Stadler
On Thu, 20 Sep 2018, Song Qiang wrote: > PNI RM3100 magnetometer is a high resolution, large signal immunity > magnetometer, composed of 3 single sensors and a processing chip. > PNI is currently not in the vendors list, so this is also adding it. comments below > > Following functions are