Re: [PATCH] media/radio [check_region() removal... ]

2000-11-09 Thread Russell Kroll
[ radio cards ] > These drivers seem to be unmantained :) Erm, no. I'm still behind the radio-aztech driver plus my mods on radio-aimslab and radio-cadet. Calling them unmaintained is going too far. As for the others, that's up to their respective authors. I use the cadet every couple of

Re: [PATCH] media/radio [check_region() removal... ]

2000-11-09 Thread Jeff Garzik
Alan Cox wrote: > > > 2) i found that some net drivers (3c527.c, sk_mca.c) use io region and > > don't call request_region() at all. Should they be fixed ? > > Probably. > > MCA bus ensures there can be no collisions of I/O space but it does mean the > user cannot see what is where as is

Re: [PATCH] media/radio [check_region() removal... ]

2000-11-09 Thread Alan Cox
> 2) i found that some net drivers (3c527.c, sk_mca.c) use io region and > don't call request_region() at all. Should they be fixed ? Probably. MCA bus ensures there can be no collisions of I/O space but it does mean the user cannot see what is where as is - To unsubscribe from this list: send

Re: [PATCH] media/radio [check_region() removal... ]

2000-11-09 Thread Jeff Garzik
Andrey Panin wrote: > 1) how about drivers requesting 2 (or more) irq for one device ? > AFAIK some PowerMac net drivers do it (bmac.c for example). Should be fine.. If the driver distinguishes between the irqs, maybe you should do "eth0-rx dma", "eth0-tx dma", etc. > 2) i found that some net

Re: [PATCH] media/radio [check_region() removal... ]

2000-11-09 Thread Andrey Panin
On Wed, Nov 08, 2000 at 07:13:46PM -0500, Jeff Garzik wrote: Hi all, > > Finally, a word to you, Alan, and others doing request_region work: it > is more informative to pass the device name (minor, etc.) into > request_region. Ditto for request_irq. Many (most, except net?) > drivers use

Re: [PATCH] media/radio [check_region() removal... ]

2000-11-09 Thread Andrey Panin
On Wed, Nov 08, 2000 at 07:13:46PM -0500, Jeff Garzik wrote: Hi all, Finally, a word to you, Alan, and others doing request_region work: it is more informative to pass the device name (minor, etc.) into request_region. Ditto for request_irq. Many (most, except net?) drivers use

Re: [PATCH] media/radio [check_region() removal... ]

2000-11-09 Thread Jeff Garzik
Andrey Panin wrote: 1) how about drivers requesting 2 (or more) irq for one device ? AFAIK some PowerMac net drivers do it (bmac.c for example). Should be fine.. If the driver distinguishes between the irqs, maybe you should do "eth0-rx dma", "eth0-tx dma", etc. 2) i found that some net

Re: [PATCH] media/radio [check_region() removal... ]

2000-11-09 Thread Alan Cox
2) i found that some net drivers (3c527.c, sk_mca.c) use io region and don't call request_region() at all. Should they be fixed ? Probably. MCA bus ensures there can be no collisions of I/O space but it does mean the user cannot see what is where as is - To unsubscribe from this list: send

Re: [PATCH] media/radio [check_region() removal... ]

2000-11-09 Thread Jeff Garzik
Alan Cox wrote: 2) i found that some net drivers (3c527.c, sk_mca.c) use io region and don't call request_region() at all. Should they be fixed ? Probably. MCA bus ensures there can be no collisions of I/O space but it does mean the user cannot see what is where as is Ditto for

Re: [PATCH] media/radio [check_region() removal... ]

2000-11-09 Thread Russell Kroll
[ radio cards ] These drivers seem to be unmantained :) Erm, no. I'm still behind the radio-aztech driver plus my mods on radio-aimslab and radio-cadet. Calling them unmaintained is going too far. As for the others, that's up to their respective authors. I use the cadet every couple of

Re: [PATCH] media/radio [check_region() removal... ]

2000-11-08 Thread Jeff Garzik
Bartlomiej Zolnierkiewicz wrote: > > On Wed, 8 Nov 2000, Jeff Garzik wrote: > > > Patch looks generally ok. Some of the whitespace/formatting changes are > > questionable, I usually leave that up to the maintainer unless it is > > very gratuitously opposite to CodingStyle. > > > > These

Re: [PATCH] media/radio [check_region() removal... ]

2000-11-08 Thread Bartlomiej Zolnierkiewicz
On Wed, 8 Nov 2000, Jeff Garzik wrote: > Patch looks generally ok. Some of the whitespace/formatting changes are > questionable, I usually leave that up to the maintainer unless it is > very gratuitously opposite to CodingStyle. > These drivers seem to be unmantained :) Anyway if this is a

Re: [PATCH] media/radio [check_region() removal... ]

2000-11-08 Thread Jeff Garzik
Patch looks generally ok. Some of the whitespace/formatting changes are questionable, I usually leave that up to the maintainer unless it is very gratuitously opposite to CodingStyle. Some of the driver messages ("foo version 1.0") are purposefully printed -after-, not before, the device is

Re: [PATCH] media/radio [check_region() removal... ]

2000-11-08 Thread Jeff Garzik
Patch looks generally ok. Some of the whitespace/formatting changes are questionable, I usually leave that up to the maintainer unless it is very gratuitously opposite to CodingStyle. Some of the driver messages ("foo version 1.0") are purposefully printed -after-, not before, the device is

Re: [PATCH] media/radio [check_region() removal... ]

2000-11-08 Thread Bartlomiej Zolnierkiewicz
On Wed, 8 Nov 2000, Jeff Garzik wrote: Patch looks generally ok. Some of the whitespace/formatting changes are questionable, I usually leave that up to the maintainer unless it is very gratuitously opposite to CodingStyle. These drivers seem to be unmantained :) Anyway if this is a problem

Re: [PATCH] media/radio [check_region() removal... ]

2000-11-08 Thread Jeff Garzik
Bartlomiej Zolnierkiewicz wrote: On Wed, 8 Nov 2000, Jeff Garzik wrote: Patch looks generally ok. Some of the whitespace/formatting changes are questionable, I usually leave that up to the maintainer unless it is very gratuitously opposite to CodingStyle. These drivers seem to be