Re: [PATCH] media: atomisp: ov2722: replace hardcoded function name

2021-01-07 Thread Dan Carpenter
On Wed, Jan 06, 2021 at 01:17:47PM -0800, Joe Perches wrote: > On Wed, 2021-01-06 at 22:36 +0300, Dan Carpenter wrote: > > On Wed, Jan 06, 2021 at 10:25:26AM -0800, Joe Perches wrote: > > > On Wed, 2021-01-06 at 18:52 +0100, Greg Kroah-Hartman wrote: > > > > On Wed, Jan 06, 2021 at 07:43:42PM

Re: [PATCH] media: atomisp: ov2722: replace hardcoded function name

2021-01-06 Thread Joe Perches
On Wed, 2021-01-06 at 22:36 +0300, Dan Carpenter wrote: > On Wed, Jan 06, 2021 at 10:25:26AM -0800, Joe Perches wrote: > > On Wed, 2021-01-06 at 18:52 +0100, Greg Kroah-Hartman wrote: > > > On Wed, Jan 06, 2021 at 07:43:42PM +0200, Filip Kolev wrote: > > > > On 06-Jan-21 09:51, Greg Kroah-Hartman

Re: [PATCH] media: atomisp: ov2722: replace hardcoded function name

2021-01-06 Thread Dan Carpenter
On Wed, Jan 06, 2021 at 10:25:26AM -0800, Joe Perches wrote: > On Wed, 2021-01-06 at 18:52 +0100, Greg Kroah-Hartman wrote: > > On Wed, Jan 06, 2021 at 07:43:42PM +0200, Filip Kolev wrote: > > > On 06-Jan-21 09:51, Greg Kroah-Hartman wrote: > > > > On Tue, Jan 05, 2021 at 10:29:18PM +0200, Filip

Re: [PATCH] media: atomisp: ov2722: replace hardcoded function name

2021-01-06 Thread Joe Perches
On Wed, 2021-01-06 at 18:52 +0100, Greg Kroah-Hartman wrote: > On Wed, Jan 06, 2021 at 07:43:42PM +0200, Filip Kolev wrote: > > On 06-Jan-21 09:51, Greg Kroah-Hartman wrote: > > > On Tue, Jan 05, 2021 at 10:29:18PM +0200, Filip Kolev wrote: > > > > There is a debug message using hardcoded

Re: [PATCH] media: atomisp: ov2722: replace hardcoded function name

2021-01-06 Thread Greg Kroah-Hartman
On Wed, Jan 06, 2021 at 07:43:42PM +0200, Filip Kolev wrote: > > > On 06-Jan-21 09:51, Greg Kroah-Hartman wrote: > > On Tue, Jan 05, 2021 at 10:29:18PM +0200, Filip Kolev wrote: > > > There is a debug message using hardcoded function name instead of the > > > __func__ macro. Replace it. > > > >

Re: [PATCH] media: atomisp: ov2722: replace hardcoded function name

2021-01-06 Thread Filip Kolev
On 06-Jan-21 09:51, Greg Kroah-Hartman wrote: On Tue, Jan 05, 2021 at 10:29:18PM +0200, Filip Kolev wrote: There is a debug message using hardcoded function name instead of the __func__ macro. Replace it. Report from checkpatch.pl on the file: WARNING: Prefer using '"%s...", __func__' to

Re: [PATCH] media: atomisp: ov2722: replace hardcoded function name

2021-01-05 Thread Greg Kroah-Hartman
On Tue, Jan 05, 2021 at 10:29:18PM +0200, Filip Kolev wrote: > There is a debug message using hardcoded function name instead of the > __func__ macro. Replace it. > > Report from checkpatch.pl on the file: > > WARNING: Prefer using '"%s...", __func__' to using 'ov2722_remove', this > function's