Re: [PATCH] media: v4l2-ctrl: Add p_def to v4l2_ctrl_config

2019-10-16 Thread Hans Verkuil
On 10/16/19 3:12 PM, Ricardo Ribalda Delgado wrote: > Hi Hans > > On Wed, Oct 16, 2019 at 2:43 PM Hans Verkuil wrote: >> >> On 10/16/19 2:39 PM, Ricardo Ribalda Delgado wrote: >>> Hi Hans: >>> >>> On Wed, Oct 16, 2019 at 2:32 PM Hans Verkuil >>> wrote: On 10/16/19 2:20 PM, Ricardo

Re: [PATCH] media: v4l2-ctrl: Add p_def to v4l2_ctrl_config

2019-10-16 Thread Ricardo Ribalda Delgado
Hi Hans On Wed, Oct 16, 2019 at 2:57 PM Hans Verkuil wrote: > > On 10/16/19 2:43 PM, Hans Verkuil wrote: > > On 10/16/19 2:39 PM, Ricardo Ribalda Delgado wrote: > >> Hi Hans: > >> > >> On Wed, Oct 16, 2019 at 2:32 PM Hans Verkuil > >> wrote: > >>> > >>> On 10/16/19 2:20 PM, Ricardo Ribalda

Re: [PATCH] media: v4l2-ctrl: Add p_def to v4l2_ctrl_config

2019-10-16 Thread Ricardo Ribalda Delgado
Hi Hans On Wed, Oct 16, 2019 at 2:43 PM Hans Verkuil wrote: > > On 10/16/19 2:39 PM, Ricardo Ribalda Delgado wrote: > > Hi Hans: > > > > On Wed, Oct 16, 2019 at 2:32 PM Hans Verkuil > > wrote: > >> > >> On 10/16/19 2:20 PM, Ricardo Ribalda Delgado wrote: > >>> Hi Hans > >>> > >>> Not that

Re: [PATCH] media: v4l2-ctrl: Add p_def to v4l2_ctrl_config

2019-10-16 Thread Hans Verkuil
On 10/16/19 2:43 PM, Hans Verkuil wrote: > On 10/16/19 2:39 PM, Ricardo Ribalda Delgado wrote: >> Hi Hans: >> >> On Wed, Oct 16, 2019 at 2:32 PM Hans Verkuil >> wrote: >>> >>> On 10/16/19 2:20 PM, Ricardo Ribalda Delgado wrote: Hi Hans Not that awkward, the user has to use the

Re: [PATCH] media: v4l2-ctrl: Add p_def to v4l2_ctrl_config

2019-10-16 Thread Hans Verkuil
On 10/16/19 2:39 PM, Ricardo Ribalda Delgado wrote: > Hi Hans: > > On Wed, Oct 16, 2019 at 2:32 PM Hans Verkuil wrote: >> >> On 10/16/19 2:20 PM, Ricardo Ribalda Delgado wrote: >>> Hi Hans >>> >>> Not that awkward, the user has to use the brand new >>> v4l2_ctrl_ptr_create() ;). But if you

Re: [PATCH] media: v4l2-ctrl: Add p_def to v4l2_ctrl_config

2019-10-16 Thread Ricardo Ribalda Delgado
Hi Hans: On Wed, Oct 16, 2019 at 2:32 PM Hans Verkuil wrote: > > On 10/16/19 2:20 PM, Ricardo Ribalda Delgado wrote: > > Hi Hans > > > > Not that awkward, the user has to use the brand new > > v4l2_ctrl_ptr_create() ;). But if you prefer void * I can make the > > change. > > Well, a struct

Re: [PATCH] media: v4l2-ctrl: Add p_def to v4l2_ctrl_config

2019-10-16 Thread Hans Verkuil
On 10/16/19 2:20 PM, Ricardo Ribalda Delgado wrote: > Hi Hans > > Not that awkward, the user has to use the brand new > v4l2_ctrl_ptr_create() ;). But if you prefer void * I can make the > change. Well, a struct v4l2_ctrl_config is typically a static const, so you can't use

Re: [PATCH] media: v4l2-ctrl: Add p_def to v4l2_ctrl_config

2019-10-16 Thread Ricardo Ribalda Delgado
Hi Hans Not that awkward, the user has to use the brand new v4l2_ctrl_ptr_create() ;). But if you prefer void * I can make the change. Regards On Wed, Oct 16, 2019 at 2:17 PM Hans Verkuil wrote: > > On 10/14/19 4:14 PM, Ricardo Ribalda Delgado wrote: > > This allows setting the default value

Re: [PATCH] media: v4l2-ctrl: Add p_def to v4l2_ctrl_config

2019-10-16 Thread Hans Verkuil
On 10/14/19 4:14 PM, Ricardo Ribalda Delgado wrote: > This allows setting the default value on compound controls created via > v4l2_ctrl_new_custom. > > Signed-off-by: Ricardo Ribalda Delgado > --- > drivers/media/v4l2-core/v4l2-ctrls.c | 2 +- > include/media/v4l2-ctrls.h | 2 ++ > 2