Re: [PATCH] mm: bootmem: use phys_addr_t for physical addresses

2012-09-13 Thread Tejun Heo
Hello, Cyril. On Wed, Sep 12, 2012 at 08:40:58PM -0400, Cyril Chemparathy wrote: > You probably missed the lowmem bit from my response? > > This system has all of its memory outside the 4GB physical address > space. This includes lowmem, which is permanently mapped into the > kernel virtual

Re: [PATCH] mm: bootmem: use phys_addr_t for physical addresses

2012-09-13 Thread Tejun Heo
Hello, Cyril. On Wed, Sep 12, 2012 at 08:40:58PM -0400, Cyril Chemparathy wrote: You probably missed the lowmem bit from my response? This system has all of its memory outside the 4GB physical address space. This includes lowmem, which is permanently mapped into the kernel virtual address

Re: [PATCH] mm: bootmem: use phys_addr_t for physical addresses

2012-09-12 Thread Cyril Chemparathy
Hi Tejun, On 9/12/2012 8:34 PM, Tejun Heo wrote: Hello, On Wed, Sep 12, 2012 at 08:08:30PM -0400, Cyril Chemparathy wrote: So, a function which takes phys_addr_t for goal and limit but returns void * doesn't make much sense unless the function creates directly addressable mapping somewhere.

Re: [PATCH] mm: bootmem: use phys_addr_t for physical addresses

2012-09-12 Thread Tejun Heo
Hello, On Wed, Sep 12, 2012 at 08:08:30PM -0400, Cyril Chemparathy wrote: > >So, a function which takes phys_addr_t for goal and limit but returns > >void * doesn't make much sense unless the function creates directly > >addressable mapping somewhere. > > On the 32-bit PAE platform in question,

Re: [PATCH] mm: bootmem: use phys_addr_t for physical addresses

2012-09-12 Thread Cyril Chemparathy
Hi Tejun, On 9/12/2012 4:39 PM, Tejun Heo wrote: Hello, On Wed, Sep 12, 2012 at 12:06:48PM -0400, Cyril Chemparathy wrote: static void * __init alloc_bootmem_core(unsigned long size, unsigned long align, -

Re: [PATCH] mm: bootmem: use phys_addr_t for physical addresses

2012-09-12 Thread Tejun Heo
Hello, On Wed, Sep 12, 2012 at 12:06:48PM -0400, Cyril Chemparathy wrote: > static void * __init alloc_bootmem_core(unsigned long size, > unsigned long align, > - unsigned long goal, > -

Re: [PATCH] mm: bootmem: use phys_addr_t for physical addresses

2012-09-12 Thread Tejun Heo
Hello, On Wed, Sep 12, 2012 at 12:06:48PM -0400, Cyril Chemparathy wrote: static void * __init alloc_bootmem_core(unsigned long size, unsigned long align, - unsigned long goal, -

Re: [PATCH] mm: bootmem: use phys_addr_t for physical addresses

2012-09-12 Thread Cyril Chemparathy
Hi Tejun, On 9/12/2012 4:39 PM, Tejun Heo wrote: Hello, On Wed, Sep 12, 2012 at 12:06:48PM -0400, Cyril Chemparathy wrote: static void * __init alloc_bootmem_core(unsigned long size, unsigned long align, -

Re: [PATCH] mm: bootmem: use phys_addr_t for physical addresses

2012-09-12 Thread Tejun Heo
Hello, On Wed, Sep 12, 2012 at 08:08:30PM -0400, Cyril Chemparathy wrote: So, a function which takes phys_addr_t for goal and limit but returns void * doesn't make much sense unless the function creates directly addressable mapping somewhere. On the 32-bit PAE platform in question, physical

Re: [PATCH] mm: bootmem: use phys_addr_t for physical addresses

2012-09-12 Thread Cyril Chemparathy
Hi Tejun, On 9/12/2012 8:34 PM, Tejun Heo wrote: Hello, On Wed, Sep 12, 2012 at 08:08:30PM -0400, Cyril Chemparathy wrote: So, a function which takes phys_addr_t for goal and limit but returns void * doesn't make much sense unless the function creates directly addressable mapping somewhere.