Re: [PATCH] mm-vmscan-dont-mess-with-pgdat-flags-in-memcg-reclaim-v2-fix

2018-04-06 Thread Johannes Weiner
On Fri, Apr 06, 2018 at 04:52:15PM +0300, Andrey Ryabinin wrote: > On 04/06/2018 05:13 AM, Shakeel Butt wrote: > > Question: Should this 'flags' be per-node? Is it ok for a congested > > memcg to call wait_iff_congested for all nodes? > > Indeed, congestion state should be pre-node. If memcg on

Re: [PATCH] mm-vmscan-dont-mess-with-pgdat-flags-in-memcg-reclaim-v2-fix

2018-04-06 Thread Johannes Weiner
On Fri, Apr 06, 2018 at 04:52:15PM +0300, Andrey Ryabinin wrote: > On 04/06/2018 05:13 AM, Shakeel Butt wrote: > > Question: Should this 'flags' be per-node? Is it ok for a congested > > memcg to call wait_iff_congested for all nodes? > > Indeed, congestion state should be pre-node. If memcg on

Re: [PATCH] mm-vmscan-dont-mess-with-pgdat-flags-in-memcg-reclaim-v2-fix

2018-04-06 Thread Shakeel Butt
On Fri, Apr 6, 2018 at 8:09 AM, Andrey Ryabinin wrote: > > > On 04/06/2018 05:37 PM, Shakeel Butt wrote: > >>> >>> @@ -2482,7 +2494,7 @@ static inline bool should_continue_reclaim(struct >>> pglist_data *pgdat, >>> static bool pgdat_memcg_congested(pg_data_t *pgdat,

Re: [PATCH] mm-vmscan-dont-mess-with-pgdat-flags-in-memcg-reclaim-v2-fix

2018-04-06 Thread Shakeel Butt
On Fri, Apr 6, 2018 at 8:09 AM, Andrey Ryabinin wrote: > > > On 04/06/2018 05:37 PM, Shakeel Butt wrote: > >>> >>> @@ -2482,7 +2494,7 @@ static inline bool should_continue_reclaim(struct >>> pglist_data *pgdat, >>> static bool pgdat_memcg_congested(pg_data_t *pgdat, struct mem_cgroup >>>

Re: [PATCH] mm-vmscan-dont-mess-with-pgdat-flags-in-memcg-reclaim-v2-fix

2018-04-06 Thread Andrey Ryabinin
On 04/06/2018 05:37 PM, Shakeel Butt wrote: >> >> @@ -2482,7 +2494,7 @@ static inline bool should_continue_reclaim(struct >> pglist_data *pgdat, >> static bool pgdat_memcg_congested(pg_data_t *pgdat, struct mem_cgroup >> *memcg) >> { >> return test_bit(PGDAT_CONGESTED, >flags) || >>

Re: [PATCH] mm-vmscan-dont-mess-with-pgdat-flags-in-memcg-reclaim-v2-fix

2018-04-06 Thread Andrey Ryabinin
On 04/06/2018 05:37 PM, Shakeel Butt wrote: >> >> @@ -2482,7 +2494,7 @@ static inline bool should_continue_reclaim(struct >> pglist_data *pgdat, >> static bool pgdat_memcg_congested(pg_data_t *pgdat, struct mem_cgroup >> *memcg) >> { >> return test_bit(PGDAT_CONGESTED, >flags) || >>

Re: [PATCH] mm-vmscan-dont-mess-with-pgdat-flags-in-memcg-reclaim-v2-fix

2018-04-06 Thread Shakeel Butt
On Fri, Apr 6, 2018 at 6:52 AM, Andrey Ryabinin wrote: > On 04/06/2018 05:13 AM, Shakeel Butt wrote: >> Question: Should this 'flags' be per-node? Is it ok for a congested >> memcg to call wait_iff_congested for all nodes? > > Indeed, congestion state should be pre-node.

Re: [PATCH] mm-vmscan-dont-mess-with-pgdat-flags-in-memcg-reclaim-v2-fix

2018-04-06 Thread Shakeel Butt
On Fri, Apr 6, 2018 at 6:52 AM, Andrey Ryabinin wrote: > On 04/06/2018 05:13 AM, Shakeel Butt wrote: >> Question: Should this 'flags' be per-node? Is it ok for a congested >> memcg to call wait_iff_congested for all nodes? > > Indeed, congestion state should be pre-node. If memcg on node A is >