Re: [PATCH] mmc: dw_mmc: Wait for data transfer after response errors

Hi, On Thu, Mar 24, 2016 at 9:22 AM, Russell King - ARM Linux wrote: > That's why, for sdhci, I came to the conclusion that waiting for the > data transfer to complete or timeout was the best solution for SDHCI. > > Maybe, if sending a STOP command does cause card

Re: [PATCH] mmc: dw_mmc: Wait for data transfer after response errors

Hi, On Thu, Mar 24, 2016 at 9:22 AM, Russell King - ARM Linux wrote: > That's why, for sdhci, I came to the conclusion that waiting for the > data transfer to complete or timeout was the best solution for SDHCI. > > Maybe, if sending a STOP command does cause card firmware issues, then: > > 1)

Re: [PATCH] mmc: dw_mmc: Wait for data transfer after response errors

2016-03-31 4:03 GMT+02:00 Jaehoon Chung : > On 03/31/2016 02:16 AM, Enric Balletbo Serra wrote: >> 2016-03-24 17:22 GMT+01:00 Russell King - ARM Linux : >>> On Thu, Mar 24, 2016 at 09:06:45AM -0700, Doug Anderson wrote: Russell, >>> ...

Re: [PATCH] mmc: dw_mmc: Wait for data transfer after response errors

2016-03-31 4:03 GMT+02:00 Jaehoon Chung : > On 03/31/2016 02:16 AM, Enric Balletbo Serra wrote: >> 2016-03-24 17:22 GMT+01:00 Russell King - ARM Linux : >>> On Thu, Mar 24, 2016 at 09:06:45AM -0700, Doug Anderson wrote: Russell, >>> ... Presumably this is similar to what you saw: the

Re: [PATCH] mmc: dw_mmc: Wait for data transfer after response errors

On 03/31/2016 02:16 AM, Enric Balletbo Serra wrote: > 2016-03-24 17:22 GMT+01:00 Russell King - ARM Linux : >> On Thu, Mar 24, 2016 at 09:06:45AM -0700, Doug Anderson wrote: >>> Russell, >> ... >>> Presumably this is similar to what you saw: the host saw the CRC error >>>

Re: [PATCH] mmc: dw_mmc: Wait for data transfer after response errors

On 03/31/2016 02:16 AM, Enric Balletbo Serra wrote: > 2016-03-24 17:22 GMT+01:00 Russell King - ARM Linux : >> On Thu, Mar 24, 2016 at 09:06:45AM -0700, Doug Anderson wrote: >>> Russell, >> ... >>> Presumably this is similar to what you saw: the host saw the CRC error >>> but the card knew nothing

Re: [PATCH] mmc: dw_mmc: Wait for data transfer after response errors

在 2016/3/31 1:26, Russell King - ARM Linux 写道: On Wed, Mar 30, 2016 at 07:16:18PM +0200, Enric Balletbo Serra wrote: 2016-03-24 17:22 GMT+01:00 Russell King - ARM Linux : On Thu, Mar 24, 2016 at 09:06:45AM -0700, Doug Anderson wrote: Russell, ... Presumably this is

Re: [PATCH] mmc: dw_mmc: Wait for data transfer after response errors

在 2016/3/31 1:26, Russell King - ARM Linux 写道: On Wed, Mar 30, 2016 at 07:16:18PM +0200, Enric Balletbo Serra wrote: 2016-03-24 17:22 GMT+01:00 Russell King - ARM Linux : On Thu, Mar 24, 2016 at 09:06:45AM -0700, Doug Anderson wrote: Russell, ... Presumably this is similar to what you saw:

Re: [PATCH] mmc: dw_mmc: Wait for data transfer after response errors

On Wed, Mar 30, 2016 at 10:06:36PM +0200, Enric Balletbo Serra wrote: > El dia 30/03/2016 19:26, "Russell King - ARM Linux" > va escriure: > > I'd really suggest that the dw-mmc folk place a moritorium on quirk > > flags, and instead deal with situations like this without

Re: [PATCH] mmc: dw_mmc: Wait for data transfer after response errors

On Wed, Mar 30, 2016 at 10:06:36PM +0200, Enric Balletbo Serra wrote: > El dia 30/03/2016 19:26, "Russell King - ARM Linux" > va escriure: > > I'd really suggest that the dw-mmc folk place a moritorium on quirk > > flags, and instead deal with situations like this without resorting > > to this

Re: [PATCH] mmc: dw_mmc: Wait for data transfer after response errors

On Wed, Mar 30, 2016 at 07:16:18PM +0200, Enric Balletbo Serra wrote: > 2016-03-24 17:22 GMT+01:00 Russell King - ARM Linux : > > On Thu, Mar 24, 2016 at 09:06:45AM -0700, Doug Anderson wrote: > >> Russell, > > ... > >> Presumably this is similar to what you saw: the host

Re: [PATCH] mmc: dw_mmc: Wait for data transfer after response errors

On Wed, Mar 30, 2016 at 07:16:18PM +0200, Enric Balletbo Serra wrote: > 2016-03-24 17:22 GMT+01:00 Russell King - ARM Linux : > > On Thu, Mar 24, 2016 at 09:06:45AM -0700, Doug Anderson wrote: > >> Russell, > > ... > >> Presumably this is similar to what you saw: the host saw the CRC error > >>

Re: [PATCH] mmc: dw_mmc: Wait for data transfer after response errors

2016-03-24 17:22 GMT+01:00 Russell King - ARM Linux : > On Thu, Mar 24, 2016 at 09:06:45AM -0700, Doug Anderson wrote: >> Russell, > ... >> Presumably this is similar to what you saw: the host saw the CRC error >> but the card knew nothing about it. Sending the stop

Re: [PATCH] mmc: dw_mmc: Wait for data transfer after response errors

2016-03-24 17:22 GMT+01:00 Russell King - ARM Linux : > On Thu, Mar 24, 2016 at 09:06:45AM -0700, Doug Anderson wrote: >> Russell, > ... >> Presumably this is similar to what you saw: the host saw the CRC error >> but the card knew nothing about it. Sending the stop command during >> this time

Re: [PATCH] mmc: dw_mmc: Wait for data transfer after response errors

On Thu, Mar 24, 2016 at 09:06:45AM -0700, Doug Anderson wrote: > Russell, ... > Presumably this is similar to what you saw: the host saw the CRC error > but the card knew nothing about it. Sending the stop command during > this time confused the card. Presumably the card was in transfer > state

Re: [PATCH] mmc: dw_mmc: Wait for data transfer after response errors

On Thu, Mar 24, 2016 at 09:06:45AM -0700, Doug Anderson wrote: > Russell, ... > Presumably this is similar to what you saw: the host saw the CRC error > but the card knew nothing about it. Sending the stop command during > this time confused the card. Presumably the card was in transfer > state

Re: [PATCH] mmc: dw_mmc: Wait for data transfer after response errors

Russell, On Thu, Mar 24, 2016 at 8:30 AM, Russell King - ARM Linux wrote: > On Thu, Mar 24, 2016 at 12:26:43PM +0100, Enric Balletbo Serra wrote: >> I just saw that Russell introduced a patch [1] that will land on 4.6. >> I think that patch solves the same issue that

Re: [PATCH] mmc: dw_mmc: Wait for data transfer after response errors

Russell, On Thu, Mar 24, 2016 at 8:30 AM, Russell King - ARM Linux wrote: > On Thu, Mar 24, 2016 at 12:26:43PM +0100, Enric Balletbo Serra wrote: >> I just saw that Russell introduced a patch [1] that will land on 4.6. >> I think that patch solves the same issue that we're trying to fix, but >>

Re: [PATCH] mmc: dw_mmc: Wait for data transfer after response errors

On Thu, Mar 24, 2016 at 12:26:43PM +0100, Enric Balletbo Serra wrote: > I just saw that Russell introduced a patch [1] that will land on 4.6. > I think that patch solves the same issue that we're trying to fix, but > for sdhci controller. It doesn't sound like the same issue to me, though it was

Re: [PATCH] mmc: dw_mmc: Wait for data transfer after response errors

On Thu, Mar 24, 2016 at 12:26:43PM +0100, Enric Balletbo Serra wrote: > I just saw that Russell introduced a patch [1] that will land on 4.6. > I think that patch solves the same issue that we're trying to fix, but > for sdhci controller. It doesn't sound like the same issue to me, though it was

Re: [PATCH] mmc: dw_mmc: Wait for data transfer after response errors

Hi, On Thu, Mar 24, 2016 at 4:26 AM, Enric Balletbo Serra wrote: >> Ah, that would make some sense why things work OK on Rockchip. Adding >> DW_MCI_QUIRK_BROKEN_DTO to peach probably doesn't make sense, then. >> Hrm... >> >> Since my original debugging of the issue was over

Re: [PATCH] mmc: dw_mmc: Wait for data transfer after response errors

Hi, On Thu, Mar 24, 2016 at 4:26 AM, Enric Balletbo Serra wrote: >> Ah, that would make some sense why things work OK on Rockchip. Adding >> DW_MCI_QUIRK_BROKEN_DTO to peach probably doesn't make sense, then. >> Hrm... >> >> Since my original debugging of the issue was over a year ago, I think

Re: [PATCH] mmc: dw_mmc: Wait for data transfer after response errors

I fixed Javier Martinez email and removed tgih@samsung.com (delivery fail) Also cc'ing Russell King as I think might help (see my comment below) 2016-03-21 23:38 GMT+01:00 Doug Anderson : > Enric, > > On Thu, Mar 17, 2016 at 5:12 AM, Enric Balletbo Serra >

Re: [PATCH] mmc: dw_mmc: Wait for data transfer after response errors

I fixed Javier Martinez email and removed tgih@samsung.com (delivery fail) Also cc'ing Russell King as I think might help (see my comment below) 2016-03-21 23:38 GMT+01:00 Doug Anderson : > Enric, > > On Thu, Mar 17, 2016 at 5:12 AM, Enric Balletbo Serra > wrote: >> Dear all, >> >> Seems

Re: [PATCH] mmc: dw_mmc: Wait for data transfer after response errors

Enric, On Thu, Mar 17, 2016 at 5:12 AM, Enric Balletbo Serra wrote: > Dear all, > > Seems the following thread[1] didn't go anywhere. I'd like to continue > the discussion and share some tests that I did regarding the issue > that the patch is trying to fix. > > First I

Re: [PATCH] mmc: dw_mmc: Wait for data transfer after response errors

Enric, On Thu, Mar 17, 2016 at 5:12 AM, Enric Balletbo Serra wrote: > Dear all, > > Seems the following thread[1] didn't go anywhere. I'd like to continue > the discussion and share some tests that I did regarding the issue > that the patch is trying to fix. > > First I reproduced the issue on

Re: [PATCH] mmc: dw_mmc: Wait for data transfer after response errors

Hi, On Tue, May 26, 2015 at 6:53 PM, Jaehoon Chung wrote: >>> Have not checked the dw TRM for this change, will do that as soon as I >>> get access to it. >> >> OK, sounds good. I have some old version of the DesignWare TRM, so >> possibly something is different in the newer one... > > Which

Re: [PATCH] mmc: dw_mmc: Wait for data transfer after response errors

Hi, On Tue, May 26, 2015 at 6:53 PM, Jaehoon Chung jh80.ch...@samsung.com wrote: Have not checked the dw TRM for this change, will do that as soon as I get access to it. OK, sounds good. I have some old version of the DesignWare TRM, so possibly something is different in the newer one...

Re: [PATCH] mmc: dw_mmc: Wait for data transfer after response errors

Hi, All. Thanks for your effort and sorry for late! On 05/27/2015 05:44 AM, Doug Anderson wrote: > Alim, > > On Tue, May 26, 2015 at 11:02 AM, Alim Akhtar wrote: >> Hi Doug, >> On peach-pi, I got a hung task once in 4 cold boot as [1]. > > OK, I'll have to get my peach-pi or peach-pit up and

Re: [PATCH] mmc: dw_mmc: Wait for data transfer after response errors

Alim, On Tue, May 26, 2015 at 11:02 AM, Alim Akhtar wrote: > Hi Doug, > On peach-pi, I got a hung task once in 4 cold boot as [1]. OK, I'll have to get my peach-pi or peach-pit up and running again. I ran out of desk space and I haven't gotten it set back up. :( I've been testing on an

Re: [PATCH] mmc: dw_mmc: Wait for data transfer after response errors

Hi Doug, On peach-pi, I got a hung task once in 4 cold boot as [1]. And every time got a hung task [2] on suspend/resume, triggered exactly from this change. I have a debug print at $SUBJECT change. [1]: on boot: [ 240.197190] INFO: task kworker/u16:1:50 blocked for more than 120

Re: [PATCH] mmc: dw_mmc: Wait for data transfer after response errors

Hi, All. Thanks for your effort and sorry for late! On 05/27/2015 05:44 AM, Doug Anderson wrote: Alim, On Tue, May 26, 2015 at 11:02 AM, Alim Akhtar alim.akh...@gmail.com wrote: Hi Doug, On peach-pi, I got a hung task once in 4 cold boot as [1]. OK, I'll have to get my peach-pi or

Re: [PATCH] mmc: dw_mmc: Wait for data transfer after response errors

Hi Doug, On peach-pi, I got a hung task once in 4 cold boot as [1]. And every time got a hung task [2] on suspend/resume, triggered exactly from this change. I have a debug print at $SUBJECT change. [1]: on boot: [ 240.197190] INFO: task kworker/u16:1:50 blocked for more than 120

Re: [PATCH] mmc: dw_mmc: Wait for data transfer after response errors

Alim, On Tue, May 26, 2015 at 11:02 AM, Alim Akhtar alim.akh...@gmail.com wrote: Hi Doug, On peach-pi, I got a hung task once in 4 cold boot as [1]. OK, I'll have to get my peach-pi or peach-pit up and running again. I ran out of desk space and I haven't gotten it set back up. :( I've been