Re: [PATCH] net/macb: add support for resetting PHY using GPIO

2015-12-11 Thread Russell King - ARM Linux
On Fri, Dec 11, 2015 at 11:21:30AM +0100, Sascha Hauer wrote: > On Fri, Dec 11, 2015 at 10:40:22AM +0100, Gregory CLEMENT wrote: > > So I see 2 options: > > > > - leaving the phy-reset-gpios property in the ethernet node. Thanks to > > this we can use the gpiod functions, and it is still

Re: [PATCH] net/macb: add support for resetting PHY using GPIO

2015-12-11 Thread Sascha Hauer
On Fri, Dec 11, 2015 at 10:40:22AM +0100, Gregory CLEMENT wrote: > Hi Sascha, > > On ven., déc. 11 2015, Sascha Hauer wrote: > > > On Thu, Dec 10, 2015 at 04:08:08PM +0100, Gregory CLEMENT wrote: > >> Hi Sascha, > >> > >> On jeu., déc. 10 2015, Sascha Hauer wrote: > >> > >> > Hi Gregory,

Re: [PATCH] net/macb: add support for resetting PHY using GPIO

2015-12-11 Thread Gregory CLEMENT
Hi Sascha, On ven., déc. 11 2015, Sascha Hauer wrote: > On Thu, Dec 10, 2015 at 04:08:08PM +0100, Gregory CLEMENT wrote: >> Hi Sascha, >> >> On jeu., déc. 10 2015, Sascha Hauer wrote: >> >> > Hi Gregory, >> > >> > On Wed, Dec 09, 2015 at 06:49:43PM +0100, Gregory CLEMENT wrote: >> >>

Re: [PATCH] net/macb: add support for resetting PHY using GPIO

2015-12-11 Thread Sascha Hauer
On Thu, Dec 10, 2015 at 04:08:08PM +0100, Gregory CLEMENT wrote: > Hi Sascha, > > On jeu., déc. 10 2015, Sascha Hauer wrote: > > > Hi Gregory, > > > > On Wed, Dec 09, 2015 at 06:49:43PM +0100, Gregory CLEMENT wrote: > >> With device tree it is no more possible to reset the PHY at board > >>

Re: [PATCH] net/macb: add support for resetting PHY using GPIO

2015-12-11 Thread Gregory CLEMENT
Hi Sascha, On ven., déc. 11 2015, Sascha Hauer wrote: > On Thu, Dec 10, 2015 at 04:08:08PM +0100, Gregory CLEMENT wrote: >> Hi Sascha, >> >> On jeu., déc. 10 2015, Sascha Hauer wrote: >> >> > Hi Gregory, >> > >> > On Wed, Dec 09, 2015 at

Re: [PATCH] net/macb: add support for resetting PHY using GPIO

2015-12-11 Thread Russell King - ARM Linux
On Fri, Dec 11, 2015 at 11:21:30AM +0100, Sascha Hauer wrote: > On Fri, Dec 11, 2015 at 10:40:22AM +0100, Gregory CLEMENT wrote: > > So I see 2 options: > > > > - leaving the phy-reset-gpios property in the ethernet node. Thanks to > > this we can use the gpiod functions, and it is still

Re: [PATCH] net/macb: add support for resetting PHY using GPIO

2015-12-11 Thread Sascha Hauer
On Fri, Dec 11, 2015 at 10:40:22AM +0100, Gregory CLEMENT wrote: > Hi Sascha, > > On ven., déc. 11 2015, Sascha Hauer wrote: > > > On Thu, Dec 10, 2015 at 04:08:08PM +0100, Gregory CLEMENT wrote: > >> Hi Sascha, > >> > >> On jeu., déc. 10 2015, Sascha Hauer

Re: [PATCH] net/macb: add support for resetting PHY using GPIO

2015-12-11 Thread Sascha Hauer
On Thu, Dec 10, 2015 at 04:08:08PM +0100, Gregory CLEMENT wrote: > Hi Sascha, > > On jeu., déc. 10 2015, Sascha Hauer wrote: > > > Hi Gregory, > > > > On Wed, Dec 09, 2015 at 06:49:43PM +0100, Gregory CLEMENT wrote: > >> With device tree it is no more possible to reset

Re: [PATCH] net/macb: add support for resetting PHY using GPIO

2015-12-10 Thread Gregory CLEMENT
Hi Sascha, On jeu., déc. 10 2015, Sascha Hauer wrote: > Hi Gregory, > > On Wed, Dec 09, 2015 at 06:49:43PM +0100, Gregory CLEMENT wrote: >> With device tree it is no more possible to reset the PHY at board >> level. Furthermore, doing in the driver allow to power down the PHY when >> the

Re: [PATCH] net/macb: add support for resetting PHY using GPIO

2015-12-10 Thread Gregory CLEMENT
Hi Sascha, On jeu., déc. 10 2015, Sascha Hauer wrote: > Hi Gregory, > > On Wed, Dec 09, 2015 at 06:49:43PM +0100, Gregory CLEMENT wrote: >> With device tree it is no more possible to reset the PHY at board >> level. Furthermore, doing in the driver allow to power down

Re: [PATCH] net/macb: add support for resetting PHY using GPIO

2015-12-09 Thread Sascha Hauer
Hi Gregory, On Wed, Dec 09, 2015 at 06:49:43PM +0100, Gregory CLEMENT wrote: > With device tree it is no more possible to reset the PHY at board > level. Furthermore, doing in the driver allow to power down the PHY when > the network interface is no more used. > > The patch introduces a new

Re: [PATCH] net/macb: add support for resetting PHY using GPIO

2015-12-09 Thread kbuild test robot
Hi Gregory, [auto build test ERROR on net-next/master] [also build test ERROR on v4.4-rc4 next-20151209] url: https://github.com/0day-ci/linux/commits/Gregory-CLEMENT/net-macb-add-support-for-resetting-PHY-using-GPIO/20151210-015931 config: x86_64-acpi-redef (attached as .config) reproduce:

Re: [PATCH] net/macb: add support for resetting PHY using GPIO

2015-12-09 Thread Moritz Fischer
Hi Gregory, so far dealt with this in u-boot. The power down the PHY part makes sense, though. Minor nit down inline. Will need to test on hardware (Zynq). On Wed, Dec 9, 2015 at 9:49 AM, Gregory CLEMENT wrote: > With device tree it is no more possible to reset the PHY at board > level.

Re: [PATCH] net/macb: add support for resetting PHY using GPIO

2015-12-09 Thread Andrew Lunn
On Wed, Dec 09, 2015 at 06:49:43PM +0100, Gregory CLEMENT wrote: > With device tree it is no more possible to reset the PHY at board > level. Furthermore, doing in the driver allow to power down the PHY when > the network interface is no more used. > > The patch introduces a new optional property

Re: [PATCH] net/macb: add support for resetting PHY using GPIO

2015-12-09 Thread kbuild test robot
Hi Gregory, [auto build test ERROR on net-next/master] [also build test ERROR on v4.4-rc4 next-20151209] url: https://github.com/0day-ci/linux/commits/Gregory-CLEMENT/net-macb-add-support-for-resetting-PHY-using-GPIO/20151210-015931 config: x86_64-acpi-redef (attached as .config) reproduce:

Re: [PATCH] net/macb: add support for resetting PHY using GPIO

2015-12-09 Thread Andrew Lunn
On Wed, Dec 09, 2015 at 06:49:43PM +0100, Gregory CLEMENT wrote: > With device tree it is no more possible to reset the PHY at board > level. Furthermore, doing in the driver allow to power down the PHY when > the network interface is no more used. > > The patch introduces a new optional property

Re: [PATCH] net/macb: add support for resetting PHY using GPIO

2015-12-09 Thread Moritz Fischer
Hi Gregory, so far dealt with this in u-boot. The power down the PHY part makes sense, though. Minor nit down inline. Will need to test on hardware (Zynq). On Wed, Dec 9, 2015 at 9:49 AM, Gregory CLEMENT wrote: > With device tree it is no more possible to

Re: [PATCH] net/macb: add support for resetting PHY using GPIO

2015-12-09 Thread Sascha Hauer
Hi Gregory, On Wed, Dec 09, 2015 at 06:49:43PM +0100, Gregory CLEMENT wrote: > With device tree it is no more possible to reset the PHY at board > level. Furthermore, doing in the driver allow to power down the PHY when > the network interface is no more used. > > The patch introduces a new