Re: [PATCH] net-sysfs: Report link speed only when possible

2014-06-16 Thread Jiri Pirko
Mon, Jun 16, 2014 at 10:44:30AM CEST, da...@davemloft.net wrote: >From: Michal Privoznik >Date: Mon, 16 Jun 2014 10:30:27 +0200 > >> On 16.06.2014 10:11, David Miller wrote: >>> From: Michal Privoznik >>> Date: Mon, 16 Jun 2014 09:32:35 +0200 >>> On 13.06.2014 22:03, David Miller wrote:

Re: [PATCH] net-sysfs: Report link speed only when possible

2014-06-16 Thread Michal Privoznik
On 16.06.2014 10:44, David Miller wrote: From: Michal Privoznik Date: Mon, 16 Jun 2014 10:30:27 +0200 On 16.06.2014 10:11, David Miller wrote: From: Michal Privoznik Date: Mon, 16 Jun 2014 09:32:35 +0200 On 13.06.2014 22:03, David Miller wrote: From: Michal Privoznik Date: Fri, 13 Jun

Re: [PATCH] net-sysfs: Report link speed only when possible

2014-06-16 Thread David Miller
From: Michal Privoznik Date: Mon, 16 Jun 2014 10:30:27 +0200 > On 16.06.2014 10:11, David Miller wrote: >> From: Michal Privoznik >> Date: Mon, 16 Jun 2014 09:32:35 +0200 >> >>> On 13.06.2014 22:03, David Miller wrote: From: Michal Privoznik Date: Fri, 13 Jun 2014 11:19:51 +0200

Re: [PATCH] net-sysfs: Report link speed only when possible

2014-06-16 Thread Michal Privoznik
On 16.06.2014 10:11, David Miller wrote: From: Michal Privoznik Date: Mon, 16 Jun 2014 09:32:35 +0200 On 13.06.2014 22:03, David Miller wrote: From: Michal Privoznik Date: Fri, 13 Jun 2014 11:19:51 +0200 So if I were developing brand new application I could say: I'm dropping all this

Re: [PATCH] net-sysfs: Report link speed only when possible

2014-06-16 Thread David Miller
From: Michal Privoznik Date: Mon, 16 Jun 2014 09:32:35 +0200 > On 13.06.2014 22:03, David Miller wrote: >> From: Michal Privoznik >> Date: Fri, 13 Jun 2014 11:19:51 +0200 >> >>> So if I were developing brand new application I could say: I'm >>> dropping all this workaround code and have it

Re: [PATCH] net-sysfs: Report link speed only when possible

2014-06-16 Thread Michal Privoznik
On 13.06.2014 22:03, David Miller wrote: From: Michal Privoznik Date: Fri, 13 Jun 2014 11:19:51 +0200 So if I were developing brand new application I could say: I'm dropping all this workaround code and have it clean and require say 3.16 kernel at least. Then your application wouldn't be

Re: [PATCH] net-sysfs: Report link speed only when possible

2014-06-16 Thread Michal Privoznik
On 13.06.2014 22:03, David Miller wrote: From: Michal Privoznik mpriv...@redhat.com Date: Fri, 13 Jun 2014 11:19:51 +0200 So if I were developing brand new application I could say: I'm dropping all this workaround code and have it clean and require say 3.16 kernel at least. Then your

Re: [PATCH] net-sysfs: Report link speed only when possible

2014-06-16 Thread David Miller
From: Michal Privoznik mpriv...@redhat.com Date: Mon, 16 Jun 2014 09:32:35 +0200 On 13.06.2014 22:03, David Miller wrote: From: Michal Privoznik mpriv...@redhat.com Date: Fri, 13 Jun 2014 11:19:51 +0200 So if I were developing brand new application I could say: I'm dropping all this

Re: [PATCH] net-sysfs: Report link speed only when possible

2014-06-16 Thread Michal Privoznik
On 16.06.2014 10:11, David Miller wrote: From: Michal Privoznik mpriv...@redhat.com Date: Mon, 16 Jun 2014 09:32:35 +0200 On 13.06.2014 22:03, David Miller wrote: From: Michal Privoznik mpriv...@redhat.com Date: Fri, 13 Jun 2014 11:19:51 +0200 So if I were developing brand new application I

Re: [PATCH] net-sysfs: Report link speed only when possible

2014-06-16 Thread David Miller
From: Michal Privoznik mpriv...@redhat.com Date: Mon, 16 Jun 2014 10:30:27 +0200 On 16.06.2014 10:11, David Miller wrote: From: Michal Privoznik mpriv...@redhat.com Date: Mon, 16 Jun 2014 09:32:35 +0200 On 13.06.2014 22:03, David Miller wrote: From: Michal Privoznik mpriv...@redhat.com

Re: [PATCH] net-sysfs: Report link speed only when possible

2014-06-16 Thread Michal Privoznik
On 16.06.2014 10:44, David Miller wrote: From: Michal Privoznik mpriv...@redhat.com Date: Mon, 16 Jun 2014 10:30:27 +0200 On 16.06.2014 10:11, David Miller wrote: From: Michal Privoznik mpriv...@redhat.com Date: Mon, 16 Jun 2014 09:32:35 +0200 On 13.06.2014 22:03, David Miller wrote: From:

Re: [PATCH] net-sysfs: Report link speed only when possible

2014-06-16 Thread Jiri Pirko
Mon, Jun 16, 2014 at 10:44:30AM CEST, da...@davemloft.net wrote: From: Michal Privoznik mpriv...@redhat.com Date: Mon, 16 Jun 2014 10:30:27 +0200 On 16.06.2014 10:11, David Miller wrote: From: Michal Privoznik mpriv...@redhat.com Date: Mon, 16 Jun 2014 09:32:35 +0200 On 13.06.2014 22:03,

Re: [PATCH] net-sysfs: Report link speed only when possible

2014-06-13 Thread David Miller
From: Michal Privoznik Date: Fri, 13 Jun 2014 11:19:51 +0200 > So if I were developing brand new application I could say: I'm > dropping all this workaround code and have it clean and require say > 3.16 kernel at least. Then your application wouldn't be usable on %99 of systems for a long long

Re: [PATCH] net-sysfs: Report link speed only when possible

2014-06-13 Thread Michal Privoznik
On 06.06.2014 21:54, David Miller wrote: From: Jiri Pirko Date: Fri, 6 Jun 2014 10:57:33 +0200 Fri, Jun 06, 2014 at 10:40:30AM CEST, mpriv...@redhat.com wrote: The link speed is available at /sys/class/net/$nic/speed. However, in some cases, depending on the driver, if the link is not

Re: [PATCH] net-sysfs: Report link speed only when possible

2014-06-13 Thread Michal Privoznik
On 06.06.2014 21:54, David Miller wrote: From: Jiri Pirko j...@resnulli.us Date: Fri, 6 Jun 2014 10:57:33 +0200 Fri, Jun 06, 2014 at 10:40:30AM CEST, mpriv...@redhat.com wrote: The link speed is available at /sys/class/net/$nic/speed. However, in some cases, depending on the driver, if the

Re: [PATCH] net-sysfs: Report link speed only when possible

2014-06-13 Thread David Miller
From: Michal Privoznik mpriv...@redhat.com Date: Fri, 13 Jun 2014 11:19:51 +0200 So if I were developing brand new application I could say: I'm dropping all this workaround code and have it clean and require say 3.16 kernel at least. Then your application wouldn't be usable on %99 of systems

Re: [PATCH] net-sysfs: Report link speed only when possible

2014-06-06 Thread David Miller
From: Jiri Pirko Date: Fri, 6 Jun 2014 10:57:33 +0200 > Fri, Jun 06, 2014 at 10:40:30AM CEST, mpriv...@redhat.com wrote: >>The link speed is available at /sys/class/net/$nic/speed. >>However, in some cases, depending on the driver, if the link is >>not plugged, -1 is reported (this is the case

Re: [PATCH] net-sysfs: Report link speed only when possible

2014-06-06 Thread Jiri Pirko
Fri, Jun 06, 2014 at 10:40:30AM CEST, mpriv...@redhat.com wrote: >The link speed is available at /sys/class/net/$nic/speed. >However, in some cases, depending on the driver, if the link is >not plugged, -1 is reported (this is the case of e1000e for >instance). To make things worse, the value is

Re: [PATCH] net-sysfs: Report link speed only when possible

2014-06-06 Thread Jiri Pirko
Fri, Jun 06, 2014 at 10:40:30AM CEST, mpriv...@redhat.com wrote: The link speed is available at /sys/class/net/$nic/speed. However, in some cases, depending on the driver, if the link is not plugged, -1 is reported (this is the case of e1000e for instance). To make things worse, the value is

Re: [PATCH] net-sysfs: Report link speed only when possible

2014-06-06 Thread David Miller
From: Jiri Pirko j...@resnulli.us Date: Fri, 6 Jun 2014 10:57:33 +0200 Fri, Jun 06, 2014 at 10:40:30AM CEST, mpriv...@redhat.com wrote: The link speed is available at /sys/class/net/$nic/speed. However, in some cases, depending on the driver, if the link is not plugged, -1 is reported (this is