Re: [PATCH] of/platform: Fix no irq domain found errors when populating interrupts

2014-04-18 Thread Russell King - ARM Linux
On Fri, Apr 18, 2014 at 02:37:51PM -0700, Tony Lindgren wrote: > * Thierry Reding [140411 11:40]: > > On Fri, Apr 11, 2014 at 10:20:28AM +0100, Russell King - ARM Linux wrote: > > > So what happens if a device driver probe function: > > > > > > - creates a new platform device > > > - copies the r

Re: [PATCH] of/platform: Fix no irq domain found errors when populating interrupts

2014-04-18 Thread Tony Lindgren
* Thierry Reding [140411 11:40]: > On Fri, Apr 11, 2014 at 10:20:28AM +0100, Russell King - ARM Linux wrote: > > On Thu, Apr 10, 2014 at 02:38:09PM -0700, Tony Lindgren wrote: > > > Currently we get the following kind of errors if we try to use interrupt > > > phandles to irqchips that have not ye

Re: [PATCH] of/platform: Fix no irq domain found errors when populating interrupts

2014-04-18 Thread Tony Lindgren
* Thierry Reding [140411 11:46]: > On Thu, Apr 10, 2014 at 07:29:36PM -0500, Rob Herring wrote: > > On Thu, Apr 10, 2014 at 4:38 PM, Tony Lindgren wrote: > > > Currently we get the following kind of errors if we try to use interrupt > > > phandles to irqchips that have not yet initialized: > > >

Re: [PATCH] of/platform: Fix no irq domain found errors when populating interrupts

2014-04-11 Thread Thierry Reding
On Thu, Apr 10, 2014 at 07:29:36PM -0500, Rob Herring wrote: > On Thu, Apr 10, 2014 at 4:38 PM, Tony Lindgren wrote: > > Currently we get the following kind of errors if we try to use interrupt > > phandles to irqchips that have not yet initialized: > > > > irq: no irq domain found for /ocp/pinmux

Re: [PATCH] of/platform: Fix no irq domain found errors when populating interrupts

2014-04-11 Thread Thierry Reding
On Fri, Apr 11, 2014 at 10:20:28AM +0100, Russell King - ARM Linux wrote: > On Thu, Apr 10, 2014 at 02:38:09PM -0700, Tony Lindgren wrote: > > Currently we get the following kind of errors if we try to use interrupt > > phandles to irqchips that have not yet initialized: > > > > irq: no irq domain

Re: [PATCH] of/platform: Fix no irq domain found errors when populating interrupts

2014-04-11 Thread Russell King - ARM Linux
On Thu, Apr 10, 2014 at 02:38:09PM -0700, Tony Lindgren wrote: > Currently we get the following kind of errors if we try to use interrupt > phandles to irqchips that have not yet initialized: > > irq: no irq domain found for /ocp/pinmux@48002030 ! > [ cut here ] > WARNING:

Re: [PATCH] of/platform: Fix no irq domain found errors when populating interrupts

2014-04-10 Thread Rob Herring
On Thu, Apr 10, 2014 at 4:38 PM, Tony Lindgren wrote: > Currently we get the following kind of errors if we try to use interrupt > phandles to irqchips that have not yet initialized: > > irq: no irq domain found for /ocp/pinmux@48002030 ! > [ cut here ] > WARNING: CPU: 0 PI

Re: [PATCH] of/platform: Fix no irq domain found errors when populating interrupts

2014-01-07 Thread Tony Lindgren
* Paul Walmsley [140106 15:43]: > On Tue, 31 Dec 2013, Rob Herring wrote: > > On Mon, Dec 30, 2013 at 4:10 PM, Paul Walmsley wrote: > > > On Tue, 10 Dec 2013, Paul Walmsley wrote: > > >> Is it possible to get this patch, or something similar, merged for > > >> v3.13-rc? > > >> > > >> Once somethi

Re: [PATCH] of/platform: Fix no irq domain found errors when populating interrupts

2014-01-06 Thread Paul Walmsley
Hi Tony, Rob, On Tue, 31 Dec 2013, Rob Herring wrote: > On Mon, Dec 30, 2013 at 4:10 PM, Paul Walmsley wrote: > > Hi Grant, Rob, > > > > On Tue, 10 Dec 2013, Paul Walmsley wrote: > > > >> On Sun, 24 Nov 2013, Grant Likely wrote: > >> > >> > On Fri, 22 Nov 2013 17:50:35 -0800, Tony Lindgren > >

Re: [PATCH] of/platform: Fix no irq domain found errors when populating interrupts

2013-12-31 Thread Rob Herring
On Mon, Dec 30, 2013 at 4:10 PM, Paul Walmsley wrote: > Hi Grant, Rob, > > On Tue, 10 Dec 2013, Paul Walmsley wrote: > >> On Sun, 24 Nov 2013, Grant Likely wrote: >> >> > On Fri, 22 Nov 2013 17:50:35 -0800, Tony Lindgren wrote: >> > > * Tony Lindgren [131122 17:16]: >> > > > * Tony Lindgren [13

Re: [PATCH] of/platform: Fix no irq domain found errors when populating interrupts

2013-12-30 Thread Paul Walmsley
Hi Grant, Rob, On Tue, 10 Dec 2013, Paul Walmsley wrote: > On Sun, 24 Nov 2013, Grant Likely wrote: > > > On Fri, 22 Nov 2013 17:50:35 -0800, Tony Lindgren wrote: > > > * Tony Lindgren [131122 17:16]: > > > > * Tony Lindgren [131122 17:09]: > > > > > * Russell King - ARM Linux [131122 16:56]

Re: [PATCH] of/platform: Fix no irq domain found errors when populating interrupts

2013-12-11 Thread Tony Lindgren
* Thierry Reding [131211 07:14]: > > So how about we make the platform_get_irq() modification for starters, > so that the OMAP issues can be resolved and then turn our attention to > coming up with a more generic approach. If indeed we end up with what > you're proposing we can easily switch plat

Re: [PATCH] of/platform: Fix no irq domain found errors when populating interrupts

2013-12-11 Thread Thierry Reding
On Wed, Dec 11, 2013 at 01:45:53PM +, Grant Likely wrote: > On Thu, 28 Nov 2013 16:46:23 +0100, Thierry Reding > wrote: > > On Wed, Nov 27, 2013 at 03:56:29PM +, Grant Likely wrote: > > > On Mon, 25 Nov 2013 10:49:55 +0100, Thierry Reding > > > wrote: > > > > > > > > I should maybe add

Re: [PATCH] of/platform: Fix no irq domain found errors when populating interrupts

2013-12-11 Thread Grant Likely
On Thu, 28 Nov 2013 16:46:23 +0100, Thierry Reding wrote: > On Wed, Nov 27, 2013 at 03:56:29PM +, Grant Likely wrote: > > On Mon, 25 Nov 2013 10:49:55 +0100, Thierry Reding > > wrote: > > > > > > I should maybe add: one issue that was raised during review of my > > > initial patch series w

Re: [PATCH] of/platform: Fix no irq domain found errors when populating interrupts

2013-12-09 Thread Paul Walmsley
Hi Grant, Rob, On Sun, 24 Nov 2013, Grant Likely wrote: > On Fri, 22 Nov 2013 17:50:35 -0800, Tony Lindgren wrote: > > * Tony Lindgren [131122 17:16]: > > > * Tony Lindgren [131122 17:09]: > > > > * Russell King - ARM Linux [131122 16:56]: > > > > > On Fri, Nov 22, 2013 at 04:43:35PM -0800, T

Re: [PATCH] of/platform: Fix no irq domain found errors when populating interrupts

2013-11-28 Thread Thierry Reding
On Wed, Nov 27, 2013 at 03:56:29PM +, Grant Likely wrote: > On Mon, 25 Nov 2013 10:49:55 +0100, Thierry Reding > wrote: > > On Mon, Nov 25, 2013 at 10:25:50AM +0100, Thierry Reding wrote: > > > On Sun, Nov 24, 2013 at 09:36:51PM +, Grant Likely wrote: > > > > On Fri, 22 Nov 2013 16:43:35

Re: [PATCH] of/platform: Fix no irq domain found errors when populating interrupts

2013-11-27 Thread Tony Lindgren
* Grant Likely [131124 13:37]: > > I actually like the idea of completely allocating the resource structure > but leaving some entries empty. However, I agree with rmk that putting > garbage into a resource structure is a bad idea. What about changing the > value of flags to 0 or some other value

Re: [PATCH] of/platform: Fix no irq domain found errors when populating interrupts

2013-11-27 Thread Grant Likely
On Mon, 25 Nov 2013 10:49:55 +0100, Thierry Reding wrote: > On Mon, Nov 25, 2013 at 10:25:50AM +0100, Thierry Reding wrote: > > On Sun, Nov 24, 2013 at 09:36:51PM +, Grant Likely wrote: > > > On Fri, 22 Nov 2013 16:43:35 -0800, Tony Lindgren > > > wrote: > > > > Currently we get the followi

Re: [PATCH] of/platform: Fix no irq domain found errors when populating interrupts

2013-11-27 Thread Grant Likely
On Mon, 25 Nov 2013 10:25:50 +0100, Thierry Reding wrote: > On Sun, Nov 24, 2013 at 09:36:51PM +, Grant Likely wrote: > > On Fri, 22 Nov 2013 16:43:35 -0800, Tony Lindgren wrote: > > > Currently we get the following kind of errors if we try to use > > > interrupt phandles to irqchips that ha

Re: [PATCH] of/platform: Fix no irq domain found errors when populating interrupts

2013-11-25 Thread Tony Lindgren
* Thierry Reding [131125 01:51]: > On Mon, Nov 25, 2013 at 10:25:50AM +0100, Thierry Reding wrote: > > On Sun, Nov 24, 2013 at 09:36:51PM +, Grant Likely wrote: > > > > > > I actually like the idea of completely allocating the resource structure > > > but leaving some entries empty. However,

Re: [PATCH] of/platform: Fix no irq domain found errors when populating interrupts

2013-11-25 Thread Tony Lindgren
* Thierry Reding [131125 01:36]: > On Sat, Nov 23, 2013 at 08:32:40AM -0800, Tony Lindgren wrote: > > * Rob Herring [131123 07:43]: > > > On Fri, Nov 22, 2013 at 7:50 PM, Tony Lindgren wrote: > > > > * Tony Lindgren [131122 17:16]: > > > >> * Tony Lindgren [131122 17:09]: > > > >> > * Russell

Re: [PATCH] of/platform: Fix no irq domain found errors when populating interrupts

2013-11-25 Thread Thierry Reding
On Mon, Nov 25, 2013 at 10:25:50AM +0100, Thierry Reding wrote: > On Sun, Nov 24, 2013 at 09:36:51PM +, Grant Likely wrote: > > On Fri, 22 Nov 2013 16:43:35 -0800, Tony Lindgren wrote: > > > Currently we get the following kind of errors if we try to use > > > interrupt phandles to irqchips tha

Re: [PATCH] of/platform: Fix no irq domain found errors when populating interrupts

2013-11-25 Thread Thierry Reding
On Sat, Nov 23, 2013 at 08:32:40AM -0800, Tony Lindgren wrote: > * Rob Herring [131123 07:43]: > > On Fri, Nov 22, 2013 at 7:50 PM, Tony Lindgren wrote: > > > * Tony Lindgren [131122 17:16]: > > >> * Tony Lindgren [131122 17:09]: > > >> > * Russell King - ARM Linux [131122 16:56]: > > >> > > O

Re: [PATCH] of/platform: Fix no irq domain found errors when populating interrupts

2013-11-25 Thread Thierry Reding
On Sun, Nov 24, 2013 at 09:36:51PM +, Grant Likely wrote: > On Fri, 22 Nov 2013 16:43:35 -0800, Tony Lindgren wrote: > > Currently we get the following kind of errors if we try to use > > interrupt phandles to irqchips that have not yet initialized: > > > > irq: no irq domain found for /ocp/p

Re: [PATCH] of/platform: Fix no irq domain found errors when populating interrupts

2013-11-24 Thread Grant Likely
On Fri, 22 Nov 2013 16:43:35 -0800, Tony Lindgren wrote: > Currently we get the following kind of errors if we try to use > interrupt phandles to irqchips that have not yet initialized: > > irq: no irq domain found for /ocp/pinmux@48002030 ! > WARNING: CPU: 0 PID: 1 at drivers/of/platform.c:171

Re: [PATCH] of/platform: Fix no irq domain found errors when populating interrupts

2013-11-24 Thread Grant Likely
On Fri, 22 Nov 2013 17:50:35 -0800, Tony Lindgren wrote: > * Tony Lindgren [131122 17:16]: > > * Tony Lindgren [131122 17:09]: > > > * Russell King - ARM Linux [131122 16:56]: > > > > On Fri, Nov 22, 2013 at 04:43:35PM -0800, Tony Lindgren wrote: > > > > > + /* See of_device_resourc

Re: [PATCH] of/platform: Fix no irq domain found errors when populating interrupts

2013-11-23 Thread Tony Lindgren
* Rob Herring [131123 07:43]: > On Fri, Nov 22, 2013 at 7:50 PM, Tony Lindgren wrote: > > * Tony Lindgren [131122 17:16]: > >> * Tony Lindgren [131122 17:09]: > >> > * Russell King - ARM Linux [131122 16:56]: > >> > > On Fri, Nov 22, 2013 at 04:43:35PM -0800, Tony Lindgren wrote: > >> > > > +

Re: [PATCH] of/platform: Fix no irq domain found errors when populating interrupts

2013-11-23 Thread Rob Herring
On Fri, Nov 22, 2013 at 7:50 PM, Tony Lindgren wrote: > * Tony Lindgren [131122 17:16]: >> * Tony Lindgren [131122 17:09]: >> > * Russell King - ARM Linux [131122 16:56]: >> > > On Fri, Nov 22, 2013 at 04:43:35PM -0800, Tony Lindgren wrote: >> > > > + /* See of_device_resource_not

Re: [PATCH] of/platform: Fix no irq domain found errors when populating interrupts

2013-11-22 Thread Tony Lindgren
* Tony Lindgren [131122 17:16]: > * Tony Lindgren [131122 17:09]: > > * Russell King - ARM Linux [131122 16:56]: > > > On Fri, Nov 22, 2013 at 04:43:35PM -0800, Tony Lindgren wrote: > > > > + /* See of_device_resource_notify for populating > > > > interrupts */ > > > > +

Re: [PATCH] of/platform: Fix no irq domain found errors when populating interrupts

2013-11-22 Thread Tony Lindgren
* Tony Lindgren [131122 17:09]: > * Russell King - ARM Linux [131122 16:56]: > > On Fri, Nov 22, 2013 at 04:43:35PM -0800, Tony Lindgren wrote: > > > + /* See of_device_resource_notify for populating interrupts */ > > > + for (i = 0; i < num_irq; i++, res++) { > > > +

Re: [PATCH] of/platform: Fix no irq domain found errors when populating interrupts

2013-11-22 Thread Tony Lindgren
* Russell King - ARM Linux [131122 16:56]: > On Fri, Nov 22, 2013 at 04:43:35PM -0800, Tony Lindgren wrote: > > + /* See of_device_resource_notify for populating interrupts */ > > + for (i = 0; i < num_irq; i++, res++) { > > + res->flags = IORESOURCE_IRQ; > >

Re: [PATCH] of/platform: Fix no irq domain found errors when populating interrupts

2013-11-22 Thread Tony Lindgren
* Tony Lindgren [131122 16:44]: > @@ -168,7 +218,13 @@ struct platform_device *of_device_alloc(struct > device_node *np, > rc = of_address_to_resource(np, i, res); > WARN_ON(rc); > } > - WARN_ON(of_irq_to_resource_table(np, res

Re: [PATCH] of/platform: Fix no irq domain found errors when populating interrupts

2013-11-22 Thread Russell King - ARM Linux
On Fri, Nov 22, 2013 at 04:43:35PM -0800, Tony Lindgren wrote: > + /* See of_device_resource_notify for populating interrupts */ > + for (i = 0; i < num_irq; i++, res++) { > + res->flags = IORESOURCE_IRQ; > + res->start = -EPROBE_DEFER