Re: [PATCH] pstore/ram: Clarify resource reservation labels

2018-10-18 Thread Kees Cook
On Thu, Oct 18, 2018 at 3:33 PM, Dan Williams wrote: > On Thu, Oct 18, 2018 at 3:26 PM Kees Cook wrote: >> >> On Thu, Oct 18, 2018 at 3:23 PM, Dan Williams >> wrote: >> > On Thu, Oct 18, 2018 at 3:19 PM Kees Cook wrote: >> >> >> >> On Thu, Oct 18, 2018 at 2:35 PM, Dan Williams >> >> wrote:

Re: [PATCH] pstore/ram: Clarify resource reservation labels

2018-10-18 Thread Kees Cook
On Thu, Oct 18, 2018 at 3:33 PM, Dan Williams wrote: > On Thu, Oct 18, 2018 at 3:26 PM Kees Cook wrote: >> >> On Thu, Oct 18, 2018 at 3:23 PM, Dan Williams >> wrote: >> > On Thu, Oct 18, 2018 at 3:19 PM Kees Cook wrote: >> >> >> >> On Thu, Oct 18, 2018 at 2:35 PM, Dan Williams >> >> wrote:

Re: [PATCH] pstore/ram: Clarify resource reservation labels

2018-10-18 Thread Dan Williams
On Thu, Oct 18, 2018 at 3:43 PM Luck, Tony wrote: > > > If the filesystem existed on the namespace before the user specified > > the ramoops command line then ramoops will clobber the filesystem and > > the user will only find out when mount later fails. All the kernel > > will say is: > > > >

Re: [PATCH] pstore/ram: Clarify resource reservation labels

2018-10-18 Thread Dan Williams
On Thu, Oct 18, 2018 at 3:43 PM Luck, Tony wrote: > > > If the filesystem existed on the namespace before the user specified > > the ramoops command line then ramoops will clobber the filesystem and > > the user will only find out when mount later fails. All the kernel > > will say is: > > > >

RE: [PATCH] pstore/ram: Clarify resource reservation labels

2018-10-18 Thread Luck, Tony
> If the filesystem existed on the namespace before the user specified > the ramoops command line then ramoops will clobber the filesystem and > the user will only find out when mount later fails. All the kernel > will say is: > > dev_warn(dev, "could not reserve region %pR\n", res); > >

RE: [PATCH] pstore/ram: Clarify resource reservation labels

2018-10-18 Thread Luck, Tony
> If the filesystem existed on the namespace before the user specified > the ramoops command line then ramoops will clobber the filesystem and > the user will only find out when mount later fails. All the kernel > will say is: > > dev_warn(dev, "could not reserve region %pR\n", res); > >

Re: [PATCH] pstore/ram: Clarify resource reservation labels

2018-10-18 Thread Dan Williams
On Thu, Oct 18, 2018 at 3:26 PM Kees Cook wrote: > > On Thu, Oct 18, 2018 at 3:23 PM, Dan Williams > wrote: > > On Thu, Oct 18, 2018 at 3:19 PM Kees Cook wrote: > >> > >> On Thu, Oct 18, 2018 at 2:35 PM, Dan Williams > >> wrote: > >> > On Thu, Oct 18, 2018 at 1:31 PM Kees Cook wrote: > >

Re: [PATCH] pstore/ram: Clarify resource reservation labels

2018-10-18 Thread Dan Williams
On Thu, Oct 18, 2018 at 3:26 PM Kees Cook wrote: > > On Thu, Oct 18, 2018 at 3:23 PM, Dan Williams > wrote: > > On Thu, Oct 18, 2018 at 3:19 PM Kees Cook wrote: > >> > >> On Thu, Oct 18, 2018 at 2:35 PM, Dan Williams > >> wrote: > >> > On Thu, Oct 18, 2018 at 1:31 PM Kees Cook wrote: > >

Re: [PATCH] pstore/ram: Clarify resource reservation labels

2018-10-18 Thread Kees Cook
On Thu, Oct 18, 2018 at 3:23 PM, Dan Williams wrote: > On Thu, Oct 18, 2018 at 3:19 PM Kees Cook wrote: >> >> On Thu, Oct 18, 2018 at 2:35 PM, Dan Williams >> wrote: >> > On Thu, Oct 18, 2018 at 1:31 PM Kees Cook wrote: > [..] >> > I cringe at users picking addresses because someone is going

Re: [PATCH] pstore/ram: Clarify resource reservation labels

2018-10-18 Thread Kees Cook
On Thu, Oct 18, 2018 at 3:23 PM, Dan Williams wrote: > On Thu, Oct 18, 2018 at 3:19 PM Kees Cook wrote: >> >> On Thu, Oct 18, 2018 at 2:35 PM, Dan Williams >> wrote: >> > On Thu, Oct 18, 2018 at 1:31 PM Kees Cook wrote: > [..] >> > I cringe at users picking addresses because someone is going

Re: [PATCH] pstore/ram: Clarify resource reservation labels

2018-10-18 Thread Dan Williams
On Thu, Oct 18, 2018 at 3:19 PM Kees Cook wrote: > > On Thu, Oct 18, 2018 at 2:35 PM, Dan Williams > wrote: > > On Thu, Oct 18, 2018 at 1:31 PM Kees Cook wrote: [..] > > I cringe at users picking addresses because someone is going to enable > > ramoops on top of their persistent memory

Re: [PATCH] pstore/ram: Clarify resource reservation labels

2018-10-18 Thread Dan Williams
On Thu, Oct 18, 2018 at 3:19 PM Kees Cook wrote: > > On Thu, Oct 18, 2018 at 2:35 PM, Dan Williams > wrote: > > On Thu, Oct 18, 2018 at 1:31 PM Kees Cook wrote: [..] > > I cringe at users picking addresses because someone is going to enable > > ramoops on top of their persistent memory

Re: [PATCH] pstore/ram: Clarify resource reservation labels

2018-10-18 Thread Kees Cook
On Thu, Oct 18, 2018 at 2:35 PM, Dan Williams wrote: > On Thu, Oct 18, 2018 at 1:31 PM Kees Cook wrote: >> >> On Thu, Oct 18, 2018 at 8:33 AM, Dan Williams >> wrote: >> > [ add Ross ] >> >> Hi Ross! :) >> >> > On Thu, Oct 18, 2018 at 12:15 AM Kees Cook wrote: >> >> As for nvdimm specifically,

Re: [PATCH] pstore/ram: Clarify resource reservation labels

2018-10-18 Thread Kees Cook
On Thu, Oct 18, 2018 at 2:35 PM, Dan Williams wrote: > On Thu, Oct 18, 2018 at 1:31 PM Kees Cook wrote: >> >> On Thu, Oct 18, 2018 at 8:33 AM, Dan Williams >> wrote: >> > [ add Ross ] >> >> Hi Ross! :) >> >> > On Thu, Oct 18, 2018 at 12:15 AM Kees Cook wrote: >> >> As for nvdimm specifically,

Re: [PATCH] pstore/ram: Clarify resource reservation labels

2018-10-18 Thread Dan Williams
On Thu, Oct 18, 2018 at 1:31 PM Kees Cook wrote: > > On Thu, Oct 18, 2018 at 8:33 AM, Dan Williams > wrote: > > [ add Ross ] > > Hi Ross! :) > > > On Thu, Oct 18, 2018 at 12:15 AM Kees Cook wrote: > >> As for nvdimm specifically, yes, I'd love to get pstore hooked up > >> correctly to nvdimm.

Re: [PATCH] pstore/ram: Clarify resource reservation labels

2018-10-18 Thread Dan Williams
On Thu, Oct 18, 2018 at 1:31 PM Kees Cook wrote: > > On Thu, Oct 18, 2018 at 8:33 AM, Dan Williams > wrote: > > [ add Ross ] > > Hi Ross! :) > > > On Thu, Oct 18, 2018 at 12:15 AM Kees Cook wrote: > >> As for nvdimm specifically, yes, I'd love to get pstore hooked up > >> correctly to nvdimm.

Re: [PATCH] pstore/ram: Clarify resource reservation labels

2018-10-18 Thread Kees Cook
On Thu, Oct 18, 2018 at 1:58 PM, Ross Zwisler wrote: > On Thu, Oct 18, 2018 at 2:31 PM Kees Cook wrote: >> >> On Thu, Oct 18, 2018 at 8:33 AM, Dan Williams >> wrote: >> > [ add Ross ] >> >> Hi Ross! :) >> >> > On Thu, Oct 18, 2018 at 12:15 AM Kees Cook wrote: >> >> As for nvdimm specifically,

Re: [PATCH] pstore/ram: Clarify resource reservation labels

2018-10-18 Thread Kees Cook
On Thu, Oct 18, 2018 at 1:58 PM, Ross Zwisler wrote: > On Thu, Oct 18, 2018 at 2:31 PM Kees Cook wrote: >> >> On Thu, Oct 18, 2018 at 8:33 AM, Dan Williams >> wrote: >> > [ add Ross ] >> >> Hi Ross! :) >> >> > On Thu, Oct 18, 2018 at 12:15 AM Kees Cook wrote: >> >> As for nvdimm specifically,

Re: [PATCH] pstore/ram: Clarify resource reservation labels

2018-10-18 Thread Ross Zwisler
On Thu, Oct 18, 2018 at 2:31 PM Kees Cook wrote: > > On Thu, Oct 18, 2018 at 8:33 AM, Dan Williams > wrote: > > [ add Ross ] > > Hi Ross! :) > > > On Thu, Oct 18, 2018 at 12:15 AM Kees Cook wrote: > >> As for nvdimm specifically, yes, I'd love to get pstore hooked up > >> correctly to nvdimm.

Re: [PATCH] pstore/ram: Clarify resource reservation labels

2018-10-18 Thread Ross Zwisler
On Thu, Oct 18, 2018 at 2:31 PM Kees Cook wrote: > > On Thu, Oct 18, 2018 at 8:33 AM, Dan Williams > wrote: > > [ add Ross ] > > Hi Ross! :) > > > On Thu, Oct 18, 2018 at 12:15 AM Kees Cook wrote: > >> As for nvdimm specifically, yes, I'd love to get pstore hooked up > >> correctly to nvdimm.

Re: [PATCH] pstore/ram: Clarify resource reservation labels

2018-10-18 Thread Kees Cook
On Thu, Oct 18, 2018 at 8:33 AM, Dan Williams wrote: > [ add Ross ] Hi Ross! :) > On Thu, Oct 18, 2018 at 12:15 AM Kees Cook wrote: >> As for nvdimm specifically, yes, I'd love to get pstore hooked up >> correctly to nvdimm. How do the namespaces work? Right now pstore >> depends one of

Re: [PATCH] pstore/ram: Clarify resource reservation labels

2018-10-18 Thread Kees Cook
On Thu, Oct 18, 2018 at 8:33 AM, Dan Williams wrote: > [ add Ross ] Hi Ross! :) > On Thu, Oct 18, 2018 at 12:15 AM Kees Cook wrote: >> As for nvdimm specifically, yes, I'd love to get pstore hooked up >> correctly to nvdimm. How do the namespaces work? Right now pstore >> depends one of

Re: [PATCH] pstore/ram: Clarify resource reservation labels

2018-10-18 Thread Dan Williams
[ add Ross ] On Thu, Oct 18, 2018 at 12:15 AM Kees Cook wrote: > > On Wed, Oct 17, 2018 at 5:49 PM, Dan Williams > wrote: > > On Wed, Oct 17, 2018 at 5:29 PM Kees Cook wrote: > >> > >> When ramoops reserved a memory region in the kernel, it had an unhelpful > >> label of "persistent_memory".

Re: [PATCH] pstore/ram: Clarify resource reservation labels

2018-10-18 Thread Dan Williams
[ add Ross ] On Thu, Oct 18, 2018 at 12:15 AM Kees Cook wrote: > > On Wed, Oct 17, 2018 at 5:49 PM, Dan Williams > wrote: > > On Wed, Oct 17, 2018 at 5:29 PM Kees Cook wrote: > >> > >> When ramoops reserved a memory region in the kernel, it had an unhelpful > >> label of "persistent_memory".

Re: [PATCH] pstore/ram: Clarify resource reservation labels

2018-10-18 Thread Kees Cook
On Wed, Oct 17, 2018 at 5:49 PM, Dan Williams wrote: > On Wed, Oct 17, 2018 at 5:29 PM Kees Cook wrote: >> >> When ramoops reserved a memory region in the kernel, it had an unhelpful >> label of "persistent_memory". When reading /proc/iomem, it would be >> repeated many times, did not hint that

Re: [PATCH] pstore/ram: Clarify resource reservation labels

2018-10-18 Thread Kees Cook
On Wed, Oct 17, 2018 at 5:49 PM, Dan Williams wrote: > On Wed, Oct 17, 2018 at 5:29 PM Kees Cook wrote: >> >> When ramoops reserved a memory region in the kernel, it had an unhelpful >> label of "persistent_memory". When reading /proc/iomem, it would be >> repeated many times, did not hint that

Re: [PATCH] pstore/ram: Clarify resource reservation labels

2018-10-17 Thread Dan Williams
On Wed, Oct 17, 2018 at 5:29 PM Kees Cook wrote: > > When ramoops reserved a memory region in the kernel, it had an unhelpful > label of "persistent_memory". When reading /proc/iomem, it would be > repeated many times, did not hint that it was ramoops in particular, > and didn't clarify very much

Re: [PATCH] pstore/ram: Clarify resource reservation labels

2018-10-17 Thread Dan Williams
On Wed, Oct 17, 2018 at 5:29 PM Kees Cook wrote: > > When ramoops reserved a memory region in the kernel, it had an unhelpful > label of "persistent_memory". When reading /proc/iomem, it would be > repeated many times, did not hint that it was ramoops in particular, > and didn't clarify very much