Re: [PATCH] qla2xxx: Protect access to qpair members with qpair->qp_lock

2017-06-23 Thread Malavali, Giridhar
gt;From: kbuild test robot <fengguang...@intel.com> >To: kbu...@01.org >Cc: Julia Lawall <julia.law...@lip6.fr> >Subject: Re: [PATCH] qla2xxx: Protect access to qpair members with >qpair->qp_lock > >CC: kbuild-...@01.org >In-Reply-To: <20170622134325.269

Re: [PATCH] qla2xxx: Protect access to qpair members with qpair->qp_lock

2017-06-23 Thread Malavali, Giridhar
>To: kbu...@01.org >Cc: Julia Lawall >Subject: Re: [PATCH] qla2xxx: Protect access to qpair members with >qpair->qp_lock > >CC: kbuild-...@01.org >In-Reply-To: <20170622134325.26931-1-jthumsh...@suse.de> > >Hi Johannes, > >[auto build test WARNI

Re: [PATCH] qla2xxx: Protect access to qpair members with qpair->qp_lock (fwd)

2017-06-23 Thread Julia Lawall
Please check on whether an unlock is neeed before line 1965. julia -- Forwarded message -- Date: Fri, 23 Jun 2017 15:23:00 +0800 From: kbuild test robot <fengguang...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr> Subject: Re: [PATCH] qla2xxx: Pr

Re: [PATCH] qla2xxx: Protect access to qpair members with qpair->qp_lock (fwd)

2017-06-23 Thread Julia Lawall
Please check on whether an unlock is neeed before line 1965. julia -- Forwarded message -- Date: Fri, 23 Jun 2017 15:23:00 +0800 From: kbuild test robot To: kbu...@01.org Cc: Julia Lawall Subject: Re: [PATCH] qla2xxx: Protect access to qpair members with qpair->qp_lock

Re: [PATCH] qla2xxx: Protect access to qpair members with qpair->qp_lock

2017-06-22 Thread John Garry
On 22/06/2017 14:43, Johannes Thumshirn wrote: In qla2xx_start_scsi_mq() and qla2xx_dif_start_scsi_mq() we grab the qpair->qp_lock but do access members of the qpair before having the lock. Re-order the locking sequence to have all read and write access to qpair members under the qpair->qp_lock.

Re: [PATCH] qla2xxx: Protect access to qpair members with qpair->qp_lock

2017-06-22 Thread John Garry
On 22/06/2017 14:43, Johannes Thumshirn wrote: In qla2xx_start_scsi_mq() and qla2xx_dif_start_scsi_mq() we grab the qpair->qp_lock but do access members of the qpair before having the lock. Re-order the locking sequence to have all read and write access to qpair members under the qpair->qp_lock.

Re: [PATCH] qla2xxx: Protect access to qpair members with qpair->qp_lock

2017-06-22 Thread Johannes Thumshirn
On Thu, Jun 22, 2017 at 03:19:27PM +0100, John Garry wrote: > On 22/06/2017 14:43, Johannes Thumshirn wrote: > >In qla2xx_start_scsi_mq() and qla2xx_dif_start_scsi_mq() we grab the > >qpair->qp_lock but do access members of the qpair before having the lock. > >Re-order the locking sequence to have

Re: [PATCH] qla2xxx: Protect access to qpair members with qpair->qp_lock

2017-06-22 Thread Johannes Thumshirn
On Thu, Jun 22, 2017 at 03:19:27PM +0100, John Garry wrote: > On 22/06/2017 14:43, Johannes Thumshirn wrote: > >In qla2xx_start_scsi_mq() and qla2xx_dif_start_scsi_mq() we grab the > >qpair->qp_lock but do access members of the qpair before having the lock. > >Re-order the locking sequence to have

Re: [PATCH] qla2xxx: Protect access to qpair members with qpair->qp_lock

2017-06-22 Thread Hannes Reinecke
On 06/22/2017 03:43 PM, Johannes Thumshirn wrote: > In qla2xx_start_scsi_mq() and qla2xx_dif_start_scsi_mq() we grab the > qpair->qp_lock but do access members of the qpair before having the lock. > Re-order the locking sequence to have all read and write access to qpair > members under the

Re: [PATCH] qla2xxx: Protect access to qpair members with qpair->qp_lock

2017-06-22 Thread Hannes Reinecke
On 06/22/2017 03:43 PM, Johannes Thumshirn wrote: > In qla2xx_start_scsi_mq() and qla2xx_dif_start_scsi_mq() we grab the > qpair->qp_lock but do access members of the qpair before having the lock. > Re-order the locking sequence to have all read and write access to qpair > members under the