Re: [PATCH] sched/debug: Show intergroup and hierarchy sum wait time of a task group

2019-02-24 Thread 禹舟键
PING 禹舟键 于2019年2月19日周二 上午10:15写道: > > PING > > 禹舟键 于2019年2月12日周二 上午11:14写道: > > > > Hi, Peter > > I think hierarchy wait time for task groups is worth accounting > > despite with a little extra overhead. Because we can evaluate task > > groups' condition with a more direct metric. We cannot

Re: [PATCH] sched/debug: Show intergroup and hierarchy sum wait time of a task group

2019-02-18 Thread 禹舟键
PING 禹舟键 于2019年2月12日周二 上午11:14写道: > > Hi, Peter > I think hierarchy wait time for task groups is worth accounting > despite with a little extra overhead. Because we can evaluate task > groups' condition with a more direct metric. We cannot get the real > situation just with some general metrics,

Re: [PATCH] sched/debug: Show intergroup and hierarchy sum wait time of a task group

2019-02-11 Thread 禹舟键
Hi, Peter I think hierarchy wait time for task groups is worth accounting despite with a little extra overhead. Because we can evaluate task groups' condition with a more direct metric. We cannot get the real situation just with some general metrics, like idle or loadavg, since their value is

Re: [PATCH] sched/debug: Show intergroup and hierarchy sum wait time of a task group

2019-02-10 Thread 禹舟键
Hi Peter > The problem I have with this is that it will make schedstats even more expensive :/ I think the overhead for accounting hierarchy wait time is just the same as cpuacct.usage. If the performance overhead is low enough(< 1%), is it acceptable? Thanks Yuzhoujian Peter Zijlstra

Re: [PATCH] sched/debug: Show intergroup and hierarchy sum wait time of a task group

2019-02-06 Thread Peter Zijlstra
On Wed, Jan 23, 2019 at 05:46:56PM +0800, ufo19890...@gmail.com wrote: > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index e2ff4b6..35e89ca 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -858,6 +858,19 @@ static void update_curr_fair(struct rq *rq) > } > >

Re: [PATCH] sched/debug: Show intergroup and hierarchy sum wait time of a task group

2019-01-29 Thread 王贇
On 2019/1/28 下午3:21, 禹舟键 wrote: [snip] No offense but I'm afraid you misunderstand the problem we try to solve by wait_sum, if your purpose is to have a way to tell whether there are sufficient CPU inside a container, please try lxcfs + top, if there are almost no idle and load is high, then

Re: [PATCH] sched/debug: Show intergroup and hierarchy sum wait time of a task group

2019-01-27 Thread 禹舟键
Hi Michael > Task competition inside a cgroup won't be considered as cgroup's > competition, please try create another cgroup with dead loop on > each CPU Yes, you are right, but I don't think we just need to account for cgroup's competition, because this factor does not reflect cgroup internal

Re: [PATCH] sched/debug: Show intergroup and hierarchy sum wait time of a task group

2019-01-27 Thread 王贇
On 2019/1/25 下午3:55, 禹舟键 wrote: Hi, Michael Actually, I just created a container which had just 1 CPU, and I ran two tasks(while 1 loop) in this container. Then I read cpu.stat at 1 second interval ,but the wait_sum difference is almost 0. Task competition inside a cgroup won't be

Re: [PATCH] sched/debug: Show intergroup and hierarchy sum wait time of a task group

2019-01-24 Thread 王贇
On 2019/1/23 下午5:46, ufo19890...@gmail.com wrote: From: yuzhoujian We can monitor the sum wait time of a task group since 'commit 3d6c50c27bd6 ("sched/debug: Show the sum wait time of a task group")'. However this wait_sum just represents the confilct between different task groups, since it