Re: [PATCH] smaps should deal with huge zero page exactly same as normal zero page

2014-10-16 Thread Fengwei Yin
On Fri, Oct 10, 2014 at 07:35:15AM -0700, Dave Hansen wrote: > On 10/10/2014 06:21 AM, Fengwei Yin wrote: > > @@ -787,6 +788,9 @@ check_pfn: > > return NULL; > > } > > > > + if (is_huge_zero_pfn(pfn)) > > + return NULL; > > + > > That looks a lot better. One thing,

Re: [PATCH] smaps should deal with huge zero page exactly same as normal zero page

2014-10-16 Thread Fengwei Yin
On Fri, Oct 10, 2014 at 07:35:15AM -0700, Dave Hansen wrote: On 10/10/2014 06:21 AM, Fengwei Yin wrote: @@ -787,6 +788,9 @@ check_pfn: return NULL; } + if (is_huge_zero_pfn(pfn)) + return NULL; + That looks a lot better. One thing, why not put the

Re: [PATCH] smaps should deal with huge zero page exactly same as normal zero page

2014-10-14 Thread Fengwei Yin
On Tue, Oct 14, 2014 at 02:57:30PM +0300, Kirill A. Shutemov wrote: > On Fri, Oct 10, 2014 at 09:21:08PM +0800, Fengwei Yin wrote: > > On Thu, Oct 09, 2014 at 09:36:30AM -0700, Dave Hansen wrote: > > > On 10/09/2014 02:19 AM, Fengwei Yin wrote: > > > > diff --git a/fs/proc/task_mmu.c

Re: [PATCH] smaps should deal with huge zero page exactly same as normal zero page

2014-10-14 Thread Kirill A. Shutemov
On Fri, Oct 10, 2014 at 09:21:08PM +0800, Fengwei Yin wrote: > On Thu, Oct 09, 2014 at 09:36:30AM -0700, Dave Hansen wrote: > > On 10/09/2014 02:19 AM, Fengwei Yin wrote: > > > diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c > > > index 80ca4fb..8550b27 100644 > > > --- a/fs/proc/task_mmu.c >

Re: [PATCH] smaps should deal with huge zero page exactly same as normal zero page

2014-10-14 Thread Fengwei Yin
On Tue, Oct 14, 2014 at 02:57:30PM +0300, Kirill A. Shutemov wrote: On Fri, Oct 10, 2014 at 09:21:08PM +0800, Fengwei Yin wrote: On Thu, Oct 09, 2014 at 09:36:30AM -0700, Dave Hansen wrote: On 10/09/2014 02:19 AM, Fengwei Yin wrote: diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c

Re: [PATCH] smaps should deal with huge zero page exactly same as normal zero page

2014-10-14 Thread Kirill A. Shutemov
On Fri, Oct 10, 2014 at 09:21:08PM +0800, Fengwei Yin wrote: On Thu, Oct 09, 2014 at 09:36:30AM -0700, Dave Hansen wrote: On 10/09/2014 02:19 AM, Fengwei Yin wrote: diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c index 80ca4fb..8550b27 100644 --- a/fs/proc/task_mmu.c +++

Re: [PATCH] smaps should deal with huge zero page exactly same as normal zero page

2014-10-10 Thread Fengwei Yin
On Fri, Oct 10, 2014 at 07:35:15AM -0700, Dave Hansen wrote: > On 10/10/2014 06:21 AM, Fengwei Yin wrote: > > @@ -787,6 +788,9 @@ check_pfn: > > return NULL; > > } > > > > + if (is_huge_zero_pfn(pfn)) > > + return NULL; > > + > > That looks a lot better. One thing,

Re: [PATCH] smaps should deal with huge zero page exactly same as normal zero page

2014-10-10 Thread Dave Hansen
On 10/10/2014 06:21 AM, Fengwei Yin wrote: > @@ -787,6 +788,9 @@ check_pfn: > return NULL; > } > > + if (is_huge_zero_pfn(pfn)) > + return NULL; > + That looks a lot better. One thing, why not put the is_huge_zero_pfn() check next to the is_zero_pfn() check?

Re: [PATCH] smaps should deal with huge zero page exactly same as normal zero page

2014-10-10 Thread Dave Hansen
On 10/10/2014 06:21 AM, Fengwei Yin wrote: @@ -787,6 +788,9 @@ check_pfn: return NULL; } + if (is_huge_zero_pfn(pfn)) + return NULL; + That looks a lot better. One thing, why not put the is_huge_zero_pfn() check next to the is_zero_pfn() check? -- To

Re: [PATCH] smaps should deal with huge zero page exactly same as normal zero page

2014-10-10 Thread Fengwei Yin
On Fri, Oct 10, 2014 at 07:35:15AM -0700, Dave Hansen wrote: On 10/10/2014 06:21 AM, Fengwei Yin wrote: @@ -787,6 +788,9 @@ check_pfn: return NULL; } + if (is_huge_zero_pfn(pfn)) + return NULL; + That looks a lot better. One thing, why not put the

Re: [PATCH] smaps should deal with huge zero page exactly same as normal zero page

2014-10-09 Thread Fengwei Yin
On Thu, Oct 09, 2014 at 09:36:30AM -0700, Dave Hansen wrote: > On 10/09/2014 02:19 AM, Fengwei Yin wrote: > > diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c > > index 80ca4fb..8550b27 100644 > > --- a/fs/proc/task_mmu.c > > +++ b/fs/proc/task_mmu.c > > @@ -476,7 +476,7 @@ static void

Re: [PATCH] smaps should deal with huge zero page exactly same as normal zero page

2014-10-09 Thread Fengwei Yin
On Thu, Oct 09, 2014 at 09:36:30AM -0700, Dave Hansen wrote: > On 10/09/2014 02:19 AM, Fengwei Yin wrote: > > diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c > > index 80ca4fb..8550b27 100644 > > --- a/fs/proc/task_mmu.c > > +++ b/fs/proc/task_mmu.c > > @@ -476,7 +476,7 @@ static void

Re: [PATCH] smaps should deal with huge zero page exactly same as normal zero page

2014-10-09 Thread Dave Hansen
On 10/09/2014 02:19 AM, Fengwei Yin wrote: > diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c > index 80ca4fb..8550b27 100644 > --- a/fs/proc/task_mmu.c > +++ b/fs/proc/task_mmu.c > @@ -476,7 +476,7 @@ static void smaps_pte_entry(pte_t ptent, unsigned long > addr, >

Re: [PATCH] smaps should deal with huge zero page exactly same as normal zero page

2014-10-09 Thread Dave Hansen
On 10/09/2014 02:19 AM, Fengwei Yin wrote: diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c index 80ca4fb..8550b27 100644 --- a/fs/proc/task_mmu.c +++ b/fs/proc/task_mmu.c @@ -476,7 +476,7 @@ static void smaps_pte_entry(pte_t ptent, unsigned long addr,

Re: [PATCH] smaps should deal with huge zero page exactly same as normal zero page

2014-10-09 Thread Fengwei Yin
On Thu, Oct 09, 2014 at 09:36:30AM -0700, Dave Hansen wrote: On 10/09/2014 02:19 AM, Fengwei Yin wrote: diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c index 80ca4fb..8550b27 100644 --- a/fs/proc/task_mmu.c +++ b/fs/proc/task_mmu.c @@ -476,7 +476,7 @@ static void

Re: [PATCH] smaps should deal with huge zero page exactly same as normal zero page

2014-10-09 Thread Fengwei Yin
On Thu, Oct 09, 2014 at 09:36:30AM -0700, Dave Hansen wrote: On 10/09/2014 02:19 AM, Fengwei Yin wrote: diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c index 80ca4fb..8550b27 100644 --- a/fs/proc/task_mmu.c +++ b/fs/proc/task_mmu.c @@ -476,7 +476,7 @@ static void