Re: [PATCH] srcu: Fix incorrect condition in srcu_funnel_exp_start()

2018-02-18 Thread Paul E. McKenney
On Mon, Feb 19, 2018 at 08:36:30AM +0900, Byungchul Park wrote: > On 2/15/2018 6:42 AM, Paul E. McKenney wrote: > >On Wed, Feb 14, 2018 at 05:59:54PM +0900, Byungchul Park wrote: > >>We should've kept sp->srcu_gp_seq_needed_exp the furthest. But > >>it probably fails because of the incorrect

Re: [PATCH] srcu: Fix incorrect condition in srcu_funnel_exp_start()

2018-02-18 Thread Paul E. McKenney
On Mon, Feb 19, 2018 at 08:36:30AM +0900, Byungchul Park wrote: > On 2/15/2018 6:42 AM, Paul E. McKenney wrote: > >On Wed, Feb 14, 2018 at 05:59:54PM +0900, Byungchul Park wrote: > >>We should've kept sp->srcu_gp_seq_needed_exp the furthest. But > >>it probably fails because of the incorrect

Re: [PATCH] srcu: Fix incorrect condition in srcu_funnel_exp_start()

2018-02-18 Thread Byungchul Park
On 2/15/2018 6:42 AM, Paul E. McKenney wrote: On Wed, Feb 14, 2018 at 05:59:54PM +0900, Byungchul Park wrote: We should've kept sp->srcu_gp_seq_needed_exp the furthest. But it probably fails because of the incorrect condition. Fix it. Signed-off-by: Byungchul Park

Re: [PATCH] srcu: Fix incorrect condition in srcu_funnel_exp_start()

2018-02-18 Thread Byungchul Park
On 2/15/2018 6:42 AM, Paul E. McKenney wrote: On Wed, Feb 14, 2018 at 05:59:54PM +0900, Byungchul Park wrote: We should've kept sp->srcu_gp_seq_needed_exp the furthest. But it probably fails because of the incorrect condition. Fix it. Signed-off-by: Byungchul Park Good catch, and thank you

Re: [PATCH] srcu: Fix incorrect condition in srcu_funnel_exp_start()

2018-02-14 Thread Paul E. McKenney
On Wed, Feb 14, 2018 at 05:59:54PM +0900, Byungchul Park wrote: > We should've kept sp->srcu_gp_seq_needed_exp the furthest. But > it probably fails because of the incorrect condition. Fix it. > > Signed-off-by: Byungchul Park Good catch, and thank you for reviewing the

Re: [PATCH] srcu: Fix incorrect condition in srcu_funnel_exp_start()

2018-02-14 Thread Paul E. McKenney
On Wed, Feb 14, 2018 at 05:59:54PM +0900, Byungchul Park wrote: > We should've kept sp->srcu_gp_seq_needed_exp the furthest. But > it probably fails because of the incorrect condition. Fix it. > > Signed-off-by: Byungchul Park Good catch, and thank you for reviewing the SRCU code, but Ildar