Re: [PATCH] staging: slicoss: Fix prefer ether_addr_copy over memcpy

2014-03-18 Thread Joel Pelaez Jorge
El 17/03/14 23:49, Jingoo Han escribió: On Tuesday, March 18, 2014 2:04 PM, Joel Pelaez Jorge wrote: @@ -810,8 +810,8 @@ static int slic_mac_set_address(struct net_device *dev, void *ptr) if (!is_valid_ether_addr(addr->sa_data)) return -EINVAL; -

Re: [PATCH] staging: slicoss: Fix prefer ether_addr_copy over memcpy

2014-03-18 Thread Greg Kroah-Hartman
On Mon, Mar 17, 2014 at 09:17:35PM -0600, Joel Pelaez Jorge wrote: > This patch fixes the following checkpatch.pl issues caused by the new > function: ether_addr_copy > > Signed-off-by: Joel Pelaez Jorge > --- > diff --git a/drivers/staging/slicoss/slicoss.c > b/drivers/staging/slicoss/slicoss.c

Re: [PATCH] staging: slicoss: Fix prefer ether_addr_copy over memcpy

2014-03-18 Thread Greg Kroah-Hartman
On Mon, Mar 17, 2014 at 09:17:35PM -0600, Joel Pelaez Jorge wrote: This patch fixes the following checkpatch.pl issues caused by the new function: ether_addr_copy Signed-off-by: Joel Pelaez Jorge joelpel...@gmail.com --- diff --git a/drivers/staging/slicoss/slicoss.c

Re: [PATCH] staging: slicoss: Fix prefer ether_addr_copy over memcpy

2014-03-18 Thread Joel Pelaez Jorge
El 17/03/14 23:49, Jingoo Han escribió: On Tuesday, March 18, 2014 2:04 PM, Joel Pelaez Jorge wrote: @@ -810,8 +810,8 @@ static int slic_mac_set_address(struct net_device *dev, void *ptr) if (!is_valid_ether_addr(addr-sa_data)) return -EINVAL; -

Re: [PATCH] staging: slicoss: Fix prefer ether_addr_copy over memcpy

2014-03-17 Thread Jingoo Han
On Tuesday, March 18, 2014 2:04 PM, Joel Pelaez Jorge wrote: > > This patch fixes the following checkpatch.pl issues caused by the new > function: ether_addr_copy > > Signed-off-by: Joel Pelaez Jorge > --- > drivers/staging/slicoss/slicoss.c | 20 ++-- > 1 file changed, 10

Re: [PATCH] staging: slicoss: Fix prefer ether_addr_copy over memcpy

2014-03-17 Thread Joe Perches
On Tue, 2014-03-18 at 12:38 +0900, Jingoo Han wrote: > In addition to this, there are the same cases like this, > in this file as below. Please search other same cases. > For instance, 'grep' will be a good way to find it. [] > static void slic_adapter_set_hwaddr(struct adapter *adapter) > { >

Re: [PATCH] staging: slicoss: Fix prefer ether_addr_copy over memcpy

2014-03-17 Thread Jingoo Han
On Tuesday, March 18, 2014 12:18 PM, Joel Pelaez Jorge wrote: > > This patch fixes the following checkpatch.pl issues caused by the new > function: ether_addr_copy > > Signed-off-by: Joel Pelaez Jorge > --- > diff --git a/drivers/staging/slicoss/slicoss.c > b/drivers/staging/slicoss/slicoss.c >

Re: [PATCH] staging: slicoss: Fix prefer ether_addr_copy over memcpy

2014-03-17 Thread Jingoo Han
On Tuesday, March 18, 2014 12:18 PM, Joel Pelaez Jorge wrote: This patch fixes the following checkpatch.pl issues caused by the new function: ether_addr_copy Signed-off-by: Joel Pelaez Jorge joelpel...@gmail.com --- diff --git a/drivers/staging/slicoss/slicoss.c

Re: [PATCH] staging: slicoss: Fix prefer ether_addr_copy over memcpy

2014-03-17 Thread Joe Perches
On Tue, 2014-03-18 at 12:38 +0900, Jingoo Han wrote: In addition to this, there are the same cases like this, in this file as below. Please search other same cases. For instance, 'grep' will be a good way to find it. [] static void slic_adapter_set_hwaddr(struct adapter *adapter) {

Re: [PATCH] staging: slicoss: Fix prefer ether_addr_copy over memcpy

2014-03-17 Thread Jingoo Han
On Tuesday, March 18, 2014 2:04 PM, Joel Pelaez Jorge wrote: This patch fixes the following checkpatch.pl issues caused by the new function: ether_addr_copy Signed-off-by: Joel Pelaez Jorge joelpel...@gmail.com --- drivers/staging/slicoss/slicoss.c | 20 ++-- 1 file