Re: [PATCH] time: tick-sched: use bool for tick_stopped

On 2018-04-21 03:24 AM, Joe Perches wrote: On Fri, 2018-04-20 at 14:44 +0800, yuank...@codeaurora.org wrote: On 2018-04-20 09:47 AM, yuank...@codeaurora.org wrote: [] > [ZJ] Further prototyping has been given based on gcc for both of > x86_64 and armv8-a, > unsigned int and bool share

Re: [PATCH] time: tick-sched: use bool for tick_stopped

On 2018-04-21 03:24 AM, Joe Perches wrote: On Fri, 2018-04-20 at 14:44 +0800, yuank...@codeaurora.org wrote: On 2018-04-20 09:47 AM, yuank...@codeaurora.org wrote: [] > [ZJ] Further prototyping has been given based on gcc for both of > x86_64 and armv8-a, > unsigned int and bool share

Re: [PATCH] time: tick-sched: use bool for tick_stopped

On Fri, 2018-04-20 at 14:44 +0800, yuank...@codeaurora.org wrote: > On 2018-04-20 09:47 AM, yuank...@codeaurora.org wrote: [] > > [ZJ] Further prototyping has been given based on gcc for both of > > x86_64 and armv8-a, > > unsigned int and bool share the same 1 bytes without the > > addtional

Re: [PATCH] time: tick-sched: use bool for tick_stopped

On Fri, 2018-04-20 at 14:44 +0800, yuank...@codeaurora.org wrote: > On 2018-04-20 09:47 AM, yuank...@codeaurora.org wrote: [] > > [ZJ] Further prototyping has been given based on gcc for both of > > x86_64 and armv8-a, > > unsigned int and bool share the same 1 bytes without the > > addtional

Re: [PATCH] time: tick-sched: use bool for tick_stopped

On 2018-04-20 09:47 AM, yuank...@codeaurora.org wrote: On 2018-04-11 07:20 AM, yuank...@codeaurora.org wrote: ++ On 2018-04-11 07:09 AM, yuank...@codeaurora.org wrote: ++ On 2018-04-10 10:49 PM, yuank...@codeaurora.org wrote: Typo... On 2018-04-10 10:08 PM, yuank...@codeaurora.org wrote:

Re: [PATCH] time: tick-sched: use bool for tick_stopped

On 2018-04-20 09:47 AM, yuank...@codeaurora.org wrote: On 2018-04-11 07:20 AM, yuank...@codeaurora.org wrote: ++ On 2018-04-11 07:09 AM, yuank...@codeaurora.org wrote: ++ On 2018-04-10 10:49 PM, yuank...@codeaurora.org wrote: Typo... On 2018-04-10 10:08 PM, yuank...@codeaurora.org wrote:

Re: [PATCH] time: tick-sched: use bool for tick_stopped

On 2018-04-11 07:20 AM, yuank...@codeaurora.org wrote: ++ On 2018-04-11 07:09 AM, yuank...@codeaurora.org wrote: ++ On 2018-04-10 10:49 PM, yuank...@codeaurora.org wrote: Typo... On 2018-04-10 10:08 PM, yuank...@codeaurora.org wrote: On 2018-04-10 07:06 PM, Thomas Gleixner wrote: On Tue,

Re: [PATCH] time: tick-sched: use bool for tick_stopped

On 2018-04-11 07:20 AM, yuank...@codeaurora.org wrote: ++ On 2018-04-11 07:09 AM, yuank...@codeaurora.org wrote: ++ On 2018-04-10 10:49 PM, yuank...@codeaurora.org wrote: Typo... On 2018-04-10 10:08 PM, yuank...@codeaurora.org wrote: On 2018-04-10 07:06 PM, Thomas Gleixner wrote: On Tue,

Re: [PATCH] time: tick-sched: use bool for tick_stopped

++ On 2018-04-11 07:09 AM, yuank...@codeaurora.org wrote: ++ On 2018-04-10 10:49 PM, yuank...@codeaurora.org wrote: Typo... On 2018-04-10 10:08 PM, yuank...@codeaurora.org wrote: On 2018-04-10 07:06 PM, Thomas Gleixner wrote: On Tue, 10 Apr 2018, yuank...@codeaurora.org wrote: On

Re: [PATCH] time: tick-sched: use bool for tick_stopped

++ On 2018-04-11 07:09 AM, yuank...@codeaurora.org wrote: ++ On 2018-04-10 10:49 PM, yuank...@codeaurora.org wrote: Typo... On 2018-04-10 10:08 PM, yuank...@codeaurora.org wrote: On 2018-04-10 07:06 PM, Thomas Gleixner wrote: On Tue, 10 Apr 2018, yuank...@codeaurora.org wrote: On

Re: [PATCH] time: tick-sched: use bool for tick_stopped

++ On 2018-04-10 10:49 PM, yuank...@codeaurora.org wrote: Typo... On 2018-04-10 10:08 PM, yuank...@codeaurora.org wrote: On 2018-04-10 07:06 PM, Thomas Gleixner wrote: On Tue, 10 Apr 2018, yuank...@codeaurora.org wrote: On 2018-04-10 05:10 PM, Thomas Gleixner wrote: > On Tue, 10 Apr 2018,

Re: [PATCH] time: tick-sched: use bool for tick_stopped

++ On 2018-04-10 10:49 PM, yuank...@codeaurora.org wrote: Typo... On 2018-04-10 10:08 PM, yuank...@codeaurora.org wrote: On 2018-04-10 07:06 PM, Thomas Gleixner wrote: On Tue, 10 Apr 2018, yuank...@codeaurora.org wrote: On 2018-04-10 05:10 PM, Thomas Gleixner wrote: > On Tue, 10 Apr 2018,

Re: [PATCH] time: tick-sched: use bool for tick_stopped

Typo... On 2018-04-10 10:08 PM, yuank...@codeaurora.org wrote: On 2018-04-10 07:06 PM, Thomas Gleixner wrote: On Tue, 10 Apr 2018, yuank...@codeaurora.org wrote: On 2018-04-10 05:10 PM, Thomas Gleixner wrote: > On Tue, 10 Apr 2018, yuank...@codeaurora.org wrote: > > On 2018-04-10 04:00 PM,

Re: [PATCH] time: tick-sched: use bool for tick_stopped

Typo... On 2018-04-10 10:08 PM, yuank...@codeaurora.org wrote: On 2018-04-10 07:06 PM, Thomas Gleixner wrote: On Tue, 10 Apr 2018, yuank...@codeaurora.org wrote: On 2018-04-10 05:10 PM, Thomas Gleixner wrote: > On Tue, 10 Apr 2018, yuank...@codeaurora.org wrote: > > On 2018-04-10 04:00 PM,

Re: [PATCH] time: tick-sched: use bool for tick_stopped

On 2018-04-10 07:06 PM, Thomas Gleixner wrote: On Tue, 10 Apr 2018, yuank...@codeaurora.org wrote: On 2018-04-10 05:10 PM, Thomas Gleixner wrote: > On Tue, 10 Apr 2018, yuank...@codeaurora.org wrote: > > On 2018-04-10 04:00 PM, Rafael J. Wysocki wrote: > > > On Tue, Apr 10, 2018 at 9:33 AM,

Re: [PATCH] time: tick-sched: use bool for tick_stopped

On 2018-04-10 07:06 PM, Thomas Gleixner wrote: On Tue, 10 Apr 2018, yuank...@codeaurora.org wrote: On 2018-04-10 05:10 PM, Thomas Gleixner wrote: > On Tue, 10 Apr 2018, yuank...@codeaurora.org wrote: > > On 2018-04-10 04:00 PM, Rafael J. Wysocki wrote: > > > On Tue, Apr 10, 2018 at 9:33 AM,

Re: [PATCH] time: tick-sched: use bool for tick_stopped

On Tue, Apr 10, 2018 at 02:07:32PM +0200, Thomas Gleixner wrote: > On Tue, 10 Apr 2018, Peter Zijlstra wrote: > > Do you have any actual evidence for that? Is there a compiler stupid > > enough to generate code to convert a bool to a 1bit value? > > Sure, if you do: > > > > > > > > + bool

Re: [PATCH] time: tick-sched: use bool for tick_stopped

On Tue, Apr 10, 2018 at 02:07:32PM +0200, Thomas Gleixner wrote: > On Tue, 10 Apr 2018, Peter Zijlstra wrote: > > Do you have any actual evidence for that? Is there a compiler stupid > > enough to generate code to convert a bool to a 1bit value? > > Sure, if you do: > > > > > > > > + bool

Re: [PATCH] time: tick-sched: use bool for tick_stopped

On Tue, 10 Apr 2018, Peter Zijlstra wrote: > On Tue, Apr 10, 2018 at 06:07:17PM +0800, yuank...@codeaurora.org wrote: > > > > > > @@ -48,8 +48,8 @@ struct tick_sched { > > > > > > unsigned long check_clocks; > > > > > > enum tick_nohz_mode nohz_mode;

Re: [PATCH] time: tick-sched: use bool for tick_stopped

On Tue, 10 Apr 2018, Peter Zijlstra wrote: > On Tue, Apr 10, 2018 at 06:07:17PM +0800, yuank...@codeaurora.org wrote: > > > > > > @@ -48,8 +48,8 @@ struct tick_sched { > > > > > > unsigned long check_clocks; > > > > > > enum tick_nohz_mode nohz_mode;

Re: [PATCH] time: tick-sched: use bool for tick_stopped

On Tue, Apr 10, 2018 at 06:07:17PM +0800, yuank...@codeaurora.org wrote: > > > > > @@ -48,8 +48,8 @@ struct tick_sched { > > > > > unsigned long check_clocks; > > > > > enum tick_nohz_mode nohz_mode; > > > > > > > > > > + bool

Re: [PATCH] time: tick-sched: use bool for tick_stopped

On Tue, Apr 10, 2018 at 06:07:17PM +0800, yuank...@codeaurora.org wrote: > > > > > @@ -48,8 +48,8 @@ struct tick_sched { > > > > > unsigned long check_clocks; > > > > > enum tick_nohz_mode nohz_mode; > > > > > > > > > > + bool

Re: [PATCH] time: tick-sched: use bool for tick_stopped

On Tue, 10 Apr 2018, yuank...@codeaurora.org wrote: > On 2018-04-10 05:10 PM, Thomas Gleixner wrote: > > On Tue, 10 Apr 2018, yuank...@codeaurora.org wrote: > > > On 2018-04-10 04:00 PM, Rafael J. Wysocki wrote: > > > > On Tue, Apr 10, 2018 at 9:33 AM, wrote: > > > > >

Re: [PATCH] time: tick-sched: use bool for tick_stopped

On Tue, 10 Apr 2018, yuank...@codeaurora.org wrote: > On 2018-04-10 05:10 PM, Thomas Gleixner wrote: > > On Tue, 10 Apr 2018, yuank...@codeaurora.org wrote: > > > On 2018-04-10 04:00 PM, Rafael J. Wysocki wrote: > > > > On Tue, Apr 10, 2018 at 9:33 AM, wrote: > > > > > From: John Zhao > > > > >

Re: [PATCH] time: tick-sched: use bool for tick_stopped

Hi Thomas, On 2018-04-10 05:10 PM, Thomas Gleixner wrote: On Tue, 10 Apr 2018, yuank...@codeaurora.org wrote: On 2018-04-10 04:00 PM, Rafael J. Wysocki wrote: > On Tue, Apr 10, 2018 at 9:33 AM, wrote: > > From: John Zhao > > > > Variable

Re: [PATCH] time: tick-sched: use bool for tick_stopped

Hi Thomas, On 2018-04-10 05:10 PM, Thomas Gleixner wrote: On Tue, 10 Apr 2018, yuank...@codeaurora.org wrote: On 2018-04-10 04:00 PM, Rafael J. Wysocki wrote: > On Tue, Apr 10, 2018 at 9:33 AM, wrote: > > From: John Zhao > > > > Variable tick_stopped returned by tick_nohz_tick_stopped > >

Re: [PATCH] time: tick-sched: use bool for tick_stopped

Subject and commit message have been updated due for typo. This patch is based on the tip of linux-pm-cpuild branch. Thanks On 2018-04-10 04:51 PM, yuank...@codeaurora.org wrote: From: John Zhao Variable tick_stopped returned by tick_nohz_tick_stopped can only be

Re: [PATCH] time: tick-sched: use bool for tick_stopped

Subject and commit message have been updated due for typo. This patch is based on the tip of linux-pm-cpuild branch. Thanks On 2018-04-10 04:51 PM, yuank...@codeaurora.org wrote: From: John Zhao Variable tick_stopped returned by tick_nohz_tick_stopped can only be true / false values. Since