2013/10/19 Steven Rostedt :
> On Sat, 19 Oct 2013 11:41:10 -0300
> Geyslan Gregório Bem wrote:
>
>> Let's wait Steve's reply about further use of tracing_is_disabled().
>
> Might want to ping me later. This weekend I'm taking my daughter to
> colleges, and early Monday morning I'm leaving to
On Sat, 19 Oct 2013 11:41:10 -0300
Geyslan Gregório Bem wrote:
> Let's wait Steve's reply about further use of tracing_is_disabled().
Might want to ping me later. This weekend I'm taking my daughter to
colleges, and early Monday morning I'm leaving to Edinburgh (arriving
on Tuesday).
-- Steve
2013/10/19 Oleg Nesterov :
> On 10/19, Geyslan Gregório Bem wrote:
>>
>> 2013/10/19 Oleg Nesterov :
>> > On 10/17, Steven Rostedt wrote:
>> >>
>> >> I'm thinking of just nuking the tracing_open_generic() here. The only
>> >> thing it does here is the tracing_disabled check. The assignment of
>> >>
On 10/19, Geyslan Gregório Bem wrote:
>
> 2013/10/19 Oleg Nesterov :
> > On 10/17, Steven Rostedt wrote:
> >>
> >> I'm thinking of just nuking the tracing_open_generic() here. The only
> >> thing it does here is the tracing_disabled check. The assignment of
> >> inode->i_private to
2013/10/19 Oleg Nesterov :
> On 10/17, Steven Rostedt wrote:
>>
>> On Thu, 17 Oct 2013 22:44:56 -0300
>> "Geyslan G. Bem" wrote:
>>
>> > and fix the possible 'dir'
>> > assignment after freeing it.
>
> This should be safe afaics, nobody will use it anyway. Even
> subsystem_release() won't be
Steven, et all, sorry for off-topic...
You probably know that kernel/trace/ is not trivial ;) and the fact
that cscope doesn't shows the callers in kernel/trace/trace_events.c
doesn't really help.
Fixed by the patch below, but I am not sure it is fine to uglify the
code to help the buggy tools.
On 10/17, Steven Rostedt wrote:
>
> On Thu, 17 Oct 2013 22:44:56 -0300
> "Geyslan G. Bem" wrote:
>
> > and fix the possible 'dir'
> > assignment after freeing it.
This should be safe afaics, nobody will use it anyway. Even
subsystem_release() won't be called if .open() fails. But I agree
this
On 10/17, Steven Rostedt wrote:
On Thu, 17 Oct 2013 22:44:56 -0300
Geyslan G. Bem geys...@gmail.com wrote:
and fix the possible 'dir'
assignment after freeing it.
This should be safe afaics, nobody will use it anyway. Even
subsystem_release() won't be called if .open() fails. But I agree
Steven, et all, sorry for off-topic...
You probably know that kernel/trace/ is not trivial ;) and the fact
that cscope doesn't shows the callers in kernel/trace/trace_events.c
doesn't really help.
Fixed by the patch below, but I am not sure it is fine to uglify the
code to help the buggy tools.
2013/10/19 Oleg Nesterov o...@redhat.com:
On 10/17, Steven Rostedt wrote:
On Thu, 17 Oct 2013 22:44:56 -0300
Geyslan G. Bem geys...@gmail.com wrote:
and fix the possible 'dir'
assignment after freeing it.
This should be safe afaics, nobody will use it anyway. Even
subsystem_release()
On 10/19, Geyslan Gregório Bem wrote:
2013/10/19 Oleg Nesterov o...@redhat.com:
On 10/17, Steven Rostedt wrote:
I'm thinking of just nuking the tracing_open_generic() here. The only
thing it does here is the tracing_disabled check. The assignment of
inode-i_private to filp-private_data
2013/10/19 Oleg Nesterov o...@redhat.com:
On 10/19, Geyslan Gregório Bem wrote:
2013/10/19 Oleg Nesterov o...@redhat.com:
On 10/17, Steven Rostedt wrote:
I'm thinking of just nuking the tracing_open_generic() here. The only
thing it does here is the tracing_disabled check. The
On Sat, 19 Oct 2013 11:41:10 -0300
Geyslan Gregório Bem geys...@gmail.com wrote:
Let's wait Steve's reply about further use of tracing_is_disabled().
Might want to ping me later. This weekend I'm taking my daughter to
colleges, and early Monday morning I'm leaving to Edinburgh (arriving
on
2013/10/19 Steven Rostedt rost...@goodmis.org:
On Sat, 19 Oct 2013 11:41:10 -0300
Geyslan Gregório Bem geys...@gmail.com wrote:
Let's wait Steve's reply about further use of tracing_is_disabled().
Might want to ping me later. This weekend I'm taking my daughter to
colleges, and early Monday
On Fri, 18 Oct 2013 08:02:32 -0300
Geyslan Gregório Bem wrote:
> >>
> >> I'm thinking of just nuking the tracing_open_generic() here. The only
> >> thing it does here is the tracing_disabled check. The assignment of
> >> inode->i_private to filp->private_data is pointless as it just
> >>
2013/10/18 Geyslan Gregório Bem :
> 2013/10/17 Steven Rostedt :
>> On Thu, 17 Oct 2013 22:44:56 -0300
>> "Geyslan G. Bem" wrote:
>>
>>> Restructures function logic conditions testing 'tracing_open_generic'
>>> return before the others. It avoids: unnecessary trace_array_get and
>>> kzalloc when
2013/10/17 Steven Rostedt :
> On Thu, 17 Oct 2013 22:44:56 -0300
> "Geyslan G. Bem" wrote:
>
>> Restructures function logic conditions testing 'tracing_open_generic'
>> return before the others. It avoids: unnecessary trace_array_get and
>> kzalloc when tracing is disabled; and fix the possible
2013/10/17 Steven Rostedt rost...@goodmis.org:
On Thu, 17 Oct 2013 22:44:56 -0300
Geyslan G. Bem geys...@gmail.com wrote:
Restructures function logic conditions testing 'tracing_open_generic'
return before the others. It avoids: unnecessary trace_array_get and
kzalloc when tracing is
2013/10/18 Geyslan Gregório Bem geys...@gmail.com:
2013/10/17 Steven Rostedt rost...@goodmis.org:
On Thu, 17 Oct 2013 22:44:56 -0300
Geyslan G. Bem geys...@gmail.com wrote:
Restructures function logic conditions testing 'tracing_open_generic'
return before the others. It avoids: unnecessary
On Fri, 18 Oct 2013 08:02:32 -0300
Geyslan Gregório Bem geys...@gmail.com wrote:
I'm thinking of just nuking the tracing_open_generic() here. The only
thing it does here is the tracing_disabled check. The assignment of
inode-i_private to filp-private_data is pointless as it just
On Thu, 17 Oct 2013 22:44:56 -0300
"Geyslan G. Bem" wrote:
> Restructures function logic conditions testing 'tracing_open_generic'
> return before the others. It avoids: unnecessary trace_array_get and
> kzalloc when tracing is disabled; and fix the possible 'dir'
> assignment after freeing it.
On Thu, 17 Oct 2013 22:44:56 -0300
Geyslan G. Bem geys...@gmail.com wrote:
Restructures function logic conditions testing 'tracing_open_generic'
return before the others. It avoids: unnecessary trace_array_get and
kzalloc when tracing is disabled; and fix the possible 'dir'
assignment after
22 matches
Mail list logo
