Re: [PATCH] uprobes: Cleanup !CONFIG_UPROBES decls, unexport xol_area

2013-11-11 Thread Ingo Molnar
* Oleg Nesterov wrote: > On 11/11, Ingo Molnar wrote: > > > > * Oleg Nesterov wrote: > > > > > +++ b/kernel/events/uprobes.c > > > @@ -86,6 +86,25 @@ struct return_instance { > > > }; > > > > > > /* > > > + * On a breakpoint hit, thread contests for a slot. It frees the > > > + * slot after

Re: [PATCH] uprobes: Cleanup !CONFIG_UPROBES decls, unexport xol_area

2013-11-11 Thread Oleg Nesterov
On 11/11, Ingo Molnar wrote: > > * Oleg Nesterov wrote: > > > +++ b/kernel/events/uprobes.c > > @@ -86,6 +86,25 @@ struct return_instance { > > }; > > > > /* > > + * On a breakpoint hit, thread contests for a slot. It frees the > > + * slot after singlestep. Currently a fixed number of slots

Re: [PATCH] uprobes: Cleanup !CONFIG_UPROBES decls, unexport xol_area

2013-11-11 Thread Ingo Molnar
* Oleg Nesterov wrote: > +++ b/kernel/events/uprobes.c > @@ -86,6 +86,25 @@ struct return_instance { > }; > > /* > + * On a breakpoint hit, thread contests for a slot. It frees the > + * slot after singlestep. Currently a fixed number of slots are > + * allocated. > + */ > +struct xol_area

Re: [PATCH] uprobes: Cleanup !CONFIG_UPROBES decls, unexport xol_area

2013-11-11 Thread Ingo Molnar
* Oleg Nesterov o...@redhat.com wrote: +++ b/kernel/events/uprobes.c @@ -86,6 +86,25 @@ struct return_instance { }; /* + * On a breakpoint hit, thread contests for a slot. It frees the + * slot after singlestep. Currently a fixed number of slots are + * allocated. + */ +struct

Re: [PATCH] uprobes: Cleanup !CONFIG_UPROBES decls, unexport xol_area

2013-11-11 Thread Oleg Nesterov
On 11/11, Ingo Molnar wrote: * Oleg Nesterov o...@redhat.com wrote: +++ b/kernel/events/uprobes.c @@ -86,6 +86,25 @@ struct return_instance { }; /* + * On a breakpoint hit, thread contests for a slot. It frees the + * slot after singlestep. Currently a fixed number of slots are

Re: [PATCH] uprobes: Cleanup !CONFIG_UPROBES decls, unexport xol_area

2013-11-11 Thread Ingo Molnar
* Oleg Nesterov o...@redhat.com wrote: On 11/11, Ingo Molnar wrote: * Oleg Nesterov o...@redhat.com wrote: +++ b/kernel/events/uprobes.c @@ -86,6 +86,25 @@ struct return_instance { }; /* + * On a breakpoint hit, thread contests for a slot. It frees the + * slot

Re: [PATCH] uprobes: Cleanup !CONFIG_UPROBES decls, unexport xol_area

2013-11-10 Thread Srikar Dronamraju
* Oleg Nesterov [2013-11-09 20:03:44]: > 1. Don't include asm/uprobes.h unconditionally, we only need >it if CONFIG_UPROBES. > > 2. Move the definition of "struct xol_area" into uprobes.c. > >Perhaps we should simply kill struct uprobes_state, it buys >nothing. > > 3. Kill the

Re: [PATCH] uprobes: Cleanup !CONFIG_UPROBES decls, unexport xol_area

2013-11-10 Thread Srikar Dronamraju
* Oleg Nesterov o...@redhat.com [2013-11-09 20:03:44]: 1. Don't include asm/uprobes.h unconditionally, we only need it if CONFIG_UPROBES. 2. Move the definition of struct xol_area into uprobes.c. Perhaps we should simply kill struct uprobes_state, it buys nothing. 3. Kill the