Re: [PATCH] usb,signal,security: only pass the cred, not the secid, to kill_pid_info_as_cred and security_task_kill

2018-03-06 Thread James Morris
On Tue, 6 Mar 2018, Casey Schaufler wrote: > On 3/6/2018 11:01 AM, Paul Moore wrote: > > On Fri, Sep 8, 2017 at 6:09 PM, James Morris wrote: > >> On Fri, 8 Sep 2017, Paul Moore wrote: > >>> Looks fine to me from a SELinux perspective. If Casey and John are > >>> happy with

Re: [PATCH] usb,signal,security: only pass the cred, not the secid, to kill_pid_info_as_cred and security_task_kill

2018-03-06 Thread James Morris
On Tue, 6 Mar 2018, Casey Schaufler wrote: > On 3/6/2018 11:01 AM, Paul Moore wrote: > > On Fri, Sep 8, 2017 at 6:09 PM, James Morris wrote: > >> On Fri, 8 Sep 2017, Paul Moore wrote: > >>> Looks fine to me from a SELinux perspective. If Casey and John are > >>> happy with this I can volunteer

Re: [PATCH] usb,signal,security: only pass the cred, not the secid, to kill_pid_info_as_cred and security_task_kill

2018-03-06 Thread Casey Schaufler
On 3/6/2018 11:01 AM, Paul Moore wrote: > On Fri, Sep 8, 2017 at 6:09 PM, James Morris wrote: >> On Fri, 8 Sep 2017, Paul Moore wrote: >>> Looks fine to me from a SELinux perspective. If Casey and John are >>> happy with this I can volunteer to pull it into the selinux/next

Re: [PATCH] usb,signal,security: only pass the cred, not the secid, to kill_pid_info_as_cred and security_task_kill

2018-03-06 Thread Casey Schaufler
On 3/6/2018 11:01 AM, Paul Moore wrote: > On Fri, Sep 8, 2017 at 6:09 PM, James Morris wrote: >> On Fri, 8 Sep 2017, Paul Moore wrote: >>> Looks fine to me from a SELinux perspective. If Casey and John are >>> happy with this I can volunteer to pull it into the selinux/next tree >>> (once the

Re: [PATCH] usb,signal,security: only pass the cred, not the secid, to kill_pid_info_as_cred and security_task_kill

2018-03-06 Thread Paul Moore
On Fri, Sep 8, 2017 at 6:09 PM, James Morris wrote: > On Fri, 8 Sep 2017, Paul Moore wrote: >> Looks fine to me from a SELinux perspective. If Casey and John are >> happy with this I can volunteer to pull it into the selinux/next tree >> (once the merge window closes),

Re: [PATCH] usb,signal,security: only pass the cred, not the secid, to kill_pid_info_as_cred and security_task_kill

2018-03-06 Thread Paul Moore
On Fri, Sep 8, 2017 at 6:09 PM, James Morris wrote: > On Fri, 8 Sep 2017, Paul Moore wrote: >> Looks fine to me from a SELinux perspective. If Casey and John are >> happy with this I can volunteer to pull it into the selinux/next tree >> (once the merge window closes), otherwise if someone else

Re: [PATCH] usb,signal,security: only pass the cred, not the secid, to kill_pid_info_as_cred and security_task_kill

2017-09-08 Thread Greg KH
On Fri, Sep 08, 2017 at 12:40:01PM -0400, Stephen Smalley wrote: > commit d178bc3a708f39cbfefc3fab37032d3f2511b4ec ("user namespace: usb: > make usb urbs user namespace aware (v2)") changed kill_pid_info_as_uid > to kill_pid_info_as_cred, saving and passing a cred structure instead of > uids.

Re: [PATCH] usb,signal,security: only pass the cred, not the secid, to kill_pid_info_as_cred and security_task_kill

2017-09-08 Thread Greg KH
On Fri, Sep 08, 2017 at 12:40:01PM -0400, Stephen Smalley wrote: > commit d178bc3a708f39cbfefc3fab37032d3f2511b4ec ("user namespace: usb: > make usb urbs user namespace aware (v2)") changed kill_pid_info_as_uid > to kill_pid_info_as_cred, saving and passing a cred structure instead of > uids.

Re: [PATCH] usb,signal,security: only pass the cred, not the secid, to kill_pid_info_as_cred and security_task_kill

2017-09-08 Thread Casey Schaufler
On 9/8/2017 9:40 AM, Stephen Smalley wrote: > commit d178bc3a708f39cbfefc3fab37032d3f2511b4ec ("user namespace: usb: > make usb urbs user namespace aware (v2)") changed kill_pid_info_as_uid > to kill_pid_info_as_cred, saving and passing a cred structure instead of > uids. Since the secid can be

Re: [PATCH] usb,signal,security: only pass the cred, not the secid, to kill_pid_info_as_cred and security_task_kill

2017-09-08 Thread Casey Schaufler
On 9/8/2017 9:40 AM, Stephen Smalley wrote: > commit d178bc3a708f39cbfefc3fab37032d3f2511b4ec ("user namespace: usb: > make usb urbs user namespace aware (v2)") changed kill_pid_info_as_uid > to kill_pid_info_as_cred, saving and passing a cred structure instead of > uids. Since the secid can be

Re: [PATCH] usb,signal,security: only pass the cred, not the secid, to kill_pid_info_as_cred and security_task_kill

2017-09-08 Thread James Morris
On Fri, 8 Sep 2017, Paul Moore wrote: > Looks fine to me from a SELinux perspective. If Casey and John are > happy with this I can volunteer to pull it into the selinux/next tree > (once the merge window closes), otherwise if someone else wants to > merge this my ack is below. > As this

Re: [PATCH] usb,signal,security: only pass the cred, not the secid, to kill_pid_info_as_cred and security_task_kill

2017-09-08 Thread James Morris
On Fri, 8 Sep 2017, Paul Moore wrote: > Looks fine to me from a SELinux perspective. If Casey and John are > happy with this I can volunteer to pull it into the selinux/next tree > (once the merge window closes), otherwise if someone else wants to > merge this my ack is below. > As this

Re: [PATCH] usb,signal,security: only pass the cred, not the secid, to kill_pid_info_as_cred and security_task_kill

2017-09-08 Thread Paul Moore
On Fri, Sep 8, 2017 at 12:40 PM, Stephen Smalley wrote: > commit d178bc3a708f39cbfefc3fab37032d3f2511b4ec ("user namespace: usb: > make usb urbs user namespace aware (v2)") changed kill_pid_info_as_uid > to kill_pid_info_as_cred, saving and passing a cred structure instead of

Re: [PATCH] usb,signal,security: only pass the cred, not the secid, to kill_pid_info_as_cred and security_task_kill

2017-09-08 Thread Paul Moore
On Fri, Sep 8, 2017 at 12:40 PM, Stephen Smalley wrote: > commit d178bc3a708f39cbfefc3fab37032d3f2511b4ec ("user namespace: usb: > make usb urbs user namespace aware (v2)") changed kill_pid_info_as_uid > to kill_pid_info_as_cred, saving and passing a cred structure instead of > uids. Since the

Re: [PATCH] usb,signal,security: only pass the cred, not the secid, to kill_pid_info_as_cred and security_task_kill

2017-09-08 Thread Casey Schaufler
On 9/8/2017 9:40 AM, Stephen Smalley wrote: > commit d178bc3a708f39cbfefc3fab37032d3f2511b4ec ("user namespace: usb: > make usb urbs user namespace aware (v2)") changed kill_pid_info_as_uid > to kill_pid_info_as_cred, saving and passing a cred structure instead of > uids. That's a change I've

Re: [PATCH] usb,signal,security: only pass the cred, not the secid, to kill_pid_info_as_cred and security_task_kill

2017-09-08 Thread Casey Schaufler
On 9/8/2017 9:40 AM, Stephen Smalley wrote: > commit d178bc3a708f39cbfefc3fab37032d3f2511b4ec ("user namespace: usb: > make usb urbs user namespace aware (v2)") changed kill_pid_info_as_uid > to kill_pid_info_as_cred, saving and passing a cred structure instead of > uids. That's a change I've