Re: [PATCH] video: backlight: Remove backlight sysfs uevent

2013-11-22 Thread Matthew Garrett
On Fri, Nov 22, 2013 at 09:36:01AM -0200, Henrique de Moraes Holschuh wrote: > On Thu, 21 Nov 2013, Matthew Garrett wrote: > > The uevent support was initially added to handle systems where pressing > > a hotkey generates an event (good) but the firmware automatically > > changes the brightness

Re: [PATCH] video: backlight: Remove backlight sysfs uevent

2013-11-22 Thread Henrique de Moraes Holschuh
On Thu, 21 Nov 2013, Matthew Garrett wrote: > On Thu, Nov 21, 2013 at 09:43:32AM -0200, Henrique de Moraes Holschuh wrote: > > With this patchset applied, as far as I can tell anything that used to be > > uevent-driven by the backlight class will break: when a process changes the > > backlight

Re: [PATCH] video: backlight: Remove backlight sysfs uevent

2013-11-22 Thread Henrique de Moraes Holschuh
On Thu, 21 Nov 2013, Matthew Garrett wrote: On Thu, Nov 21, 2013 at 09:43:32AM -0200, Henrique de Moraes Holschuh wrote: With this patchset applied, as far as I can tell anything that used to be uevent-driven by the backlight class will break: when a process changes the backlight using

Re: [PATCH] video: backlight: Remove backlight sysfs uevent

2013-11-22 Thread Matthew Garrett
On Fri, Nov 22, 2013 at 09:36:01AM -0200, Henrique de Moraes Holschuh wrote: On Thu, 21 Nov 2013, Matthew Garrett wrote: The uevent support was initially added to handle systems where pressing a hotkey generates an event (good) but the firmware automatically changes the brightness (bad).

Re: [PATCH] video: backlight: Remove backlight sysfs uevent

2013-11-20 Thread Matthew Garrett
On Mon, 2013-11-11 at 22:56 -0200, Henrique de Moraes Holschuh wrote: > On Tue, 12 Nov 2013, Jingoo Han wrote: > > 'thinkpad_acpi.c' uses the 'BACKLIGHT_UPDATE_SYSFS'. > > Henrique, can we remove it? > > Can't you fix this by rate-limiting, or otherwise adding an attribute that > backlight

Re: [PATCH] video: backlight: Remove backlight sysfs uevent

2013-11-20 Thread Matthew Garrett
On Mon, 2013-11-11 at 22:56 -0200, Henrique de Moraes Holschuh wrote: On Tue, 12 Nov 2013, Jingoo Han wrote: 'thinkpad_acpi.c' uses the 'BACKLIGHT_UPDATE_SYSFS'. Henrique, can we remove it? Can't you fix this by rate-limiting, or otherwise adding an attribute that backlight devices should

Re: [PATCH] video: backlight: Remove backlight sysfs uevent

2013-11-11 Thread Kay Sievers
On Tue, Nov 12, 2013 at 3:08 AM, Kyungmin Park wrote: > On Tue, Nov 12, 2013 at 10:19 AM, Kay Sievers wrote: >> On Tue, Nov 12, 2013 at 1:56 AM, Henrique de Moraes Holschuh >> wrote: >>> On Tue, 12 Nov 2013, Jingoo Han wrote: On Tuesday, November 12, 2013 8:57 AM, Kyungmin Park wrote:

Re: [PATCH] video: backlight: Remove backlight sysfs uevent

2013-11-11 Thread Kyungmin Park
On Tue, Nov 12, 2013 at 10:19 AM, Kay Sievers wrote: > On Tue, Nov 12, 2013 at 1:56 AM, Henrique de Moraes Holschuh > wrote: >> On Tue, 12 Nov 2013, Jingoo Han wrote: >>> On Tuesday, November 12, 2013 8:57 AM, Kyungmin Park wrote: >>> > From: Kyungmin Park >>> > >>> > The most mobile phones

Re: [PATCH] video: backlight: Remove backlight sysfs uevent

2013-11-11 Thread Kay Sievers
On Tue, Nov 12, 2013 at 1:56 AM, Henrique de Moraes Holschuh wrote: > On Tue, 12 Nov 2013, Jingoo Han wrote: >> On Tuesday, November 12, 2013 8:57 AM, Kyungmin Park wrote: >> > From: Kyungmin Park >> > >> > The most mobile phones have Ambient Light Sensors and it changes >> > brightness

Re: [PATCH] video: backlight: Remove backlight sysfs uevent

2013-11-11 Thread Kyungmin Park
On Tue, Nov 12, 2013 at 9:56 AM, Henrique de Moraes Holschuh wrote: > On Tue, 12 Nov 2013, Jingoo Han wrote: >> On Tuesday, November 12, 2013 8:57 AM, Kyungmin Park wrote: >> > From: Kyungmin Park >> > >> > The most mobile phones have Ambient Light Sensors and it changes >> > brightness

Re: [PATCH] video: backlight: Remove backlight sysfs uevent

2013-11-11 Thread Henrique de Moraes Holschuh
On Tue, 12 Nov 2013, Jingoo Han wrote: > On Tuesday, November 12, 2013 8:57 AM, Kyungmin Park wrote: > > From: Kyungmin Park > > > > The most mobile phones have Ambient Light Sensors and it changes brightness > > according lux. > > It means it changes backlight brightness frequently by just

Re: [PATCH] video: backlight: Remove backlight sysfs uevent

2013-11-11 Thread Kyungmin Park
Please ignore it. strange mail system. After feedback from previous mail, I'll re-send it. Thank you, Kyungmin Park On Tue, Nov 12, 2013 at 9:44 AM, Kyungmin Park wrote: > From: Kyungmin Park > > The most mobile phones have Ambient Light Sensors and it changes brightness > according lux. >

Re: [PATCH] video: backlight: Remove backlight sysfs uevent

2013-11-11 Thread Jingoo Han
On Tuesday, November 12, 2013 8:57 AM, Kyungmin Park wrote: > > From: Kyungmin Park > > The most mobile phones have Ambient Light Sensors and it changes brightness > according lux. > It means it changes backlight brightness frequently by just writing sysfs > node, so it generates uevent. > >

Re: [PATCH] video: backlight: Remove backlight sysfs uevent

2013-11-11 Thread Jingoo Han
On Tuesday, November 12, 2013 8:57 AM, Kyungmin Park wrote: From: Kyungmin Park kyungmin.p...@samsung.com The most mobile phones have Ambient Light Sensors and it changes brightness according lux. It means it changes backlight brightness frequently by just writing sysfs node, so it

Re: [PATCH] video: backlight: Remove backlight sysfs uevent

2013-11-11 Thread Kyungmin Park
Please ignore it. strange mail system. After feedback from previous mail, I'll re-send it. Thank you, Kyungmin Park On Tue, Nov 12, 2013 at 9:44 AM, Kyungmin Park kmp...@infradead.org wrote: From: Kyungmin Park kyungmin.p...@samsung.com The most mobile phones have Ambient Light Sensors and

Re: [PATCH] video: backlight: Remove backlight sysfs uevent

2013-11-11 Thread Henrique de Moraes Holschuh
On Tue, 12 Nov 2013, Jingoo Han wrote: On Tuesday, November 12, 2013 8:57 AM, Kyungmin Park wrote: From: Kyungmin Park kyungmin.p...@samsung.com The most mobile phones have Ambient Light Sensors and it changes brightness according lux. It means it changes backlight brightness

Re: [PATCH] video: backlight: Remove backlight sysfs uevent

2013-11-11 Thread Kyungmin Park
On Tue, Nov 12, 2013 at 9:56 AM, Henrique de Moraes Holschuh h...@hmh.eng.br wrote: On Tue, 12 Nov 2013, Jingoo Han wrote: On Tuesday, November 12, 2013 8:57 AM, Kyungmin Park wrote: From: Kyungmin Park kyungmin.p...@samsung.com The most mobile phones have Ambient Light Sensors and it

Re: [PATCH] video: backlight: Remove backlight sysfs uevent

2013-11-11 Thread Kay Sievers
On Tue, Nov 12, 2013 at 1:56 AM, Henrique de Moraes Holschuh h...@hmh.eng.br wrote: On Tue, 12 Nov 2013, Jingoo Han wrote: On Tuesday, November 12, 2013 8:57 AM, Kyungmin Park wrote: From: Kyungmin Park kyungmin.p...@samsung.com The most mobile phones have Ambient Light Sensors and it

Re: [PATCH] video: backlight: Remove backlight sysfs uevent

2013-11-11 Thread Kyungmin Park
On Tue, Nov 12, 2013 at 10:19 AM, Kay Sievers k...@vrfy.org wrote: On Tue, Nov 12, 2013 at 1:56 AM, Henrique de Moraes Holschuh h...@hmh.eng.br wrote: On Tue, 12 Nov 2013, Jingoo Han wrote: On Tuesday, November 12, 2013 8:57 AM, Kyungmin Park wrote: From: Kyungmin Park

Re: [PATCH] video: backlight: Remove backlight sysfs uevent

2013-11-11 Thread Kay Sievers
On Tue, Nov 12, 2013 at 3:08 AM, Kyungmin Park kmp...@infradead.org wrote: On Tue, Nov 12, 2013 at 10:19 AM, Kay Sievers k...@vrfy.org wrote: On Tue, Nov 12, 2013 at 1:56 AM, Henrique de Moraes Holschuh h...@hmh.eng.br wrote: On Tue, 12 Nov 2013, Jingoo Han wrote: On Tuesday, November 12,