Re: [PATCH] workqueue: Fix spurious sanity check failures in destroy_workqueue()

Hello, On Thu, Sep 19, 2019 at 10:49:04AM +0800, Lai Jiangshan wrote: > Looks good to me. > > There is one test in show_pwq() > """ > worker == pwq->wq->rescuer ? "(RESCUER)" : "", > """ > I'm wondering if it needs to be updated to > """ > worker->rescue_wq ? "(RESCUER)" : "", > """ Hmm... yeah

Re: [PATCH] workqueue: Fix spurious sanity check failures in destroy_workqueue()

Looks good to me. There is one test in show_pwq() """ worker == pwq->wq->rescuer ? "(RESCUER)" : "", """ I'm wondering if it needs to be updated to """ worker->rescue_wq ? "(RESCUER)" : "", """ And document "/* MD: rescue worker */" might be better than current "/* I: rescue worker */", although