Re: [PATCH] x86/mm/pat: Fix missing preemption disable for __native_flush_tlb()

On 11/10/18 4:31 PM, Dan Williams wrote: >> If it indeed can run late in boot or after boot, then it sure looks >> buggy. Either the __flush_tlb_all() should be removed or it should >> be replaced with flush_tlb_kernel_range(). It’s unclear to me why a >> flush is needed at all, but if it’s

Re: [PATCH] x86/mm/pat: Fix missing preemption disable for __native_flush_tlb()

On 11/10/18 4:31 PM, Dan Williams wrote: >> If it indeed can run late in boot or after boot, then it sure looks >> buggy. Either the __flush_tlb_all() should be removed or it should >> be replaced with flush_tlb_kernel_range(). It’s unclear to me why a >> flush is needed at all, but if it’s

Re: [PATCH] x86/mm/pat: Fix missing preemption disable for __native_flush_tlb()

[ added Kirill ] On Sat, Nov 10, 2018 at 4:19 PM Andy Lutomirski wrote: > > On Nov 10, 2018, at 3:57 PM, Dan Williams wrote: > > > >> On Fri, Nov 9, 2018 at 4:22 PM Andy Lutomirski wrote: > >> > >> > >> > >>> On Nov 9, 2018, at 4:05 PM, Dan Williams wrote: > >>> > >>> Commit f77084d96355

Re: [PATCH] x86/mm/pat: Fix missing preemption disable for __native_flush_tlb()

[ added Kirill ] On Sat, Nov 10, 2018 at 4:19 PM Andy Lutomirski wrote: > > On Nov 10, 2018, at 3:57 PM, Dan Williams wrote: > > > >> On Fri, Nov 9, 2018 at 4:22 PM Andy Lutomirski wrote: > >> > >> > >> > >>> On Nov 9, 2018, at 4:05 PM, Dan Williams wrote: > >>> > >>> Commit f77084d96355

Re: [PATCH] x86/mm/pat: Fix missing preemption disable for __native_flush_tlb()

> On Nov 10, 2018, at 3:57 PM, Dan Williams wrote: > >> On Fri, Nov 9, 2018 at 4:22 PM Andy Lutomirski wrote: >> >> >> >>> On Nov 9, 2018, at 4:05 PM, Dan Williams wrote: >>> >>> Commit f77084d96355 "x86/mm/pat: Disable preemption around >>> __flush_tlb_all()" addressed a case where

Re: [PATCH] x86/mm/pat: Fix missing preemption disable for __native_flush_tlb()

> On Nov 10, 2018, at 3:57 PM, Dan Williams wrote: > >> On Fri, Nov 9, 2018 at 4:22 PM Andy Lutomirski wrote: >> >> >> >>> On Nov 9, 2018, at 4:05 PM, Dan Williams wrote: >>> >>> Commit f77084d96355 "x86/mm/pat: Disable preemption around >>> __flush_tlb_all()" addressed a case where

Re: [PATCH] x86/mm/pat: Fix missing preemption disable for __native_flush_tlb()

On Fri, Nov 9, 2018 at 4:22 PM Andy Lutomirski wrote: > > > > > On Nov 9, 2018, at 4:05 PM, Dan Williams wrote: > > > > Commit f77084d96355 "x86/mm/pat: Disable preemption around > > __flush_tlb_all()" addressed a case where __flush_tlb_all() is called > > without preemption being disabled. It

Re: [PATCH] x86/mm/pat: Fix missing preemption disable for __native_flush_tlb()

On Fri, Nov 9, 2018 at 4:22 PM Andy Lutomirski wrote: > > > > > On Nov 9, 2018, at 4:05 PM, Dan Williams wrote: > > > > Commit f77084d96355 "x86/mm/pat: Disable preemption around > > __flush_tlb_all()" addressed a case where __flush_tlb_all() is called > > without preemption being disabled. It

Re: [PATCH] x86/mm/pat: Fix missing preemption disable for __native_flush_tlb()

> On Nov 9, 2018, at 4:05 PM, Dan Williams wrote: > > Commit f77084d96355 "x86/mm/pat: Disable preemption around > __flush_tlb_all()" addressed a case where __flush_tlb_all() is called > without preemption being disabled. It also left a warning to catch other > cases where preemption is not

Re: [PATCH] x86/mm/pat: Fix missing preemption disable for __native_flush_tlb()

> On Nov 9, 2018, at 4:05 PM, Dan Williams wrote: > > Commit f77084d96355 "x86/mm/pat: Disable preemption around > __flush_tlb_all()" addressed a case where __flush_tlb_all() is called > without preemption being disabled. It also left a warning to catch other > cases where preemption is not