Re: [PATCH 0/6] Enable parallel page migration

2017-03-10 Thread Michal Hocko
On Fri 10-03-17 14:07:16, Mel Gorman wrote: > On Thu, Mar 09, 2017 at 05:46:16PM -0600, Zi Yan wrote: [...] > > I understand your concern on CPU utilization impact. I think checking > > CPU utilization and only using idle CPUs could potentially avoid this > > problem. > > > > That will be costly

Re: [PATCH 0/6] Enable parallel page migration

2017-03-10 Thread Michal Hocko
On Fri 10-03-17 14:07:16, Mel Gorman wrote: > On Thu, Mar 09, 2017 at 05:46:16PM -0600, Zi Yan wrote: [...] > > I understand your concern on CPU utilization impact. I think checking > > CPU utilization and only using idle CPUs could potentially avoid this > > problem. > > > > That will be costly

Re: [PATCH 0/6] Enable parallel page migration

2017-03-10 Thread Mel Gorman
On Thu, Mar 09, 2017 at 05:46:16PM -0600, Zi Yan wrote: > Hi Mel, > > Thanks for pointing out the problems in this patchset. > > It was my intern project done in NVIDIA last summer. I only used > micro-benchmarks to demonstrate the big memory bandwidth utilization gap > between base page

Re: [PATCH 0/6] Enable parallel page migration

2017-03-10 Thread Mel Gorman
On Thu, Mar 09, 2017 at 05:46:16PM -0600, Zi Yan wrote: > Hi Mel, > > Thanks for pointing out the problems in this patchset. > > It was my intern project done in NVIDIA last summer. I only used > micro-benchmarks to demonstrate the big memory bandwidth utilization gap > between base page

Re: [PATCH 0/6] Enable parallel page migration

2017-03-10 Thread Michal Hocko
On Thu 09-03-17 15:09:04, Mel Gorman wrote: > On Wed, Mar 08, 2017 at 09:34:27PM +0530, Anshuman Khandual wrote: > > > Any comments, suggestions are welcome. > > > > Hello Vlastimil/Michal/Minchan/Mel/Dave, > > > > Apart from the comments from Naoya on a different thread posted by Zi > > Yan, I

Re: [PATCH 0/6] Enable parallel page migration

2017-03-10 Thread Michal Hocko
On Thu 09-03-17 15:09:04, Mel Gorman wrote: > On Wed, Mar 08, 2017 at 09:34:27PM +0530, Anshuman Khandual wrote: > > > Any comments, suggestions are welcome. > > > > Hello Vlastimil/Michal/Minchan/Mel/Dave, > > > > Apart from the comments from Naoya on a different thread posted by Zi > > Yan, I

Re: [PATCH 0/6] Enable parallel page migration

2017-03-09 Thread Zi Yan
Hi Mel, Thanks for pointing out the problems in this patchset. It was my intern project done in NVIDIA last summer. I only used micro-benchmarks to demonstrate the big memory bandwidth utilization gap between base page migration and THP migration along with serialized page migration vs parallel

Re: [PATCH 0/6] Enable parallel page migration

2017-03-09 Thread Zi Yan
Hi Mel, Thanks for pointing out the problems in this patchset. It was my intern project done in NVIDIA last summer. I only used micro-benchmarks to demonstrate the big memory bandwidth utilization gap between base page migration and THP migration along with serialized page migration vs parallel

Re: [PATCH 0/6] Enable parallel page migration

2017-03-09 Thread Mel Gorman
On Thu, Mar 09, 2017 at 11:38:00AM -0600, David Nellans wrote: > On 03/09/2017 09:09 AM, Mel Gorman wrote: > > I didn't look into the patches in detail except to get a general feel > > for how it works and I'm not convinced that it's a good idea at all. > > > > I accept that memory bandwidth

Re: [PATCH 0/6] Enable parallel page migration

2017-03-09 Thread Mel Gorman
On Thu, Mar 09, 2017 at 11:38:00AM -0600, David Nellans wrote: > On 03/09/2017 09:09 AM, Mel Gorman wrote: > > I didn't look into the patches in detail except to get a general feel > > for how it works and I'm not convinced that it's a good idea at all. > > > > I accept that memory bandwidth

Re: [PATCH 0/6] Enable parallel page migration

2017-03-09 Thread David Nellans
On 03/09/2017 09:09 AM, Mel Gorman wrote: > I didn't look into the patches in detail except to get a general feel > for how it works and I'm not convinced that it's a good idea at all. > > I accept that memory bandwidth utilisation may be higher as a result but > consider the impact. THP

Re: [PATCH 0/6] Enable parallel page migration

2017-03-09 Thread David Nellans
On 03/09/2017 09:09 AM, Mel Gorman wrote: > I didn't look into the patches in detail except to get a general feel > for how it works and I'm not convinced that it's a good idea at all. > > I accept that memory bandwidth utilisation may be higher as a result but > consider the impact. THP

Re: [PATCH 0/6] Enable parallel page migration

2017-03-09 Thread Mel Gorman
On Wed, Mar 08, 2017 at 09:34:27PM +0530, Anshuman Khandual wrote: > > Any comments, suggestions are welcome. > > Hello Vlastimil/Michal/Minchan/Mel/Dave, > > Apart from the comments from Naoya on a different thread posted by Zi > Yan, I did not get any more review comments on this series. Could

Re: [PATCH 0/6] Enable parallel page migration

2017-03-09 Thread Mel Gorman
On Wed, Mar 08, 2017 at 09:34:27PM +0530, Anshuman Khandual wrote: > > Any comments, suggestions are welcome. > > Hello Vlastimil/Michal/Minchan/Mel/Dave, > > Apart from the comments from Naoya on a different thread posted by Zi > Yan, I did not get any more review comments on this series. Could

Re: [PATCH 0/6] Enable parallel page migration

2017-03-08 Thread Anshuman Khandual
On 02/17/2017 04:54 PM, Anshuman Khandual wrote: > This patch series is base on the work posted by Zi Yan back in > November 2016 (https://lkml.org/lkml/2016/11/22/457) but includes some > amount clean up and re-organization. This series depends on THP migration > optimization patch series

Re: [PATCH 0/6] Enable parallel page migration

2017-03-08 Thread Anshuman Khandual
On 02/17/2017 04:54 PM, Anshuman Khandual wrote: > This patch series is base on the work posted by Zi Yan back in > November 2016 (https://lkml.org/lkml/2016/11/22/457) but includes some > amount clean up and re-organization. This series depends on THP migration > optimization patch series

Re: [PATCH 0/6] Enable parallel page migration

2017-02-22 Thread Balbir Singh
On 22/02/17 16:55, Anshuman Khandual wrote: > On 02/22/2017 10:34 AM, Balbir Singh wrote: >> On Fri, Feb 17, 2017 at 04:54:47PM +0530, Anshuman Khandual wrote: >>> This patch series is base on the work posted by Zi Yan back in >>> November 2016 (https://lkml.org/lkml/2016/11/22/457) but

Re: [PATCH 0/6] Enable parallel page migration

2017-02-22 Thread Balbir Singh
On 22/02/17 16:55, Anshuman Khandual wrote: > On 02/22/2017 10:34 AM, Balbir Singh wrote: >> On Fri, Feb 17, 2017 at 04:54:47PM +0530, Anshuman Khandual wrote: >>> This patch series is base on the work posted by Zi Yan back in >>> November 2016 (https://lkml.org/lkml/2016/11/22/457) but

Re: [PATCH 0/6] Enable parallel page migration

2017-02-21 Thread Anshuman Khandual
On 02/22/2017 10:34 AM, Balbir Singh wrote: > On Fri, Feb 17, 2017 at 04:54:47PM +0530, Anshuman Khandual wrote: >> This patch series is base on the work posted by Zi Yan back in >> November 2016 (https://lkml.org/lkml/2016/11/22/457) but includes some >> amount clean up and re-organization.

Re: [PATCH 0/6] Enable parallel page migration

2017-02-21 Thread Anshuman Khandual
On 02/22/2017 10:34 AM, Balbir Singh wrote: > On Fri, Feb 17, 2017 at 04:54:47PM +0530, Anshuman Khandual wrote: >> This patch series is base on the work posted by Zi Yan back in >> November 2016 (https://lkml.org/lkml/2016/11/22/457) but includes some >> amount clean up and re-organization.

Re: [PATCH 0/6] Enable parallel page migration

2017-02-21 Thread Balbir Singh
On Fri, Feb 17, 2017 at 04:54:47PM +0530, Anshuman Khandual wrote: > This patch series is base on the work posted by Zi Yan back in > November 2016 (https://lkml.org/lkml/2016/11/22/457) but includes some > amount clean up and re-organization. This series depends on THP migration >

Re: [PATCH 0/6] Enable parallel page migration

2017-02-21 Thread Balbir Singh
On Fri, Feb 17, 2017 at 04:54:47PM +0530, Anshuman Khandual wrote: > This patch series is base on the work posted by Zi Yan back in > November 2016 (https://lkml.org/lkml/2016/11/22/457) but includes some > amount clean up and re-organization. This series depends on THP migration >