Re: [PATCH 00/10 v2] iommu/amd: lock splitting & GFP_KERNEL allocation

2018-03-19 Thread Scott Wood
On Mon, 2018-03-19 at 13:15 +0100, Sebastian Andrzej Siewior wrote: > On 2018-03-17 16:43:39 [-0500], Scott Wood wrote: > > If that's worth the lock dropping then fine (though why does only > > one > > of the two allocations use GFP_KERNEL?), but it doesn't need to be > > a > > That was a

Re: [PATCH 00/10 v2] iommu/amd: lock splitting & GFP_KERNEL allocation

2018-03-19 Thread Scott Wood
On Mon, 2018-03-19 at 13:15 +0100, Sebastian Andrzej Siewior wrote: > On 2018-03-17 16:43:39 [-0500], Scott Wood wrote: > > If that's worth the lock dropping then fine (though why does only > > one > > of the two allocations use GFP_KERNEL?), but it doesn't need to be > > a > > That was a

Re: [PATCH 00/10 v2] iommu/amd: lock splitting & GFP_KERNEL allocation

2018-03-19 Thread Sebastian Andrzej Siewior
On 2018-03-17 16:43:39 [-0500], Scott Wood wrote: > If that's worth the lock dropping then fine (though why does only one > of the two allocations use GFP_KERNEL?), but it doesn't need to be a That was a mistake, I planned to keep both as GFP_KERNEL. > raw lock if the non-allocating users are

Re: [PATCH 00/10 v2] iommu/amd: lock splitting & GFP_KERNEL allocation

2018-03-19 Thread Sebastian Andrzej Siewior
On 2018-03-17 16:43:39 [-0500], Scott Wood wrote: > If that's worth the lock dropping then fine (though why does only one > of the two allocations use GFP_KERNEL?), but it doesn't need to be a That was a mistake, I planned to keep both as GFP_KERNEL. > raw lock if the non-allocating users are

Re: [PATCH 00/10 v2] iommu/amd: lock splitting & GFP_KERNEL allocation

2018-03-17 Thread Scott Wood
On Sat, 2018-03-17 at 22:10 +0100, Sebastian Andrzej Siewior wrote: > On 2018-03-17 14:49:54 [-0500], Scott Wood wrote: > > On Fri, 2018-03-16 at 21:18 +0100, Sebastian Andrzej Siewior wrote: > > > The goal here is to make the memory allocation in get_irq_table() > > > not > > > with disabled

Re: [PATCH 00/10 v2] iommu/amd: lock splitting & GFP_KERNEL allocation

2018-03-17 Thread Scott Wood
On Sat, 2018-03-17 at 22:10 +0100, Sebastian Andrzej Siewior wrote: > On 2018-03-17 14:49:54 [-0500], Scott Wood wrote: > > On Fri, 2018-03-16 at 21:18 +0100, Sebastian Andrzej Siewior wrote: > > > The goal here is to make the memory allocation in get_irq_table() > > > not > > > with disabled

Re: [PATCH 00/10 v2] iommu/amd: lock splitting & GFP_KERNEL allocation

2018-03-17 Thread Sebastian Andrzej Siewior
On 2018-03-17 14:49:54 [-0500], Scott Wood wrote: > On Fri, 2018-03-16 at 21:18 +0100, Sebastian Andrzej Siewior wrote: > > The goal here is to make the memory allocation in get_irq_table() not > > with disabled interrupts and having as little raw_spin_lock as > > possible > > while having them if

Re: [PATCH 00/10 v2] iommu/amd: lock splitting & GFP_KERNEL allocation

2018-03-17 Thread Sebastian Andrzej Siewior
On 2018-03-17 14:49:54 [-0500], Scott Wood wrote: > On Fri, 2018-03-16 at 21:18 +0100, Sebastian Andrzej Siewior wrote: > > The goal here is to make the memory allocation in get_irq_table() not > > with disabled interrupts and having as little raw_spin_lock as > > possible > > while having them if

Re: [PATCH 00/10 v2] iommu/amd: lock splitting & GFP_KERNEL allocation

2018-03-17 Thread Scott Wood
On Fri, 2018-03-16 at 21:18 +0100, Sebastian Andrzej Siewior wrote: > The goal here is to make the memory allocation in get_irq_table() not > with disabled interrupts and having as little raw_spin_lock as > possible > while having them if the caller is also holding one (like desc->lock > during

Re: [PATCH 00/10 v2] iommu/amd: lock splitting & GFP_KERNEL allocation

2018-03-17 Thread Scott Wood
On Fri, 2018-03-16 at 21:18 +0100, Sebastian Andrzej Siewior wrote: > The goal here is to make the memory allocation in get_irq_table() not > with disabled interrupts and having as little raw_spin_lock as > possible > while having them if the caller is also holding one (like desc->lock > during