Re: [PATCH 00/13] nvdimm: Use more common kernel coding style

2019-09-12 Thread Joe Perches
On Thu, 2019-09-12 at 16:00 -0700, Nick Desaulniers wrote: > Consider the fact that not all kernel developers run checkpatch.pl. > Is that a deficiency in checkpatch.pl, or the lack of enforcement in > kernel developers' workflows? No. Mostly it's because the kernel is like a bunch of little

Re: [PATCH 00/13] nvdimm: Use more common kernel coding style

2019-09-12 Thread Nick Desaulniers
On Thu, Sep 12, 2019 at 3:38 PM Joe Perches wrote: > > On Thu, 2019-09-12 at 23:58 +0200, Miguel Ojeda wrote: > > On Thu, Sep 12, 2019 at 11:08 PM Joe Perches wrote: > > > Please name the major projects and then point to their > > > .clang-format equivalents. > > > > > > Also note the

Re: [PATCH 00/13] nvdimm: Use more common kernel coding style

2019-09-12 Thread Nick Desaulniers
On Thu, Sep 12, 2019 at 2:58 PM Miguel Ojeda wrote: > > On Thu, Sep 12, 2019 at 11:08 PM Joe Perches wrote: > > > > Please name the major projects and then point to their > > .clang-format equivalents. > > > > Also note the size/scope/complexity of the major projects. > > Mozilla, WebKit, LLVM

Re: [PATCH 00/13] nvdimm: Use more common kernel coding style

2019-09-12 Thread Joe Perches
On Thu, 2019-09-12 at 23:58 +0200, Miguel Ojeda wrote: > On Thu, Sep 12, 2019 at 11:08 PM Joe Perches wrote: > > Please name the major projects and then point to their > > .clang-format equivalents. > > > > Also note the size/scope/complexity of the major projects. > > Mozilla, WebKit, LLVM and

Re: [PATCH 00/13] nvdimm: Use more common kernel coding style

2019-09-12 Thread Joe Perches
On Thu, 2019-09-12 at 23:58 +0200, Miguel Ojeda wrote: > On Thu, Sep 12, 2019 at 11:08 PM Joe Perches wrote: > > Please name the major projects and then point to their > > .clang-format equivalents. > > > > Also note the size/scope/complexity of the major projects. > > Mozilla, WebKit, LLVM and

Re: [PATCH 00/13] nvdimm: Use more common kernel coding style

2019-09-12 Thread Miguel Ojeda
On Thu, Sep 12, 2019 at 11:08 PM Joe Perches wrote: > > Please name the major projects and then point to their > .clang-format equivalents. > > Also note the size/scope/complexity of the major projects. Mozilla, WebKit, LLVM and Microsoft. They have their style distributed with the official

Re: [PATCH 00/13] nvdimm: Use more common kernel coding style

2019-09-12 Thread Joe Perches
On Thu, 2019-09-12 at 16:21 +0200, Miguel Ojeda wrote: > As soon as you get accustomed to have formatting done and enforced > automatically, it is great. Other major projects have done so for > quite a while now. Please name the major projects and then point to their .clang-format equivalents.

Re: [PATCH 00/13] nvdimm: Use more common kernel coding style

2019-09-12 Thread Dan Williams
On Thu, Sep 12, 2019 at 7:06 AM Johannes Thumshirn wrote: > > On 12/09/2019 16:00, Jeff Moyer wrote: > > I'd rather avoid the churn and the risk of > > introducing regressions. This will also make backports to stable more > > of a pain, so it isn't without cost. Dan, is this really something

Re: [PATCH 00/13] nvdimm: Use more common kernel coding style

2019-09-12 Thread Miguel Ojeda
On Thu, Sep 12, 2019 at 4:00 PM Jeff Moyer wrote: > > Joe Perches writes: > > > Rather than have a local coding style, use the typical kernel style. > > The coding style isn't that different from the core kernel, and it's > still quite readable. I'd rather avoid the churn and the risk of >

Re: [PATCH 00/13] nvdimm: Use more common kernel coding style

2019-09-12 Thread Johannes Thumshirn
On 12/09/2019 16:00, Jeff Moyer wrote: > I'd rather avoid the churn and the risk of > introducing regressions. This will also make backports to stable more > of a pain, so it isn't without cost. Dan, is this really something you > want to do? I'm a 100% with Jeff on this! -- Johannes

Re: [PATCH 00/13] nvdimm: Use more common kernel coding style

2019-09-12 Thread Jeff Moyer
Joe Perches writes: > Rather than have a local coding style, use the typical kernel style. The coding style isn't that different from the core kernel, and it's still quite readable. I'd rather avoid the churn and the risk of introducing regressions. This will also make backports to stable

Re: [PATCH 00/13] nvdimm: Use more common kernel coding style

2019-09-12 Thread Miguel Ojeda
On Thu, Sep 12, 2019 at 10:15 AM Joe Perches wrote: > > I am adding Miguel Ojeda to the cc's. Thanks Joe! > Of course you are welcome to try it, but I believe that > clang-format doesn't work all that well yet. > > It's more a work in progress rather than a "standard". > > I believe you'll find

Re: [PATCH 00/13] nvdimm: Use more common kernel coding style

2019-09-12 Thread Joe Perches
On Thu, 2019-09-12 at 01:00 -0700, Dan Williams wrote: > Hi Joe, > > On Wed, Sep 11, 2019 at 7:55 PM Joe Perches wrote: > > Rather than have a local coding style, use the typical kernel style. > > I'd rather automate this. I'm going to do once-over with clang-format > and see what falls out. I

Re: [PATCH 00/13] nvdimm: Use more common kernel coding style

2019-09-12 Thread Dan Williams
Hi Joe, On Wed, Sep 11, 2019 at 7:55 PM Joe Perches wrote: > > Rather than have a local coding style, use the typical kernel style. I'd rather automate this. I'm going to do once-over with clang-format and see what falls out.